Hello community, here is the log from the commit of package latexila for openSUSE:Factory checked in at 2015-04-25 09:53:28 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Comparing /work/SRC/openSUSE:Factory/latexila (Old) and /work/SRC/openSUSE:Factory/.latexila.new (New) ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "latexila" Changes: -------- --- /work/SRC/openSUSE:Factory/latexila/latexila.changes 2015-04-13 20:30:56.000000000 +0200 +++ /work/SRC/openSUSE:Factory/.latexila.new/latexila.changes 2015-04-25 11:26:01.000000000 +0200 @@ -1,0 +2,7 @@ +Sun Apr 19 11:14:09 UTC 2015 - zai...@opensuse.org + +- Update to version 3.16.1: + + Fix the build with -Werror=format-security. + + Important bug fix when deleting several templates at once. + +------------------------------------------------------------------- Old: ---- latexila-3.16.0.tar.xz New: ---- latexila-3.16.1.tar.xz ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Other differences: ------------------ ++++++ latexila.spec ++++++ --- /var/tmp/diff_new_pack.3bRbii/_old 2015-04-25 11:26:02.000000000 +0200 +++ /var/tmp/diff_new_pack.3bRbii/_new 2015-04-25 11:26:02.000000000 +0200 @@ -17,7 +17,7 @@ Name: latexila -Version: 3.16.0 +Version: 3.16.1 Release: 0 Summary: Integrated LaTeX Environment for the GNOME desktop License: GPL-3.0+ ++++++ latexila-3.16.0.tar.xz -> latexila-3.16.1.tar.xz ++++++ diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/latexila-3.16.0/NEWS new/latexila-3.16.1/NEWS --- old/latexila-3.16.0/NEWS 2015-03-25 10:59:53.000000000 +0100 +++ new/latexila-3.16.1/NEWS 2015-04-19 11:08:12.000000000 +0200 @@ -1,5 +1,10 @@ LaTeXila NEWS +Release 3.16.1 +-------------- +* Fix the build with -Werror=format-security (Kalev Lember) +* Important bug fix when deleting several templates at once + Release 3.16.0 -------------- * Show information about LaTeXila fundraiser diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/latexila-3.16.0/README new/latexila-3.16.1/README --- old/latexila-3.16.0/README 2015-03-25 11:00:28.000000000 +0100 +++ new/latexila-3.16.1/README 2015-04-19 11:09:51.000000000 +0200 @@ -1,7 +1,7 @@ General Information =================== -This is the version 3.16.0 of LaTeXila. +This is the version 3.16.1 of LaTeXila. LaTeXila is an Integrated LaTeX Environment for the GNOME desktop. LaTeXila is released under the GNU General Public License (GPL) version 3 or diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/latexila-3.16.0/aclocal.m4 new/latexila-3.16.1/aclocal.m4 --- old/latexila-3.16.0/aclocal.m4 2015-03-25 11:00:22.000000000 +0100 +++ new/latexila-3.16.1/aclocal.m4 2015-04-19 11:09:44.000000000 +0200 @@ -493,7 +493,7 @@ # gnome-compiler-flags.m4 # -# serial 2 +# serial 4 # dnl GNOME_COMPILE_WARNINGS @@ -505,7 +505,7 @@ dnl Additional warning/error flags can be passed as an optional second argument. dnl dnl For example: GNOME_COMPILE_WARNINGS([maximum],[-Werror=some-flag -Wfoobar]) -AC_DEFUN([GNOME_COMPILE_WARNINGS],[ +AU_DEFUN([GNOME_COMPILE_WARNINGS],[ dnl ****************************** dnl More compiler warnings dnl ****************************** @@ -542,6 +542,7 @@ -Werror=format-security \ -Werror=format=2 \ -Werror=missing-include-dirs \ + -Werror=return-type \ " dnl Additional warning or error flags provided by the module author to @@ -612,11 +613,14 @@ WARN_CFLAGS="$tested_warning_flags $complCFLAGS" AC_SUBST(WARN_CFLAGS) -]) +], +[[$0: This macro is deprecated. You should use AX_COMPILER_FLAGS instead and +eliminate use of --enable-iso-c. +See: http://www.gnu.org/software/autoconf-archive/ax_compiler_flags.html#ax_compiler_flags]]) dnl For C++, do basically the same thing. -AC_DEFUN([GNOME_CXX_WARNINGS],[ +AU_DEFUN([GNOME_CXX_WARNINGS],[ AC_ARG_ENABLE(cxx-warnings, AS_HELP_STRING([--enable-cxx-warnings=@<:@no/minimum/yes@:>@] [Turn on compiler warnings.]),, @@ -667,7 +671,10 @@ WARN_CXXFLAGS="$CXXFLAGS $warnCXXFLAGS $complCXXFLAGS" AC_SUBST(WARN_CXXFLAGS) -]) +], +[[$0: This macro is deprecated. You should use AX_COMPILER_FLAGS instead and +eliminate use of --enable-iso-cxx. +See: http://www.gnu.org/software/autoconf-archive/ax_compiler_flags.html#ax_compiler_flags]]) dnl GLIB_GSETTINGS dnl Defines GSETTINGS_SCHEMAS_INSTALL which controls whether diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/latexila-3.16.0/configure new/latexila-3.16.1/configure --- old/latexila-3.16.0/configure 2015-03-25 11:00:23.000000000 +0100 +++ new/latexila-3.16.1/configure 2015-04-19 11:09:45.000000000 +0200 @@ -1,6 +1,6 @@ #! /bin/sh # Guess values for system-dependent variables and create Makefiles. -# Generated by GNU Autoconf 2.69 for LaTeXila 3.16.0. +# Generated by GNU Autoconf 2.69 for LaTeXila 3.16.1. # # Report bugs to <https://bugzilla.gnome.org/enter_bug.cgi?product=latexila>. # @@ -651,8 +651,8 @@ # Identity of this package. PACKAGE_NAME='LaTeXila' PACKAGE_TARNAME='latexila' -PACKAGE_VERSION='3.16.0' -PACKAGE_STRING='LaTeXila 3.16.0' +PACKAGE_VERSION='3.16.1' +PACKAGE_STRING='LaTeXila 3.16.1' PACKAGE_BUGREPORT='https://bugzilla.gnome.org/enter_bug.cgi?product=latexila' PACKAGE_URL='https://wiki.gnome.org/Apps/LaTeXila' @@ -1498,7 +1498,7 @@ # Omit some internal or obsolete options to make the list less imposing. # This message is too long to be a string in the A/UX 3.1 sh. cat <<_ACEOF -\`configure' configures LaTeXila 3.16.0 to adapt to many kinds of systems. +\`configure' configures LaTeXila 3.16.1 to adapt to many kinds of systems. Usage: $0 [OPTION]... [VAR=VALUE]... @@ -1568,7 +1568,7 @@ if test -n "$ac_init_help"; then case $ac_init_help in - short | recursive ) echo "Configuration of LaTeXila 3.16.0:";; + short | recursive ) echo "Configuration of LaTeXila 3.16.1:";; esac cat <<\_ACEOF @@ -1704,7 +1704,7 @@ test -n "$ac_init_help" && exit $ac_status if $ac_init_version; then cat <<\_ACEOF -LaTeXila configure 3.16.0 +LaTeXila configure 3.16.1 generated by GNU Autoconf 2.69 Copyright (C) 2012 Free Software Foundation, Inc. @@ -1982,7 +1982,7 @@ This file contains any messages produced by compilers while running configure, to aid debugging if configure makes a mistake. -It was created by LaTeXila $as_me 3.16.0, which was +It was created by LaTeXila $as_me 3.16.1, which was generated by GNU Autoconf 2.69. Invocation command line was $ $0 $@ @@ -2852,7 +2852,7 @@ # Define the identity of the package. PACKAGE='latexila' - VERSION='3.16.0' + VERSION='3.16.1' cat >>confdefs.h <<_ACEOF @@ -13934,6 +13934,7 @@ -Werror=format-security \ -Werror=format=2 \ -Werror=missing-include-dirs \ + -Werror=return-type \ " additional_flags="" @@ -15571,7 +15572,7 @@ # report actual input values of CONFIG_FILES etc. instead of their # values after options handling. ac_log=" -This file was extended by LaTeXila $as_me 3.16.0, which was +This file was extended by LaTeXila $as_me 3.16.1, which was generated by GNU Autoconf 2.69. Invocation command line was CONFIG_FILES = $CONFIG_FILES @@ -15638,7 +15639,7 @@ cat >>$CONFIG_STATUS <<_ACEOF || ac_write_fail=1 ac_cs_config="`$as_echo "$ac_configure_args" | sed 's/^ //; s/[\\""\`\$]/\\\\&/g'`" ac_cs_version="\\ -LaTeXila config.status 3.16.0 +LaTeXila config.status 3.16.1 configured by $0, generated by GNU Autoconf 2.69, with options \\"\$ac_cs_config\\" diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/latexila-3.16.0/configure.ac new/latexila-3.16.1/configure.ac --- old/latexila-3.16.0/configure.ac 2015-03-25 10:59:53.000000000 +0100 +++ new/latexila-3.16.1/configure.ac 2015-04-19 11:03:51.000000000 +0200 @@ -5,7 +5,7 @@ AC_PREREQ([2.64]) AC_INIT([LaTeXila], - [3.16.0], + [3.16.1], [https://bugzilla.gnome.org/enter_bug.cgi?product=latexila], [latexila], [https://wiki.gnome.org/Apps/LaTeXila]) diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/latexila-3.16.0/data/latexila.desktop.in new/latexila-3.16.1/data/latexila.desktop.in --- old/latexila-3.16.0/data/latexila.desktop.in 2015-03-25 11:00:27.000000000 +0100 +++ new/latexila-3.16.1/data/latexila.desktop.in 2015-04-19 11:09:50.000000000 +0200 @@ -14,7 +14,7 @@ X-GNOME-Bugzilla-Bugzilla=GNOME X-GNOME-Bugzilla-Product=latexila X-GNOME-Bugzilla-Component=other -X-GNOME-Bugzilla-Version=3.16.0 +X-GNOME-Bugzilla-Version=3.16.1 [Desktop Action Window] _Name=Open a New Window diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/latexila-3.16.0/data/templates/letter.xml new/latexila-3.16.1/data/templates/letter.xml --- old/latexila-3.16.0/data/templates/letter.xml 2014-12-27 16:45:44.000000000 +0100 +++ new/latexila-3.16.1/data/templates/letter.xml 2015-04-18 19:05:46.000000000 +0200 @@ -1,5 +1,5 @@ <template xmlns:its="http://www.w3.org/2005/11/its"> -<translatableChunk its:locNote="There is a helper script in data/templates/tex2po.sh"> +<translatableChunk> \documentclass[a4paper,11pt]{letter} \usepackage[T1]{fontenc} \usepackage[utf8]{inputenc} diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/latexila-3.16.0/data/templates/templates.pot new/latexila-3.16.1/data/templates/templates.pot --- old/latexila-3.16.0/data/templates/templates.pot 2015-03-18 13:48:13.000000000 +0100 +++ new/latexila-3.16.1/data/templates/templates.pot 2015-04-18 19:05:46.000000000 +0200 @@ -1,7 +1,7 @@ msgid "" msgstr "" "Project-Id-Version: PACKAGE VERSION\n" -"POT-Creation-Date: 2014-10-05 19:04+0200\n" +"POT-Creation-Date: 2015-04-12 15:00+0200\n" "PO-Revision-Date: YEAR-MO-DA HO:MI+ZONE\n" "Last-Translator: FULL NAME <EMAIL@ADDRESS>\n" "Language-Team: LANGUAGE <l...@li.org>\n" @@ -23,7 +23,6 @@ msgstr "" #. (itstool) path: template/translatableChunk -#. There is a helper script in data/templates/tex2po.sh #: letter.xml:2 #, no-wrap msgid "" diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/latexila-3.16.0/src/document_view.c new/latexila-3.16.1/src/document_view.c --- old/latexila-3.16.0/src/document_view.c 2015-03-25 11:00:40.000000000 +0100 +++ new/latexila-3.16.1/src/document_view.c 2015-04-19 11:10:04.000000000 +0200 @@ -662,7 +662,7 @@ GSettings* _tmp24_ = NULL; _tmp11_ = gtk_widget_get_toplevel ((GtkWidget*) self); _tmp12_ = _ ("No dictionaries available for the spell checking."); - _tmp13_ = (GtkMessageDialog*) gtk_message_dialog_new (G_TYPE_CHECK_INSTANCE_TYPE (_tmp11_, gtk_window_get_type ()) ? ((GtkWindow*) _tmp11_) : NULL, GTK_DIALOG_DESTROY_WITH_PARENT, GTK_MESSAGE_ERROR, GTK_BUTTONS_NONE, _tmp12_); + _tmp13_ = (GtkMessageDialog*) gtk_message_dialog_new (G_TYPE_CHECK_INSTANCE_TYPE (_tmp11_, gtk_window_get_type ()) ? ((GtkWindow*) _tmp11_) : NULL, GTK_DIALOG_DESTROY_WITH_PARENT, GTK_MESSAGE_ERROR, GTK_BUTTONS_NONE, "%s", _tmp12_); g_object_ref_sink (_tmp13_); dialog = _tmp13_; _tmp14_ = dialog; diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/latexila-3.16.0/src/document_view.vala new/latexila-3.16.1/src/document_view.vala --- old/latexila-3.16.0/src/document_view.vala 2015-03-18 13:48:13.000000000 +0100 +++ new/latexila-3.16.1/src/document_view.vala 2015-04-18 19:48:43.000000000 +0200 @@ -201,7 +201,7 @@ DialogFlags.DESTROY_WITH_PARENT, MessageType.ERROR, ButtonsType.NONE, - _("No dictionaries available for the spell checking.")); + "%s", _("No dictionaries available for the spell checking.")); dialog.add_buttons (_("_Help"), ResponseType.HELP, _("_OK"), ResponseType.OK, diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/latexila-3.16.0/src/liblatexila/latexila-build-tools.c new/latexila-3.16.1/src/liblatexila/latexila-build-tools.c --- old/latexila-3.16.0/src/liblatexila/latexila-build-tools.c 2015-03-18 13:48:13.000000000 +0100 +++ new/latexila-3.16.1/src/liblatexila/latexila-build-tools.c 2015-04-18 19:05:46.000000000 +0200 @@ -293,7 +293,7 @@ { LatexilaBuildTools *build_tools = user_data; const gchar *element_name = g_markup_parse_context_get_element (context); - gchar *stripped_text = g_strdup (text); + gchar *stripped_text = g_strndup (text, text_len); stripped_text = g_strstrip (stripped_text); if (g_str_equal (element_name, "job")) diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/latexila-3.16.0/src/templates_dialogs.c new/latexila-3.16.1/src/templates_dialogs.c --- old/latexila-3.16.0/src/templates_dialogs.c 2015-03-25 11:00:41.000000000 +0100 +++ new/latexila-3.16.1/src/templates_dialogs.c 2015-04-19 11:10:05.000000000 +0200 @@ -109,6 +109,8 @@ typedef struct _DeleteTemplateDialog DeleteTemplateDialog; typedef struct _DeleteTemplateDialogClass DeleteTemplateDialogClass; typedef struct _DeleteTemplateDialogPrivate DeleteTemplateDialogPrivate; +#define _gtk_tree_row_reference_free0(var) ((var == NULL) ? NULL : (var = (gtk_tree_row_reference_free (var), NULL))) +#define __g_list_free__gtk_tree_row_reference_free0_0(var) ((var == NULL) ? NULL : (var = (_g_list_free__gtk_tree_row_reference_free0_ (var), NULL))) struct _OpenTemplateDialog { GTypeInstance parent_instance; @@ -227,6 +229,8 @@ DeleteTemplateDialog* delete_template_dialog_construct (GType object_type, MainWindow* parent); static void delete_template_dialog_run_me (DeleteTemplateDialog* self, GtkTreeView* templates_list); void templates_delete_personal_template (Templates* self, GtkTreePath* template_path); +static void _gtk_tree_row_reference_free0_ (gpointer var); +static void _g_list_free__gtk_tree_row_reference_free0_ (GList* self); void templates_save_rc_file (Templates* self); @@ -1096,6 +1100,22 @@ } +static gpointer _gtk_tree_row_reference_copy0 (gpointer self) { + return self ? gtk_tree_row_reference_copy (self) : NULL; +} + + +static void _gtk_tree_row_reference_free0_ (gpointer var) { + (var == NULL) ? NULL : (var = (gtk_tree_row_reference_free (var), NULL)); +} + + +static void _g_list_free__gtk_tree_row_reference_free0_ (GList* self) { + g_list_foreach (self, (GFunc) _gtk_tree_row_reference_free0_, NULL); + g_list_free (self); +} + + static void delete_template_dialog_run_me (DeleteTemplateDialog* self, GtkTreeView* templates_list) { Templates* templates = NULL; Templates* _tmp0_ = NULL; @@ -1112,12 +1132,14 @@ GtkTreeView* _tmp2_ = NULL; GtkTreeSelection* _tmp3_ = NULL; GtkTreeSelection* _tmp4_ = NULL; - GList* selected_items = NULL; + GtkTreeModel* model = NULL; + GList* selected_rows = NULL; GtkTreeSelection* _tmp5_ = NULL; - GList* _tmp6_ = NULL; - guint nb_selected_items = 0U; + GtkTreeModel* _tmp6_ = NULL; GList* _tmp7_ = NULL; - guint _tmp8_ = 0U; + GList* row_refs = NULL; + GList* _tmp8_ = NULL; + GList* _tmp13_ = NULL; _tmp1_ = gtk_dialog_run ((GtkDialog*) self); if (!(_tmp1_ == ((gint) GTK_RESPONSE_ACCEPT))) { break; @@ -1127,52 +1149,62 @@ _tmp4_ = _g_object_ref0 (_tmp3_); select = _tmp4_; _tmp5_ = select; - _tmp6_ = gtk_tree_selection_get_selected_rows (_tmp5_, NULL); - selected_items = _tmp6_; - _tmp7_ = selected_items; - _tmp8_ = g_list_length (_tmp7_); - nb_selected_items = _tmp8_; + _tmp7_ = gtk_tree_selection_get_selected_rows (_tmp5_, &_tmp6_); + model = _tmp6_; + selected_rows = _tmp7_; + row_refs = NULL; + _tmp8_ = selected_rows; + { + GList* path_collection = NULL; + GList* path_it = NULL; + path_collection = _tmp8_; + for (path_it = path_collection; path_it != NULL; path_it = path_it->next) { + GtkTreePath* _tmp9_ = NULL; + GtkTreePath* path = NULL; + _tmp9_ = _gtk_tree_path_copy0 ((GtkTreePath*) path_it->data); + path = _tmp9_; + { + GtkTreeModel* _tmp10_ = NULL; + GtkTreePath* _tmp11_ = NULL; + GtkTreeRowReference* _tmp12_ = NULL; + _tmp10_ = model; + _tmp11_ = path; + _tmp12_ = gtk_tree_row_reference_new (_tmp10_, _tmp11_); + row_refs = g_list_prepend (row_refs, _tmp12_); + _gtk_tree_path_free0 (path); + } + } + } + _tmp13_ = row_refs; { - gint item_num = 0; - item_num = 0; - { - gboolean _tmp9_ = FALSE; - _tmp9_ = TRUE; - while (TRUE) { - gint _tmp11_ = 0; - guint _tmp12_ = 0U; + GList* row_ref_collection = NULL; + GList* row_ref_it = NULL; + row_ref_collection = _tmp13_; + for (row_ref_it = row_ref_collection; row_ref_it != NULL; row_ref_it = row_ref_it->next) { + GtkTreeRowReference* _tmp14_ = NULL; + GtkTreeRowReference* row_ref = NULL; + _tmp14_ = _gtk_tree_row_reference_copy0 ((const GtkTreeRowReference*) row_ref_it->data); + row_ref = _tmp14_; + { GtkTreePath* path = NULL; - GList* _tmp13_ = NULL; - gint _tmp14_ = 0; - gconstpointer _tmp15_ = NULL; + const GtkTreeRowReference* _tmp15_ = NULL; GtkTreePath* _tmp16_ = NULL; Templates* _tmp17_ = NULL; GtkTreePath* _tmp18_ = NULL; - if (!_tmp9_) { - gint _tmp10_ = 0; - _tmp10_ = item_num; - item_num = _tmp10_ + 1; - } - _tmp9_ = FALSE; - _tmp11_ = item_num; - _tmp12_ = nb_selected_items; - if (!(((guint) _tmp11_) < _tmp12_)) { - break; - } - _tmp13_ = selected_items; - _tmp14_ = item_num; - _tmp15_ = g_list_nth_data (_tmp13_, (guint) _tmp14_); - _tmp16_ = _gtk_tree_path_copy0 ((GtkTreePath*) _tmp15_); + _tmp15_ = row_ref; + _tmp16_ = gtk_tree_row_reference_get_path (_tmp15_); path = _tmp16_; _tmp17_ = templates; _tmp18_ = path; templates_delete_personal_template (_tmp17_, _tmp18_); template_deleted = TRUE; _gtk_tree_path_free0 (path); + _gtk_tree_row_reference_free0 (row_ref); } } } - __g_list_free__gtk_tree_path_free0_0 (selected_items); + __g_list_free__gtk_tree_row_reference_free0_0 (row_refs); + __g_list_free__gtk_tree_path_free0_0 (selected_rows); _g_object_unref0 (select); } _tmp19_ = template_deleted; diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/latexila-3.16.0/src/templates_dialogs.vala new/latexila-3.16.1/src/templates_dialogs.vala --- old/latexila-3.16.0/src/templates_dialogs.vala 2015-03-18 13:48:13.000000000 +0100 +++ new/latexila-3.16.1/src/templates_dialogs.vala 2015-04-19 10:59:54.000000000 +0200 @@ -274,12 +274,18 @@ while (run () == ResponseType.ACCEPT) { TreeSelection select = templates_list.get_selection (); - List<TreePath> selected_items = select.get_selected_rows (null); - uint nb_selected_items = selected_items.length (); + unowned TreeModel model; + List<TreePath> selected_rows = select.get_selected_rows (out model); + List<TreeRowReference> row_refs = null; - for (int item_num = 0 ; item_num < nb_selected_items ; item_num++) + foreach (TreePath path in selected_rows) { - TreePath path = selected_items.nth_data (item_num); + row_refs.prepend (new TreeRowReference (model, path)); + } + + foreach (TreeRowReference row_ref in row_refs) + { + TreePath path = row_ref.get_path (); templates.delete_personal_template (path); template_deleted = true; }