Hello community, here is the log from the commit of package feh for openSUSE:Factory checked in at 2015-05-19 23:51:11 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Comparing /work/SRC/openSUSE:Factory/feh (Old) and /work/SRC/openSUSE:Factory/.feh.new (New) ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "feh" Changes: -------- --- /work/SRC/openSUSE:Factory/feh/feh.changes 2014-09-06 12:18:31.000000000 +0200 +++ /work/SRC/openSUSE:Factory/.feh.new/feh.changes 2015-05-19 23:51:13.000000000 +0200 @@ -1,0 +2,11 @@ +Tue May 12 14:24:32 UTC 2015 - sei...@b1-systems.de + +- update to 2.21.2 + * Handle missing HOME in environment + * Fix memory leak when a slideshow contains many unloadable images + * Fix memory leak when --prelaod removes files from the filelist +- added dependency because of missing image loader: +feh WARNING: example.jpg - No Imlib2 loader for that file format +- removed unneeded dependency giblib (unmaintained) + +------------------------------------------------------------------- Old: ---- feh-2.12.tar.bz2 feh-2.12.tar.bz2.asc New: ---- feh-2.12.1.tar.bz2 feh-2.12.1.tar.bz2.asc ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Other differences: ------------------ ++++++ feh.spec ++++++ --- /var/tmp/diff_new_pack.ucozk5/_old 2015-05-19 23:51:14.000000000 +0200 +++ /var/tmp/diff_new_pack.ucozk5/_new 2015-05-19 23:51:14.000000000 +0200 @@ -1,6 +1,8 @@ # vim: set sw=4 ts=4 et: # -# Copyright (c) 2012 SUSE LINUX Products GmbH, Nuernberg, Germany. +# spec file for package feh +# +# Copyright (c) 2015 SUSE LINUX GmbH, Nuernberg, Germany. # # All modifications and additions to the file contributed by third parties # remain the property of their copyright owners, unless otherwise agreed @@ -19,7 +21,7 @@ License: MIT and LGPL-2.0+ Group: Productivity/Graphics/Viewers Name: feh -Version: 2.12 +Version: 2.12.1 Release: 0 Source: http://feh.finalrewind.org/feh-%{version}.tar.bz2 Source1: %{name}.desktop @@ -39,12 +41,12 @@ BuildRoot: %{_tmppath}/%{name}-%{version}-build BuildRequires: curl-devel BuildRequires: freetype2-devel -BuildRequires: giblib-devel +BuildRequires: gpg-offline BuildRequires: imlib2-devel BuildRequires: libjpeg-devel BuildRequires: libpng-devel BuildRequires: xorg-x11-devel -BuildRequires: gpg-offline +Requires: imlib2-loaders %if 0%{?suse_version} BuildRequires: update-desktop-files %endif @@ -87,9 +89,6 @@ %suse_update_desktop_file -r feh Graphics Viewer %endif -%clean -%{?buildroot:%__rm -rf "%{buildroot}"} - %files %defattr(-, root, root) %doc AUTHORS ChangeLog README TODO ++++++ feh-2.12.tar.bz2 -> feh-2.12.1.tar.bz2 ++++++ diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/feh-2.12/ChangeLog new/feh-2.12.1/ChangeLog --- old/feh-2.12/ChangeLog 2014-05-15 23:43:07.000000000 +0200 +++ new/feh-2.12.1/ChangeLog 2015-04-08 11:21:11.000000000 +0200 @@ -1,6 +1,13 @@ +Wed, 08 Apr 2015 11:18:41 +0200 Daniel Friesel <derf+...@finalrewind.org> + +* Release v2.12.1 + * Handle missing HOME in environment + * Fix memory leak when a slideshow contains many unloadable images + * Fix memory leak when --prelaod removes files from the filelist + Thu, 15 May 2014 23:41:07 +0200 Daniel Friesel <derf+...@finalrewind.org> -* Releasev v2.12 +* Release v2.12 * feh-cam and gen-cam-menu are no longer installed by default. Use 'make install cam=1' to install them or 'make uninstall cam=1 && make install cam=0' to remove them permanently diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/feh-2.12/config.mk new/feh-2.12.1/config.mk --- old/feh-2.12/config.mk 2014-05-15 23:43:07.000000000 +0200 +++ new/feh-2.12.1/config.mk 2015-04-08 11:21:11.000000000 +0200 @@ -1,5 +1,5 @@ PACKAGE ?= feh -VERSION ?= 2.12 +VERSION ?= 2.12.1 # Prefix for all installed files PREFIX ?= /usr/local diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/feh-2.12/man/feh.pre new/feh-2.12.1/man/feh.pre --- old/feh-2.12/man/feh.pre 2014-05-15 23:43:07.000000000 +0200 +++ new/feh-2.12.1/man/feh.pre 2015-04-08 11:21:11.000000000 +0200 @@ -1143,7 +1143,7 @@ . .It n , Ao Space Ac , Ao Right Ac Bq next_img . -Show next image +Show next image. Selects the next image in thumbnail mode. . .It o Bq toggle_pointer . @@ -1151,7 +1151,7 @@ . .It p , Ao Backspace Ac , Ao Left Ac Bq prev_img . -Show previous image +Show previous image. Selects the previous image in thumbnail mode. . .It q , Ao Escape Ac Bq quit . @@ -1291,7 +1291,8 @@ . .It R, Ao keypad begin Ac Bq render . -Antialias the image +Antialias the image. +Opens the currently selected image in thumbnail mode. . .It Ao keypad + Ac , Ao Up Ac Bq zoom_in . diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/feh-2.12/src/events.c new/feh-2.12.1/src/events.c --- old/feh-2.12/src/events.c 2014-05-15 23:43:07.000000000 +0200 +++ new/feh-2.12.1/src/events.c 2015-04-08 11:21:11.000000000 +0200 @@ -110,15 +110,14 @@ feh_set_bb(&buttons.rotate, 4, 2); home = getenv("HOME"); - if (!home) - eprintf("No HOME in environment"); - confhome = getenv("XDG_CONFIG_HOME"); if (confhome) confpath = estrjoin("/", confhome, "feh/buttons", NULL); - else + else if (home) confpath = estrjoin("/", home, ".config/feh/buttons", NULL); + else + return; conf = fopen(confpath, "r"); diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/feh-2.12/src/filelist.c new/feh-2.12.1/src/filelist.c --- old/feh-2.12/src/filelist.c 2014-05-15 23:43:07.000000000 +0200 +++ new/feh-2.12.1/src/filelist.c 2015-04-08 11:21:11.000000000 +0200 @@ -332,8 +332,10 @@ feh_display_status(0); if (remove_list) { - for (l = remove_list; l; l = l->next) + for (l = remove_list; l; l = l->next) { + feh_file_free(FEH_FILE(((gib_list *) l->data)->data)); filelist = list = gib_list_remove(list, (gib_list *) l->data); + } gib_list_free(remove_list); } diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/feh-2.12/src/imlib.c new/feh-2.12.1/src/imlib.c --- old/feh-2.12/src/imlib.c 2014-05-15 23:43:07.000000000 +0200 +++ new/feh-2.12.1/src/imlib.c 2015-04-08 11:21:11.000000000 +0200 @@ -566,6 +566,8 @@ if (fmt[0] != '\0' && fmt[strlen(fmt) - 1] == ':') fprintf(stderr, " %s", strerror(errno)); fputs("\n", stderr); + if (!w) + free(errstr); } diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/feh-2.12/src/keyevents.c new/feh-2.12.1/src/keyevents.c --- old/feh-2.12/src/keyevents.c 2014-05-15 23:43:07.000000000 +0200 +++ new/feh-2.12.1/src/keyevents.c 2015-04-08 11:21:11.000000000 +0200 @@ -157,15 +157,14 @@ feh_set_kb(&keys.toggle_keep_vp, 0, XK_k, 0, 0, 0, 0); home = getenv("HOME"); - if (!home) - eprintf("No HOME in environment"); - confhome = getenv("XDG_CONFIG_HOME"); if (confhome) confpath = estrjoin("/", confhome, "feh/keys", NULL); - else + else if (home) confpath = estrjoin("/", home, ".config/feh/keys", NULL); + else + return; conf = fopen(confpath, "r"); diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/feh-2.12/src/options.c new/feh-2.12.1/src/options.c --- old/feh-2.12/src/options.c 2014-05-15 23:43:07.000000000 +0200 +++ new/feh-2.12.1/src/options.c 2015-04-08 11:21:11.000000000 +0200 @@ -132,15 +132,16 @@ int cont = 0; int bspos; - if (!home) - eprintf("You have no HOME, cannot read themes"); - - oldrcpath = estrjoin("/", home, ".fehrc", NULL); - if (confbase) rcpath = estrjoin("/", confbase, "feh/themes", NULL); - else + else if (home) rcpath = estrjoin("/", home, ".config/feh/themes", NULL); + else { + weprintf("You have no HOME, cannot read configuration"); + return; + } + + oldrcpath = estrjoin("/", home, ".fehrc", NULL); fp = fopen(rcpath, "r"); diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/feh-2.12/src/thumbnail.h new/feh-2.12.1/src/thumbnail.h --- old/feh-2.12/src/thumbnail.h 2014-05-15 23:43:07.000000000 +0200 +++ new/feh-2.12.1/src/thumbnail.h 2015-04-08 11:21:11.000000000 +0200 @@ -44,8 +44,6 @@ } feh_thumbnail; typedef struct thumbmode_data { - /* FIXME: text_area_h not really needed, remove? */ - Imlib_Image im_main; /* base image which all thumbnails are rendered on */ Imlib_Image im_bg; /* background for the thumbnails */ @@ -58,7 +56,7 @@ int text_area_w, text_area_h; /* space needed for thumbnail description */ int max_column_w; /* FIXME: description */ - int vertical; /* FIXME: vertical in what way? */ + int vertical; /* == !opt.limit_w && opt.limit_h */ int cache_thumbnails; /* use cached thumbnails from ~/.thumbnails */ int cache_dim; /* 128 = 128x128 ("normal"), 256 = 256x256 ("large") */ diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/feh-2.12/src/wallpaper.c new/feh-2.12.1/src/wallpaper.c --- old/feh-2.12/src/wallpaper.c 2014-05-15 23:43:07.000000000 +0200 +++ new/feh-2.12.1/src/wallpaper.c 2015-04-08 11:21:11.000000000 +0200 @@ -228,9 +228,19 @@ char bgfil[4096]; char sendbuf[4096]; + /* + * TODO this re-implements mkstemp (badly). However, it is only needed + * for non-file images and enlightenment. Might be easier to just remove + * it. + */ + snprintf(bgname, sizeof(bgname), "FEHBG_%d", num); if (!fil && im) { + if (getenv("HOME") == NULL) { + weprintf("Cannot save wallpaper to temporary file: You have no HOME"); + return; + } snprintf(bgfil, sizeof(bgfil), "%s/.%s.png", getenv("HOME"), bgname); imlib_context_set_image(im); imlib_image_set_format("png"); Files old/feh-2.12/test/scr/caption_done and new/feh-2.12.1/test/scr/caption_done differ Files old/feh-2.12/test/scr/caption_none and new/feh-2.12.1/test/scr/caption_none differ Files old/feh-2.12/test/scr/draw_action and new/feh-2.12.1/test/scr/draw_action differ Files old/feh-2.12/test/scr/draw_action_tinted and new/feh-2.12.1/test/scr/draw_action_tinted differ Files old/feh-2.12/test/scr/draw_all_multi and new/feh-2.12.1/test/scr/draw_all_multi differ Files old/feh-2.12/test/scr/draw_all_one and new/feh-2.12.1/test/scr/draw_all_one differ Files old/feh-2.12/test/scr/draw_filename and new/feh-2.12.1/test/scr/draw_filename differ Files old/feh-2.12/test/scr/draw_filename_action and new/feh-2.12.1/test/scr/draw_filename_action differ Files old/feh-2.12/test/scr/draw_filename_action_tinted and new/feh-2.12.1/test/scr/draw_filename_action_tinted differ Files old/feh-2.12/test/scr/draw_filename_tinted and new/feh-2.12.1/test/scr/draw_filename_tinted differ Files old/feh-2.12/test/scr/draw_info and new/feh-2.12.1/test/scr/draw_info differ Files old/feh-2.12/test/scr/draw_info_tinted and new/feh-2.12.1/test/scr/draw_info_tinted differ Files old/feh-2.12/test/scr/draw_nothing and new/feh-2.12.1/test/scr/draw_nothing differ Files old/feh-2.12/test/scr/feh_full_lwi and new/feh-2.12.1/test/scr/feh_full_lwi differ Files old/feh-2.12/test/scr/feh_lhi and new/feh-2.12.1/test/scr/feh_lhi differ Files old/feh-2.12/test/scr/feh_lhi_i and new/feh-2.12.1/test/scr/feh_lhi_i differ Files old/feh-2.12/test/scr/feh_lhi_ii and new/feh-2.12.1/test/scr/feh_lhi_ii differ Files old/feh-2.12/test/scr/feh_lhi_iir and new/feh-2.12.1/test/scr/feh_lhi_iir differ Files old/feh-2.12/test/scr/feh_lhi_iirr and new/feh-2.12.1/test/scr/feh_lhi_iirr differ Files old/feh-2.12/test/scr/feh_lhi_iirri and new/feh-2.12.1/test/scr/feh_lhi_iirri differ Files old/feh-2.12/test/scr/feh_lhi_iirrio and new/feh-2.12.1/test/scr/feh_lhi_iirrio differ Files old/feh-2.12/test/scr/feh_lhi_o and new/feh-2.12.1/test/scr/feh_lhi_o differ Files old/feh-2.12/test/scr/feh_lhi_oo and new/feh-2.12.1/test/scr/feh_lhi_oo differ Files old/feh-2.12/test/scr/feh_lhi_ooo and new/feh-2.12.1/test/scr/feh_lhi_ooo differ Files old/feh-2.12/test/scr/feh_lwi and new/feh-2.12.1/test/scr/feh_lwi differ Files old/feh-2.12/test/scr/feh_lwi_scroll_r and new/feh-2.12.1/test/scr/feh_lwi_scroll_r differ Files old/feh-2.12/test/scr/feh_lwi_scroll_rd and new/feh-2.12.1/test/scr/feh_lwi_scroll_rd differ Files old/feh-2.12/test/scr/feh_lwi_scroll_rdr and new/feh-2.12.1/test/scr/feh_lwi_scroll_rdr differ Files old/feh-2.12/test/scr/feh_lwi_scroll_rdru and new/feh-2.12.1/test/scr/feh_lwi_scroll_rdru differ Files old/feh-2.12/test/scr/feh_lwi_scroll_rdrul and new/feh-2.12.1/test/scr/feh_lwi_scroll_rdrul differ Files old/feh-2.12/test/scr/feh_scaledown_lwi and new/feh-2.12.1/test/scr/feh_scaledown_lwi differ Files old/feh-2.12/test/scr/geometry_offset_only and new/feh-2.12.1/test/scr/geometry_offset_only differ Files old/feh-2.12/test/scr/index_full_h400 and new/feh-2.12.1/test/scr/index_full_h400 differ Files old/feh-2.12/test/scr/index_full_w400 and new/feh-2.12.1/test/scr/index_full_w400 differ Files old/feh-2.12/test/scr/index_h400 and new/feh-2.12.1/test/scr/index_h400 differ Files old/feh-2.12/test/scr/index_w400 and new/feh-2.12.1/test/scr/index_w400 differ Files old/feh-2.12/test/scr/thumbnail_default and new/feh-2.12.1/test/scr/thumbnail_default differ
