Hello community, here is the log from the commit of package yast2-packager for openSUSE:Factory checked in at 2015-07-05 17:52:06 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Comparing /work/SRC/openSUSE:Factory/yast2-packager (Old) and /work/SRC/openSUSE:Factory/.yast2-packager.new (New) ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "yast2-packager" Changes: -------- --- /work/SRC/openSUSE:Factory/yast2-packager/yast2-packager.changes 2015-06-18 06:36:07.000000000 +0200 +++ /work/SRC/openSUSE:Factory/.yast2-packager.new/yast2-packager.changes 2015-07-05 17:52:07.000000000 +0200 @@ -1,0 +2,19 @@ +Tue Jun 30 14:16:41 UTC 2015 - mvid...@suse.com + +- Do not offer to install recommended packages for already + installed ones on the first run (boo#902394). +- 3.1.74 + +------------------------------------------------------------------- +Tue Jun 30 09:11:43 CEST 2015 - sch...@suse.de + +- Checking nil result after reading /proc/cmdline (bnc#934229). +- 3.1.73 + +------------------------------------------------------------------- +Wed Jun 24 11:49:42 UTC 2015 - jreidin...@suse.com + +- do not crash if user want to add add-on via url (bnc#934216) +- 3.1.72 + +------------------------------------------------------------------- Old: ---- yast2-packager-3.1.71.tar.bz2 New: ---- yast2-packager-3.1.74.tar.bz2 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Other differences: ------------------ ++++++ yast2-packager.spec ++++++ --- /var/tmp/diff_new_pack.eDOF2f/_old 2015-07-05 17:52:08.000000000 +0200 +++ /var/tmp/diff_new_pack.eDOF2f/_new 2015-07-05 17:52:08.000000000 +0200 @@ -17,7 +17,7 @@ Name: yast2-packager -Version: 3.1.71 +Version: 3.1.74 Release: 0 BuildRoot: %{_tmppath}/%{name}-%{version}-build ++++++ yast2-packager-3.1.71.tar.bz2 -> yast2-packager-3.1.74.tar.bz2 ++++++ diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/yast2-packager-3.1.71/.yardopts new/yast2-packager-3.1.74/.yardopts --- old/yast2-packager-3.1.71/.yardopts 1970-01-01 01:00:00.000000000 +0100 +++ new/yast2-packager-3.1.74/.yardopts 2015-07-01 13:03:37.000000000 +0200 @@ -0,0 +1,6 @@ +--no-private +--markup markdown +--protected +src/**/*.rb +--readme README.md +--output-dir ./doc/autodocs diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/yast2-packager-3.1.71/package/yast2-packager.changes new/yast2-packager-3.1.74/package/yast2-packager.changes --- old/yast2-packager-3.1.71/package/yast2-packager.changes 2015-06-11 17:48:07.000000000 +0200 +++ new/yast2-packager-3.1.74/package/yast2-packager.changes 2015-07-01 13:03:37.000000000 +0200 @@ -1,4 +1,23 @@ ------------------------------------------------------------------- +Tue Jun 30 14:16:41 UTC 2015 - mvid...@suse.com + +- Do not offer to install recommended packages for already + installed ones on the first run (boo#902394). +- 3.1.74 + +------------------------------------------------------------------- +Tue Jun 30 09:11:43 CEST 2015 - sch...@suse.de + +- Checking nil result after reading /proc/cmdline (bnc#934229). +- 3.1.73 + +------------------------------------------------------------------- +Wed Jun 24 11:49:42 UTC 2015 - jreidin...@suse.com + +- do not crash if user want to add add-on via url (bnc#934216) +- 3.1.72 + +------------------------------------------------------------------- Thu Jun 11 14:58:58 UTC 2015 - lsle...@suse.cz - proper fix for a float remaining time (bnc#882240) diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/yast2-packager-3.1.71/package/yast2-packager.spec new/yast2-packager-3.1.74/package/yast2-packager.spec --- old/yast2-packager-3.1.71/package/yast2-packager.spec 2015-06-11 17:48:07.000000000 +0200 +++ new/yast2-packager-3.1.74/package/yast2-packager.spec 2015-07-01 13:03:37.000000000 +0200 @@ -17,7 +17,7 @@ Name: yast2-packager -Version: 3.1.71 +Version: 3.1.74 Release: 0 BuildRoot: %{_tmppath}/%{name}-%{version}-build diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/yast2-packager-3.1.71/src/clients/sw_single.rb new/yast2-packager-3.1.74/src/clients/sw_single.rb --- old/yast2-packager-3.1.71/src/clients/sw_single.rb 2015-06-11 17:48:07.000000000 +0200 +++ new/yast2-packager-3.1.74/src/clients/sw_single.rb 2015-07-01 13:03:37.000000000 +0200 @@ -594,11 +594,6 @@ opts = GetPackagerOptions() Builtins.y2milestone("Using packager widget options: %1", opts) - home = ENV["home"] || "/root" - # unset the ignoreAlreadyRecommended flag on the very first run, - # otherwise keep the value from the config file - Pkg.SetSolverFlags({ "ignoreAlreadyRecommended" => false }) unless File.exist?(File.join(home, ".config", "YaST2", "YQPackageSelector.conf")) - result = PackagesUI.RunPackageSelector(opts) # No: ask user via package selection widget Builtins.y2milestone("Package selector retured: %1", result) if result == :accept diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/yast2-packager-3.1.71/src/modules/Packages.rb new/yast2-packager-3.1.74/src/modules/Packages.rb --- old/yast2-packager-3.1.71/src/modules/Packages.rb 2015-06-11 17:48:07.000000000 +0200 +++ new/yast2-packager-3.1.74/src/modules/Packages.rb 2015-07-01 13:03:37.000000000 +0200 @@ -976,7 +976,7 @@ add_biosdevname = false options = SCR.Read(path(".proc.cmdline")) - option = options.grep(/^biosdevname=/i).first + option = options.grep(/^biosdevname=/i).first if options if option value = option[/^biosdevname=(\d+)/i, 1] else #missing biosdevname option diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/yast2-packager-3.1.71/src/modules/SourceDialogs.rb new/yast2-packager-3.1.74/src/modules/SourceDialogs.rb --- old/yast2-packager-3.1.71/src/modules/SourceDialogs.rb 2015-06-11 17:48:07.000000000 +0200 +++ new/yast2-packager-3.1.74/src/modules/SourceDialogs.rb 2015-07-01 13:03:37.000000000 +0200 @@ -352,6 +352,8 @@ # @return [Boolean] true if URL is an ISO URL, false otherwise def IsISOURL(url) uri = URI(url) + return false if uri.scheme.nil? # empty or generic uri have nil scheme causing exception below (bnc#934216) + params = URI.decode_www_form(uri.query || "").to_h uri.scheme.downcase == "iso" && params.has_key?("url") diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/yast2-packager-3.1.71/test/packages_test.rb new/yast2-packager-3.1.74/test/packages_test.rb --- old/yast2-packager-3.1.71/test/packages_test.rb 2015-06-11 17:48:07.000000000 +0200 +++ new/yast2-packager-3.1.74/test/packages_test.rb 2015-07-01 13:03:37.000000000 +0200 @@ -15,6 +15,7 @@ SCR_STRING_PATH = Yast::Path.new(".target.string") SCR_BASH_PATH = Yast::Path.new(".target.bash") +SCR_PROC_CMDLINE_PATH = Yast::Path.new(".proc.cmdline") CHECK_FOR_DELL_SYSTEM = Regexp.new( 'hwinfo .*bios .*grep .*vendor:.*dell inc', @@ -73,6 +74,13 @@ end end + context "when no /proc/cmdline is defined" do + it "returns empty list" do + Yast::SCR.stub(:Read).with(SCR_PROC_CMDLINE_PATH).and_return(nil) + expect(Yast::Packages.kernelCmdLinePackages).to eq([]) + end + end + context "when biosdevname behavior not defined on the Kernel command line" do before { set_root_path("cmdline-biosdevname_nil") } diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/yast2-packager-3.1.71/test/source_dialogs_test.rb new/yast2-packager-3.1.74/test/source_dialogs_test.rb --- old/yast2-packager-3.1.71/test/source_dialogs_test.rb 2015-06-11 17:48:07.000000000 +0200 +++ new/yast2-packager-3.1.74/test/source_dialogs_test.rb 2015-07-01 13:03:37.000000000 +0200 @@ -66,4 +66,18 @@ expect(subject.PostprocessISOURL(converted)).to eq(url) end end + + describe ".URLScheme" do + it "returns scheme of url" do + expect(subject.URLScheme("ftp://test.com")).to eq "ftp" + end + + it "return \"url\" if parameter is empty string" do + expect(subject.URLScheme("")).to eq "url" + end + + it "return \"url\" if parameter is invalid url string" do + expect(subject.URLScheme("test")).to eq "url" + end + end end diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/yast2-packager-3.1.71/test/test_helper.rb new/yast2-packager-3.1.74/test/test_helper.rb --- old/yast2-packager-3.1.71/test/test_helper.rb 2015-06-11 17:48:07.000000000 +0200 +++ new/yast2-packager-3.1.74/test/test_helper.rb 2015-07-01 13:03:37.000000000 +0200 @@ -1,4 +1,6 @@ -ENV["Y2DIR"] = File.expand_path("../../src", __FILE__) +srcdir = File.expand_path("../../src", __FILE__) +y2dirs = ENV.fetch("Y2DIR", "").split(":") +ENV["Y2DIR"] = y2dirs.unshift(srcdir).join(":") if ENV["COVERAGE"] require "simplecov"