Hello community, here is the log from the commit of package yast2-network for openSUSE:Factory checked in at 2015-08-21 12:41:53 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Comparing /work/SRC/openSUSE:Factory/yast2-network (Old) and /work/SRC/openSUSE:Factory/.yast2-network.new (New) ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "yast2-network" Changes: -------- --- /work/SRC/openSUSE:Factory/yast2-network/yast2-network.changes 2015-08-11 08:25:48.000000000 +0200 +++ /work/SRC/openSUSE:Factory/.yast2-network.new/yast2-network.changes 2015-08-21 12:41:54.000000000 +0200 @@ -1,0 +2,14 @@ +Tue Aug 18 12:29:56 UTC 2015 - [email protected] + +- bnc#940892 + - fixed internal error when importing AY profile +- 3.1.127 + +------------------------------------------------------------------- +Tue Aug 18 09:35:05 UTC 2015 - [email protected] + +- bsc#941948 + - lan_auto client returns value properly +- 3.1.126 + +------------------------------------------------------------------- Old: ---- yast2-network-3.1.125.tar.bz2 New: ---- yast2-network-3.1.127.tar.bz2 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Other differences: ------------------ ++++++ yast2-network.spec ++++++ --- /var/tmp/diff_new_pack.M8xscA/_old 2015-08-21 12:41:55.000000000 +0200 +++ /var/tmp/diff_new_pack.M8xscA/_new 2015-08-21 12:41:55.000000000 +0200 @@ -17,7 +17,7 @@ Name: yast2-network -Version: 3.1.125 +Version: 3.1.127 Release: 0 BuildRoot: %{_tmppath}/%{name}-%{version}-build ++++++ yast2-network-3.1.125.tar.bz2 -> yast2-network-3.1.127.tar.bz2 ++++++ diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/yast2-network-3.1.125/package/yast2-network.changes new/yast2-network-3.1.127/package/yast2-network.changes --- old/yast2-network-3.1.125/package/yast2-network.changes 2015-08-10 10:52:10.000000000 +0200 +++ new/yast2-network-3.1.127/package/yast2-network.changes 2015-08-18 15:27:08.000000000 +0200 @@ -1,4 +1,18 @@ ------------------------------------------------------------------- +Tue Aug 18 12:29:56 UTC 2015 - [email protected] + +- bnc#940892 + - fixed internal error when importing AY profile +- 3.1.127 + +------------------------------------------------------------------- +Tue Aug 18 09:35:05 UTC 2015 - [email protected] + +- bsc#941948 + - lan_auto client returns value properly +- 3.1.126 + +------------------------------------------------------------------- Mon Aug 10 08:15:39 UTC 2015 - [email protected] - bnc#916013 diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/yast2-network-3.1.125/package/yast2-network.spec new/yast2-network-3.1.127/package/yast2-network.spec --- old/yast2-network-3.1.125/package/yast2-network.spec 2015-08-10 10:52:10.000000000 +0200 +++ new/yast2-network-3.1.127/package/yast2-network.spec 2015-08-18 15:27:08.000000000 +0200 @@ -17,7 +17,7 @@ Name: yast2-network -Version: 3.1.125 +Version: 3.1.127 Release: 0 BuildRoot: %{_tmppath}/%{name}-%{version}-build diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/yast2-network-3.1.125/src/clients/lan_auto.rb new/yast2-network-3.1.127/src/clients/lan_auto.rb --- old/yast2-network-3.1.125/src/clients/lan_auto.rb 2015-08-10 10:52:10.000000000 +0200 +++ new/yast2-network-3.1.127/src/clients/lan_auto.rb 2015-08-18 15:27:08.000000000 +0200 @@ -149,6 +149,7 @@ Builtins.y2milestone("Lan auto finished (#{@ret})") Builtins.y2milestone("----------------------------------------") + @ret end # If there's key in m, upcase key and assign the value to ret diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/yast2-network-3.1.125/src/modules/LanUdevAuto.rb new/yast2-network-3.1.127/src/modules/LanUdevAuto.rb --- old/yast2-network-3.1.125/src/modules/LanUdevAuto.rb 2015-08-10 10:52:10.000000000 +0200 +++ new/yast2-network-3.1.127/src/modules/LanUdevAuto.rb 2015-08-18 15:27:08.000000000 +0200 @@ -180,7 +180,7 @@ createUdevFromIfaceName(Ops.get_list(settings, "interfaces", [])) ) else - @udev_rules = Ops.get_list(settings, "net-udev", []) + @udev_rules = settings["net-udev"] || [] end # if (Arch::s390()) @s390_devices = Ops.get_list(settings, "s390-devices", []) diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/yast2-network-3.1.125/test/lan_auto_test.rb new/yast2-network-3.1.127/test/lan_auto_test.rb --- old/yast2-network-3.1.125/test/lan_auto_test.rb 1970-01-01 01:00:00.000000000 +0100 +++ new/yast2-network-3.1.127/test/lan_auto_test.rb 2015-08-18 15:27:08.000000000 +0200 @@ -0,0 +1,29 @@ +#!/usr/bin/env rspec + +require_relative "test_helper" + +require "yast" +require_relative "../src/clients/lan_auto" + +describe Yast::LanAutoClient do + describe "#main" do + before do + allow(Yast::WFM).to receive(:Args).with(no_args).and_return([func]) + allow(Yast::WFM).to receive(:Args).with(0).and_return(func) + end + + context "when func is GetModified" do + let(:func) { "GetModified" } + + it "returns true if LanItems.GetModified is true" do + expect(Yast::LanItems).to receive(:GetModified).and_return(true) + expect(subject.main).to eq(true) + end + + it "returns false if LanItems.GetModified is false" do + expect(Yast::LanItems).to receive(:GetModified).and_return(false) + expect(subject.main).to eq(false) + end + end + end +end diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/yast2-network-3.1.125/test/lan_udev_auto_test.rb new/yast2-network-3.1.127/test/lan_udev_auto_test.rb --- old/yast2-network-3.1.125/test/lan_udev_auto_test.rb 2015-08-10 10:52:10.000000000 +0200 +++ new/yast2-network-3.1.127/test/lan_udev_auto_test.rb 2015-08-18 15:27:08.000000000 +0200 @@ -73,23 +73,23 @@ end describe "LanUdevAuto#Write" do - ATTR = "ATTR{address}" - VALUE = "aa:BB:cc:DD:ee:FF" - NAME = "custom-name" + let(:attr_addr) { "ATTR{address}" } + let(:value) { "aa:BB:cc:DD:ee:FF" } + let(:name) { "custom-name" } it "writes MAC in lowercase" do udev_rules = [ { - "rule" => ATTR, - "value" => VALUE, - "name" => NAME + "rule" => attr_addr, + "value" => value, + "name" => name } ] ay_rules = [ format( "SUBSYSTEM==\"net\", ACTION==\"add\", DRIVERS==\"?*\", %s==\"%s\", NAME=\"%s\"", - ATTR, VALUE.downcase, NAME + attr_addr, value.downcase, name ) ] @@ -108,3 +108,26 @@ Yast::LanUdevAuto.Write end end + +describe "LanUdevAuto#Import" do + let(:attr_addr) { "ATTR{address}" } + let(:value) { "aa:BB:cc:DD:ee:FF" } + let(:name) { "custom-name" } + + it "doesn't crash when importing udev rule" do + udev_rules = [ + { + "rule" => attr_addr, + "value" => value, + "name" => name + } + ] + + expect(Yast::LanUdevAuto.Import("net-udev" => udev_rules)) + .to be true + end + + it "doesn't crash when no udev rule is defined in data for importing" do + expect(Yast::LanUdevAuto.Import({})).to be true + end +end
