Hello community, here is the log from the commit of package ansible for openSUSE:Factory checked in at 2015-10-25 19:13:26 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Comparing /work/SRC/openSUSE:Factory/ansible (Old) and /work/SRC/openSUSE:Factory/.ansible.new (New) ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "ansible" Changes: -------- --- /work/SRC/openSUSE:Factory/ansible/ansible.changes 2015-10-20 00:08:53.000000000 +0200 +++ /work/SRC/openSUSE:Factory/.ansible.new/ansible.changes 2015-10-25 19:13:29.000000000 +0100 @@ -24,0 +25,6 @@ +Sat Sep 26 14:01:30 UTC 2015 - [email protected] + +- Added fix_zypper_errorhandling.patch as it`s have not been accepted + upstream, in lack of an reviewer. See patch for more comments + +------------------------------------------------------------------- New: ---- fix_zypper_errorhandling.patch ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Other differences: ------------------ ++++++ ansible.spec ++++++ --- /var/tmp/diff_new_pack.YGXZqk/_old 2015-10-25 19:13:30.000000000 +0100 +++ /var/tmp/diff_new_pack.YGXZqk/_new 2015-10-25 19:13:30.000000000 +0100 @@ -27,6 +27,8 @@ Url: http://ansible.com/ Source: https://pypi.python.org/packages/source/a/ansible/ansible-%{version}.tar.gz Source99: ansible-rpmlintrc +Patch0: fix_zypper_errorhandling.patch + %if 0%{?suse_version} %if 0%{?suse_version} >= 01130 BuildRequires: python-paramiko @@ -78,6 +80,7 @@ %prep %setup -q -n ansible-%{version} +%patch0 -p1 %build python setup.py build ++++++ fix_zypper_errorhandling.patch ++++++ diff --git a/lib/ansible/modules/extras/packaging/os/zypper.py b/lib/ansible/modules/extras/packaging/os/zypper.py index 196a7e2..7f63482 100644 --- a/lib/ansible/modules/extras/packaging/os/zypper.py +++ b/lib/ansible/modules/extras/packaging/os/zypper.py @@ -192,6 +192,11 @@ def package_latest(m, name, installed_state, disable_gpg_check, disable_recommen cmd.extend(name) rc, stdout, stderr = m.run_command(cmd, check_rc=False) + # return if an error occured while installation + # otherwise error messages will be lost and user doesn`t see any error + if rc: + return (rc, stdout, stderr, changed) + # if we've already made a change, we don't have to check whether a version changed if not changed: post_upgrade_versions = get_current_version(m, name)
