Hello community, here is the log from the commit of package libcroco for openSUSE:Factory checked in at 2015-12-18 21:50:39 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Comparing /work/SRC/openSUSE:Factory/libcroco (Old) and /work/SRC/openSUSE:Factory/.libcroco.new (New) ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "libcroco" Changes: -------- --- /work/SRC/openSUSE:Factory/libcroco/libcroco.changes 2015-11-06 00:09:56.000000000 +0100 +++ /work/SRC/openSUSE:Factory/.libcroco.new/libcroco.changes 2015-12-18 21:50:41.000000000 +0100 @@ -1,0 +2,6 @@ +Sun Dec 13 19:08:40 UTC 2015 - [email protected] + +- Update to version 0.6.10: + + Misc bug fixes. + +------------------------------------------------------------------- Old: ---- libcroco-0.6.9.tar.xz New: ---- libcroco-0.6.10.tar.xz ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Other differences: ------------------ ++++++ libcroco.spec ++++++ --- /var/tmp/diff_new_pack.E3ndfv/_old 2015-12-18 21:50:42.000000000 +0100 +++ /var/tmp/diff_new_pack.E3ndfv/_new 2015-12-18 21:50:42.000000000 +0100 @@ -17,7 +17,7 @@ Name: libcroco -Version: 0.6.9 +Version: 0.6.10 Release: 0 Summary: CSS2 Parser Library License: LGPL-2.1 ++++++ libcroco-0.6.9.tar.xz -> libcroco-0.6.10.tar.xz ++++++ diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/libcroco-0.6.9/ChangeLog new/libcroco-0.6.10/ChangeLog --- old/libcroco-0.6.9/ChangeLog 2015-10-31 11:56:39.000000000 +0100 +++ new/libcroco-0.6.10/ChangeLog 2015-12-13 19:25:16.000000000 +0100 @@ -1,3 +1,165 @@ +commit 956078a3cf703b3de5117659a50fae1bc00e8c20 +Author: Руслан Ижбулатов <[email protected]> +Date: Sat Oct 31 22:47:43 2015 +0000 + + Fix unused status variable in main() + + https://bugzilla.gnome.org/show_bug.cgi?id=710076 + + csslint/csslint.c | 2 +- + 1 file changed, 1 insertion(+), 1 deletion(-) + +commit f09307d1d467e0c25bd6f00bd689fdd5b858a360 +Author: Руслан Ижбулатов <[email protected]> +Date: Sat Oct 31 22:45:46 2015 +0000 + + Fix unused status variable in evaluate_selectors() + + * Add an end label to go to on error + * Clean up xml_doc at the end + * Fix a miscleaning of xpath_object + * Unref sheets after they are given to a cascade + * Return status at the end + + https://bugzilla.gnome.org/show_bug.cgi?id=710076 + + csslint/csslint.c | 40 ++++++++++++++++++++++++++++++++-------- + 1 file changed, 32 insertions(+), 8 deletions(-) + +commit d03fa2148fe0af4ebd96f1fa74772054197aaa02 +Author: Руслан Ижбулатов <[email protected]> +Date: Sat Oct 31 22:45:09 2015 +0000 + + Fix unused status variable in set_prop_position_from_value() + + * Return status + + https://bugzilla.gnome.org/show_bug.cgi?id=710076 + + src/cr-style.c | 2 +- + 1 file changed, 1 insertion(+), 1 deletion(-) + +commit 6bb010a2d6ca81f2c86b2e6990c44a844819b8f8 +Author: Руслан Ижбулатов <[email protected]> +Date: Sat Oct 31 22:44:07 2015 +0000 + + Fix unused status variable in cr_utils_utf8_to_ucs1() + + * Don't set status to CR_OK, it's initialized to that value + * Return status + + https://bugzilla.gnome.org/show_bug.cgi?id=710076 + + src/cr-utils.c | 4 +--- + 1 file changed, 1 insertion(+), 3 deletions(-) + +commit ac8029a5fe0bf9df81ea6965ac056aa81fa4885d +Author: Руслан Ижбулатов <[email protected]> +Date: Sat Oct 31 22:42:18 2015 +0000 + + Fix unused status variable in cr_utils_ucs1_to_utf8() + + * Return status instead (initialized to CR_OK) instead of an explicit CR_OK + * Remove redundant check for *a_in_len < 1 (equivalent to *a_in_len == 0) + and remove now-unused end label + + https://bugzilla.gnome.org/show_bug.cgi?id=710076 + + src/cr-utils.c | 10 ++-------- + 1 file changed, 2 insertions(+), 8 deletions(-) + +commit bc9b2c339e1181f8c69a2f74a93876932e352d6d +Author: Руслан Ижбулатов <[email protected]> +Date: Tue Aug 5 08:30:59 2014 +0000 + + Fix cr_tknzr_consume_chars() to set *a_nb_char before returning + + https://bugzilla.gnome.org/show_bug.cgi?id=710076 + + src/cr-tknzr.c | 8 ++++++-- + 1 file changed, 6 insertions(+), 2 deletions(-) + +commit 5fd302372e568810ff6eda6a6babbe04543a2116 +Author: Руслан Ижбулатов <[email protected]> +Date: Tue Aug 5 08:28:07 2014 +0000 + + Fix cr_input_consume_white_spaces to behave as documented + + https://bugzilla.gnome.org/show_bug.cgi?id=710076 + + src/cr-input.c | 2 ++ + 1 file changed, 2 insertions(+) + +commit 0ab22e823daa1b5a3fbaa0552874cfe33bbf15f5 +Author: Руслан Ижбулатов <[email protected]> +Date: Tue Aug 5 08:22:06 2014 +0000 + + Fix improper use of g_ascii_strup() + + https://bugzilla.gnome.org/show_bug.cgi?id=710076 + + src/cr-enc-handler.c | 3 +-- + 1 file changed, 1 insertion(+), 2 deletions(-) + +commit 3f94a4f5902e5e342ed77de6739934d49e97f937 +Author: Руслан Ижбулатов <[email protected]> +Date: Tue Aug 5 08:20:57 2014 +0000 + + Derive pointer to have appropriate type + + https://bugzilla.gnome.org/show_bug.cgi?id=710076 + + src/cr-enc-handler.c | 3 +-- + 1 file changed, 1 insertion(+), 2 deletions(-) + +commit e1facb1e7e8a0568774a1630c1a8621679635ef5 +Author: Markus Engel <[email protected]> +Date: Mon Mar 24 20:29:00 2014 +0000 + + Fix typos + + https://bugzilla.gnome.org/show_bug.cgi?id=726993 + + src/cr-style.c | 2 +- + src/cr-tknzr.c | 2 +- + 2 files changed, 2 insertions(+), 2 deletions(-) + +commit 15a8885758a5e6b4d7d03d7cacd89a212bbf9847 +Author: Boris Egorov <[email protected]> +Date: Thu Mar 19 23:42:34 2015 +0600 + + Fix typo in logical condition + + TYPE_SELECTOR equals to 2, so condition + (cur_sel->type_mask | TYPE_SELECTOR) will always be true. We should + increase c only if we encounter a selector. + + Issue detected by Cppcheck and MSVS (see + https://bugzilla.gnome.org/show_bug.cgi?id=507484) + + Signed-off-by: Boris Egorov <[email protected]> + + src/cr-simple-sel.c | 2 +- + 1 file changed, 1 insertion(+), 1 deletion(-) + +commit b6fe636277bff9f21b6e3f2c640a17114f9e723f +Author: Ignacio Casal Quinteiro <[email protected]> +Date: Sat Oct 31 12:01:52 2015 +0100 + + Post release version bump + + configure.ac | 2 +- + 1 file changed, 1 insertion(+), 1 deletion(-) + +commit 464576a12964ab23278caf91c404b560a074bc40 +Author: Ignacio Casal Quinteiro <[email protected]> +Date: Sat Oct 31 11:57:00 2015 +0100 + + Release 0.6.9 + + NEWS | 2 +- + 1 file changed, 1 insertion(+), 1 deletion(-) + commit 10cb6cfadb79cc7fc08f5ea8a7412bc34c34c250 Author: Ignacio Casal Quinteiro <[email protected]> Date: Sat Oct 31 11:43:20 2015 +0100 diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/libcroco-0.6.9/NEWS new/libcroco-0.6.10/NEWS --- old/libcroco-0.6.9/NEWS 2015-10-31 11:56:09.000000000 +0100 +++ new/libcroco-0.6.10/NEWS 2015-12-13 19:24:51.000000000 +0100 @@ -1,3 +1,6 @@ +0.6.10 + * Misc bug fixes + 0.6.9 * Added Visual Studio projects (Chun-wei Fan) * Lots of warnings fixed (Руслан Ижбулатов) diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/libcroco-0.6.9/configure new/libcroco-0.6.10/configure --- old/libcroco-0.6.9/configure 2015-10-31 11:56:29.000000000 +0100 +++ new/libcroco-0.6.10/configure 2015-12-13 19:24:29.000000000 +0100 @@ -1,6 +1,6 @@ #! /bin/sh # Guess values for system-dependent variables and create Makefiles. -# Generated by GNU Autoconf 2.69 for libcroco 0.6.9. +# Generated by GNU Autoconf 2.69 for libcroco 0.6.10. # # Report bugs to <http://bugzilla.gnome.org/enter_bug.cgi?product=libcroco>. # @@ -591,8 +591,8 @@ # Identity of this package. PACKAGE_NAME='libcroco' PACKAGE_TARNAME='libcroco' -PACKAGE_VERSION='0.6.9' -PACKAGE_STRING='libcroco 0.6.9' +PACKAGE_VERSION='0.6.10' +PACKAGE_STRING='libcroco 0.6.10' PACKAGE_BUGREPORT='http://bugzilla.gnome.org/enter_bug.cgi?product=libcroco' PACKAGE_URL='' @@ -1368,7 +1368,7 @@ # Omit some internal or obsolete options to make the list less imposing. # This message is too long to be a string in the A/UX 3.1 sh. cat <<_ACEOF -\`configure' configures libcroco 0.6.9 to adapt to many kinds of systems. +\`configure' configures libcroco 0.6.10 to adapt to many kinds of systems. Usage: $0 [OPTION]... [VAR=VALUE]... @@ -1438,7 +1438,7 @@ if test -n "$ac_init_help"; then case $ac_init_help in - short | recursive ) echo "Configuration of libcroco 0.6.9:";; + short | recursive ) echo "Configuration of libcroco 0.6.10:";; esac cat <<\_ACEOF @@ -1569,7 +1569,7 @@ test -n "$ac_init_help" && exit $ac_status if $ac_init_version; then cat <<\_ACEOF -libcroco configure 0.6.9 +libcroco configure 0.6.10 generated by GNU Autoconf 2.69 Copyright (C) 2012 Free Software Foundation, Inc. @@ -1847,7 +1847,7 @@ This file contains any messages produced by compilers while running configure, to aid debugging if configure makes a mistake. -It was created by libcroco $as_me 0.6.9, which was +It was created by libcroco $as_me 0.6.10, which was generated by GNU Autoconf 2.69. Invocation command line was $ $0 $@ @@ -2784,7 +2784,7 @@ # Define the identity of the package. PACKAGE='libcroco' - VERSION='0.6.9' + VERSION='0.6.10' cat >>confdefs.h <<_ACEOF @@ -13556,7 +13556,7 @@ # report actual input values of CONFIG_FILES etc. instead of their # values after options handling. ac_log=" -This file was extended by libcroco $as_me 0.6.9, which was +This file was extended by libcroco $as_me 0.6.10, which was generated by GNU Autoconf 2.69. Invocation command line was CONFIG_FILES = $CONFIG_FILES @@ -13622,7 +13622,7 @@ cat >>$CONFIG_STATUS <<_ACEOF || ac_write_fail=1 ac_cs_config="`$as_echo "$ac_configure_args" | sed 's/^ //; s/[\\""\`\$]/\\\\&/g'`" ac_cs_version="\\ -libcroco config.status 0.6.9 +libcroco config.status 0.6.10 configured by $0, generated by GNU Autoconf 2.69, with options \\"\$ac_cs_config\\" diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/libcroco-0.6.9/configure.ac new/libcroco-0.6.10/configure.ac --- old/libcroco-0.6.9/configure.ac 2015-10-31 11:39:18.000000000 +0100 +++ new/libcroco-0.6.10/configure.ac 2015-10-31 12:01:48.000000000 +0100 @@ -1,6 +1,6 @@ dnl Process this file with autoconf to produce a configure script. AC_PREREQ(2.64) -AC_INIT([libcroco],[0.6.9],[http://bugzilla.gnome.org/enter_bug.cgi?product=libcroco],[libcroco]) +AC_INIT([libcroco],[0.6.10],[http://bugzilla.gnome.org/enter_bug.cgi?product=libcroco],[libcroco]) AC_CONFIG_SRCDIR([src/cr-input.c]) AC_CANONICAL_HOST diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/libcroco-0.6.9/csslint/csslint.c new/libcroco-0.6.10/csslint/csslint.c --- old/libcroco-0.6.9/csslint/csslint.c 2014-09-17 14:58:16.000000000 +0200 +++ new/libcroco-0.6.10/csslint/csslint.c 2015-12-13 19:23:40.000000000 +0100 @@ -327,7 +327,8 @@ xml_doc = xmlParseFile (a_xml_path); if (!xml_doc) { g_printerr ("Error: Could not parse file %s\n", a_xml_path); - return CR_ERROR; + status = CR_ERROR; + goto end; } if (a_author_sheet_path) { status = cr_om_parser_simply_parse_file @@ -351,31 +352,46 @@ } } cascade = cr_cascade_new (author_sheet, user_sheet, ua_sheet); + + if (author_sheet) + cr_stylesheet_unref (author_sheet); + + if (user_sheet) + cr_stylesheet_unref (user_sheet); + + if (ua_sheet) + cr_stylesheet_unref (ua_sheet); + if (!cascade) { g_printerr ("Could not instanciate the cascade\n"); - return CR_ERROR; + status = CR_ERROR; + goto end; } sel_eng = cr_sel_eng_new (); if (!sel_eng) { g_printerr ("Error: Could not instanciate the selection engine\n"); - return CR_ERROR; + status = CR_ERROR; + goto end; } xpath_context = xmlXPathNewContext (xml_doc); if (!xpath_context) { g_printerr ("Error: Could not instanciate the xpath context\n"); - return CR_ERROR; + status = CR_ERROR; + goto end; } xpath_object = xmlXPathEvalExpression ((const xmlChar *) a_xpath, xpath_context); if (!xpath_object) { g_printerr ("Error: Could not evaluate xpath expression\n"); - return CR_ERROR; + status = CR_ERROR; + goto end; } if (xpath_object->type != XPATH_NODESET || !xpath_object->nodesetval) { g_printerr ("Error: xpath does not evalualuate to a node set\n"); - return CR_ERROR; + status = CR_ERROR; + goto end; } for (i = 0; i < xpath_object->nodesetval->nodeNr; i++) { @@ -386,11 +402,13 @@ } } + end: + if (xpath_context) { xmlXPathFreeContext (xpath_context); xpath_context = NULL; } - if (xpath_context) { + if (xpath_object) { xmlXPathFreeObject (xpath_object); xpath_object = NULL; } @@ -400,8 +418,14 @@ } if (cascade) { cr_cascade_destroy (cascade); + cascade = NULL; } - return CR_OK; + if (xml_doc) { + xmlFreeDoc (xml_doc); + xml_doc = NULL; + } + + return status; } /*************************** @@ -982,5 +1006,5 @@ } } - return 0; + return (status == CR_OK) ? 0 : -2; } diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/libcroco-0.6.9/libcroco-0.6.pc new/libcroco-0.6.10/libcroco-0.6.pc --- old/libcroco-0.6.9/libcroco-0.6.pc 2015-10-31 11:56:36.000000000 +0100 +++ new/libcroco-0.6.10/libcroco-0.6.pc 2015-12-13 19:24:36.000000000 +0100 @@ -4,7 +4,7 @@ includedir=${prefix}/include Name: libcroco -Version: 0.6.9 +Version: 0.6.10 Description: a CSS2 Parsing and manipulation Library in C. Requires: glib-2.0 libxml-2.0 Libs: -L${libdir} -lcroco-0.6 diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/libcroco-0.6.9/libcroco.spec new/libcroco-0.6.10/libcroco.spec --- old/libcroco-0.6.9/libcroco.spec 2015-10-31 11:56:33.000000000 +0100 +++ new/libcroco-0.6.10/libcroco.spec 2015-12-13 19:24:33.000000000 +0100 @@ -2,7 +2,7 @@ Name: libcroco Summary: CSS2 parser library -Version: 0.6.9 +Version: 0.6.10 Release: 1 License: LGPL Group: System/Libraries diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/libcroco-0.6.9/src/cr-enc-handler.c new/libcroco-0.6.10/src/cr-enc-handler.c --- old/libcroco-0.6.9/src/cr-enc-handler.c 2014-09-17 14:58:16.000000000 +0200 +++ new/libcroco-0.6.10/src/cr-enc-handler.c 2015-12-13 19:23:40.000000000 +0100 @@ -89,8 +89,7 @@ for (i = 0; gv_default_enc_handlers[i].encoding; i++) { if (gv_default_enc_handlers[i].encoding == a_enc) { - return (CREncHandler *) - & gv_default_enc_handlers[i].encoding; + return (CREncHandler *) & gv_default_enc_handlers[i]; } } @@ -118,8 +117,7 @@ g_return_val_if_fail (a_alias_name != NULL, CR_BAD_PARAM_ERROR); - alias_name_up = g_strdup (a_alias_name); - g_ascii_strup (alias_name_up, -1); + alias_name_up = (guchar *) g_ascii_strup ((const gchar *) a_alias_name, -1); for (i = 0; gv_default_aliases[i].name; i++) { if (!strcmp (gv_default_aliases[i].name, (const gchar *) alias_name_up)) { diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/libcroco-0.6.9/src/cr-input.c new/libcroco-0.6.10/src/cr-input.c --- old/libcroco-0.6.9/src/cr-input.c 2014-09-17 14:58:16.000000000 +0200 +++ new/libcroco-0.6.10/src/cr-input.c 2015-12-13 19:23:40.000000000 +0100 @@ -722,6 +722,8 @@ } + *a_nb_chars = (gulong) nb_consumed; + if (nb_consumed && status == CR_END_OF_INPUT_ERROR) { status = CR_OK; } diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/libcroco-0.6.9/src/cr-simple-sel.c new/libcroco-0.6.10/src/cr-simple-sel.c --- old/libcroco-0.6.9/src/cr-simple-sel.c 2014-09-17 14:58:16.000000000 +0200 +++ new/libcroco-0.6.10/src/cr-simple-sel.c 2015-10-31 20:19:29.000000000 +0100 @@ -254,7 +254,7 @@ g_return_val_if_fail (a_this, CR_BAD_PARAM_ERROR); for (cur_sel = a_this; cur_sel; cur_sel = cur_sel->next) { - if (cur_sel->type_mask | TYPE_SELECTOR) { + if (cur_sel->type_mask & TYPE_SELECTOR) { c++; /*hmmh, is this a new language ? */ } else if (!cur_sel->name || !cur_sel->name->stryng diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/libcroco-0.6.9/src/cr-style.c new/libcroco-0.6.10/src/cr-style.c --- old/libcroco-0.6.9/src/cr-style.c 2014-09-17 14:58:16.000000000 +0200 +++ new/libcroco-0.6.10/src/cr-style.c 2015-12-13 19:23:40.000000000 +0100 @@ -913,7 +913,7 @@ break; } - return CR_OK; + return status; } static enum CRStatus @@ -1676,7 +1676,7 @@ a_style->white_space = WHITE_SPACE_NORMAL; } else if (!strcmp (a_value->content.str->stryng->str, "pre")) { - a_style->font_weight = WHITE_SPACE_PRE; + a_style->white_space = WHITE_SPACE_PRE; } else if (!strcmp (a_value->content.str->stryng->str, "nowrap")) { a_style->white_space = WHITE_SPACE_NOWRAP; diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/libcroco-0.6.9/src/cr-tknzr.c new/libcroco-0.6.10/src/cr-tknzr.c --- old/libcroco-0.6.9/src/cr-tknzr.c 2014-09-17 14:58:16.000000000 +0200 +++ new/libcroco-0.6.10/src/cr-tknzr.c 2015-12-13 19:23:40.000000000 +0100 @@ -1901,6 +1901,8 @@ enum CRStatus cr_tknzr_consume_chars (CRTknzr * a_this, guint32 a_char, glong * a_nb_char) { + gulong consumed; + enum CRStatus status; g_return_val_if_fail (a_this && PRIVATE (a_this) && PRIVATE (a_this)->input, CR_BAD_PARAM_ERROR); @@ -1911,8 +1913,10 @@ PRIVATE (a_this)->token_cache = NULL; } - return cr_input_consume_chars (PRIVATE (a_this)->input, - a_char, a_nb_char); + status = cr_input_consume_chars (PRIVATE (a_this)->input, + a_char, &consumed); + *a_nb_char = (glong) consumed; + return status; } enum CRStatus @@ -2381,7 +2385,7 @@ next_bytes[0] = BYTE (input, 1, NULL); next_bytes[1] = BYTE (input, 2, NULL); next_bytes[2] = BYTE (input, 3, NULL); - next_bytes[3] = BYTE (input, 3, NULL); + next_bytes[3] = BYTE (input, 4, NULL); if (next_bytes[0] == 'e' && next_bytes[1] == 'm') { diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/libcroco-0.6.9/src/cr-utils.c new/libcroco-0.6.10/src/cr-utils.c --- old/libcroco-0.6.9/src/cr-utils.c 2015-10-30 09:00:39.000000000 +0100 +++ new/libcroco-0.6.10/src/cr-utils.c 2015-12-13 19:23:40.000000000 +0100 @@ -898,15 +898,10 @@ if (*a_in_len == 0) { *a_out_len = 0 ; - return CR_OK ; + return status; } g_return_val_if_fail (a_out, CR_BAD_PARAM_ERROR) ; - if (*a_in_len < 1) { - status = CR_OK; - goto end; - } - in_len = *a_in_len; out_len = *a_out_len; @@ -927,11 +922,10 @@ } } /*end for */ - end: *a_in_len = in_index; *a_out_len = out_index; - return CR_OK; + return status; } /** @@ -1017,7 +1011,6 @@ && a_out && a_out_len, CR_BAD_PARAM_ERROR); if (*a_in_len < 1) { - status = CR_OK; goto end; } @@ -1096,7 +1089,6 @@ *(if any) to get the current character. */ if (in_index + nb_bytes_2_decode - 1 >= in_len) { - status = CR_OK; goto end; } @@ -1130,7 +1122,7 @@ *a_out_len = out_index; *a_in_len = in_index; - return CR_OK; + return status; } /**
