Hello community, here is the log from the commit of package kjobwidgets for openSUSE:Factory checked in at 2016-02-24 18:55:58 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Comparing /work/SRC/openSUSE:Factory/kjobwidgets (Old) and /work/SRC/openSUSE:Factory/.kjobwidgets.new (New) ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "kjobwidgets" Changes: -------- --- /work/SRC/openSUSE:Factory/kjobwidgets/kjobwidgets.changes 2016-01-20 09:46:29.000000000 +0100 +++ /work/SRC/openSUSE:Factory/.kjobwidgets.new/kjobwidgets.changes 2016-02-24 18:55:59.000000000 +0100 @@ -1,0 +2,8 @@ +Sat Feb 6 18:04:45 UTC 2016 - [email protected] + +- Update to 5.19.0 (boo#967668) + * Fix crash in KJob dialogs (kde#346215) + * For more details please see: + https://www.kde.org/announcements/kde-frameworks-5.19.0.php + +------------------------------------------------------------------- Old: ---- kjobwidgets-5.18.0.tar.xz New: ---- kjobwidgets-5.19.0.tar.xz ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Other differences: ------------------ ++++++ kjobwidgets.spec ++++++ --- /var/tmp/diff_new_pack.wx6HPk/_old 2016-02-24 18:56:00.000000000 +0100 +++ /var/tmp/diff_new_pack.wx6HPk/_new 2016-02-24 18:56:00.000000000 +0100 @@ -18,9 +18,9 @@ %bcond_without lang %define lname libKF5JobWidgets5 -%define _tar_path 5.18 +%define _tar_path 5.19 Name: kjobwidgets -Version: 5.18.0 +Version: 5.19.0 Release: 0 %define kf5_version %{version} BuildRequires: cmake >= 2.8.12 ++++++ kjobwidgets-5.18.0.tar.xz -> kjobwidgets-5.19.0.tar.xz ++++++ diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/kjobwidgets-5.18.0/CMakeLists.txt new/kjobwidgets-5.19.0/CMakeLists.txt --- old/kjobwidgets-5.18.0/CMakeLists.txt 2016-01-02 17:41:22.000000000 +0100 +++ new/kjobwidgets-5.19.0/CMakeLists.txt 2016-02-08 21:09:46.000000000 +0100 @@ -3,7 +3,7 @@ project(KJobWidgets) include(FeatureSummary) -find_package(ECM 5.18.0 NO_MODULE) +find_package(ECM 5.19.0 NO_MODULE) set_package_properties(ECM PROPERTIES TYPE REQUIRED DESCRIPTION "Extra CMake Modules." URL "https://projects.kde.org/projects/kdesupport/extra-cmake-modules";) feature_summary(WHAT REQUIRED_PACKAGES_NOT_FOUND FATAL_ON_MISSING_REQUIRED_PACKAGES) @@ -11,13 +11,13 @@ set(CMAKE_MODULE_PATH ${ECM_MODULE_PATH} ${ECM_KDE_MODULE_DIR}) include(KDEInstallDirs) -include(KDEFrameworkCompilerSettings) +include(KDEFrameworkCompilerSettings NO_POLICY_SCOPE) include(KDECMakeSettings) include(ECMPoQmTools) -set(KF5_VERSION "5.18.0") # handled by release scripts -set(KF5_DEP_VERSION "5.18.0") # handled by release scripts +set(KF5_VERSION "5.19.0") # handled by release scripts +set(KF5_DEP_VERSION "5.19.0") # handled by release scripts set(REQUIRED_QT_VERSION 5.3.0) find_package(Qt5 ${REQUIRED_QT_VERSION} CONFIG REQUIRED Widgets DBus) diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/kjobwidgets-5.18.0/po/nb/kjobwidgets5_qt.po new/kjobwidgets-5.19.0/po/nb/kjobwidgets5_qt.po --- old/kjobwidgets-5.18.0/po/nb/kjobwidgets5_qt.po 2016-01-02 17:41:22.000000000 +0100 +++ new/kjobwidgets-5.19.0/po/nb/kjobwidgets5_qt.po 2016-02-08 21:09:46.000000000 +0100 @@ -4,7 +4,7 @@ # Bjørn Steensrud <[email protected]>, 2002, 2003, 2004, 2005, 2007, 2008, 2009, 2010, 2011, 2012, 2013, 2014. # Eskild Hustvedt <[email protected]>, 2004, 2005. # Gaute Hvoslef Kvalnes <[email protected]>, 2004, 2005. -# Axel Bojer <[email protected]>, 2005, 2006. +# Axel Bojer <[email protected]>, 2005, 2006. # Nils Kristian Tomren <[email protected]>, 2005, 2007. # Øyvind A. Holm <[email protected]>, 2009. msgid "" diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/kjobwidgets-5.18.0/src/kdialogjobuidelegate.cpp new/kjobwidgets-5.19.0/src/kdialogjobuidelegate.cpp --- old/kjobwidgets-5.18.0/src/kdialogjobuidelegate.cpp 2016-01-02 17:41:22.000000000 +0100 +++ new/kjobwidgets-5.19.0/src/kdialogjobuidelegate.cpp 2016-02-08 21:09:46.000000000 +0100 @@ -23,6 +23,7 @@ #include <QWidget> #include <QQueue> +#include <QPointer> #include <kmessagebox.h> #include <kjob.h> @@ -77,8 +78,16 @@ } QSharedPointer<MessageBoxData> data = queue.dequeue(); + + //kmessagebox starts a new event loop which can cause this to get deleted + //https://bugs.kde.org/show_bug.cgi?id=356321#c16 + QPointer<KDialogJobUiDelegate::Private> thisGuard(this); KMessageBox::messageBox(data->widget, data->type, data->msg); + if (!thisGuard) { + return; + } + QMetaObject::invokeMethod(this, "next", Qt::QueuedConnection); }
