Hello community, here is the log from the commit of package yast2-iscsi-lio-server for openSUSE:Factory checked in at 2016-07-15 12:54:09 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Comparing /work/SRC/openSUSE:Factory/yast2-iscsi-lio-server (Old) and /work/SRC/openSUSE:Factory/.yast2-iscsi-lio-server.new (New) ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "yast2-iscsi-lio-server" Changes: -------- --- /work/SRC/openSUSE:Factory/yast2-iscsi-lio-server/yast2-iscsi-lio-server.changes 2016-06-07 23:50:35.000000000 +0200 +++ /work/SRC/openSUSE:Factory/.yast2-iscsi-lio-server.new/yast2-iscsi-lio-server.changes 2016-07-15 12:54:22.000000000 +0200 @@ -1,0 +2,7 @@ +Wed Jul 6 11:00:53 CEST 2016 - g...@suse.de + +- allow to remove global authentication values + (bnc#919474, bnc#977342) +- 3.1.19 + +------------------------------------------------------------------- @@ -12,2 +19,2 @@ -- add hint to use different user and password for incoming and - outgoing authentication (bsc#977173) +- add hint to use different passwords for incoming and outgoing + authentication (bsc#977173) Old: ---- yast2-iscsi-lio-server-3.1.18.tar.bz2 New: ---- yast2-iscsi-lio-server-3.1.19.tar.bz2 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Other differences: ------------------ ++++++ yast2-iscsi-lio-server.spec ++++++ --- /var/tmp/diff_new_pack.LGQkZd/_old 2016-07-15 12:54:23.000000000 +0200 +++ /var/tmp/diff_new_pack.LGQkZd/_new 2016-07-15 12:54:23.000000000 +0200 @@ -17,7 +17,7 @@ Name: yast2-iscsi-lio-server -Version: 3.1.18 +Version: 3.1.19 Release: 0 BuildRoot: %{_tmppath}/%{name}-%{version}-build ++++++ yast2-iscsi-lio-server-3.1.18.tar.bz2 -> yast2-iscsi-lio-server-3.1.19.tar.bz2 ++++++ diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/yast2-iscsi-lio-server-3.1.18/package/yast2-iscsi-lio-server.changes new/yast2-iscsi-lio-server-3.1.19/package/yast2-iscsi-lio-server.changes --- old/yast2-iscsi-lio-server-3.1.18/package/yast2-iscsi-lio-server.changes 2016-06-07 14:09:45.000000000 +0200 +++ new/yast2-iscsi-lio-server-3.1.19/package/yast2-iscsi-lio-server.changes 2016-07-14 10:51:35.000000000 +0200 @@ -1,4 +1,11 @@ ------------------------------------------------------------------- +Wed Jul 6 11:00:53 CEST 2016 - g...@suse.de + +- allow to remove global authentication values + (bnc#919474, bnc#977342) +- 3.1.19 + +------------------------------------------------------------------- Tue Jun 7 10:47:30 UTC 2016 - igonzalezs...@suse.com - Stop generating autodocs (fate#320356) @@ -9,8 +16,8 @@ - replace iSCSI "client" by "initiator" in labels, popups and help text (fate#319293) -- add hint to use different user and password for incoming and - outgoing authentication (bsc#977173) +- add hint to use different passwords for incoming and outgoing + authentication (bsc#977173) - 3.1.17 ------------------------------------------------------------------- diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/yast2-iscsi-lio-server-3.1.18/package/yast2-iscsi-lio-server.spec new/yast2-iscsi-lio-server-3.1.19/package/yast2-iscsi-lio-server.spec --- old/yast2-iscsi-lio-server-3.1.18/package/yast2-iscsi-lio-server.spec 2016-06-07 14:09:45.000000000 +0200 +++ new/yast2-iscsi-lio-server-3.1.19/package/yast2-iscsi-lio-server.spec 2016-07-14 10:51:35.000000000 +0200 @@ -17,7 +17,7 @@ Name: yast2-iscsi-lio-server -Version: 3.1.18 +Version: 3.1.19 Release: 0 BuildRoot: %{_tmppath}/%{name}-%{version}-build diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/yast2-iscsi-lio-server-3.1.18/src/include/iscsi-lio-server/helps.rb new/yast2-iscsi-lio-server-3.1.19/src/include/iscsi-lio-server/helps.rb --- old/yast2-iscsi-lio-server-3.1.18/src/include/iscsi-lio-server/helps.rb 2016-06-07 14:09:45.000000000 +0200 +++ new/yast2-iscsi-lio-server-3.1.19/src/include/iscsi-lio-server/helps.rb 2016-07-14 10:51:35.000000000 +0200 @@ -131,7 +131,7 @@ "<p>With <b>Edit LUN</b> one can modify the LUN mapping. Please note that LUN target number" + " must be unique.<br>After pressing <b>Edit Auth</b>, select the type of authentication." + " Use <b>Incoming</b>, <b>Outgoing</b> or both together. Then insert <b>User</b> and <b>Password</b>." + - " Please make sure to set different values for incoming and outgoing authentication.\n" + + " Please make sure to set different passwords for incoming and outgoing authentication.\n" + " If <b>Use Authentication</b> is disabled in previous dialog, <b>Edit Auth</b> is disabled here.</p>" ) + _( "<p><b>Copy</b> offers the possibility to give an additional initiator access to the LUN.</p>"), diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/yast2-iscsi-lio-server-3.1.18/src/include/iscsi-lio-server/widgets.rb new/yast2-iscsi-lio-server-3.1.19/src/include/iscsi-lio-server/widgets.rb --- old/yast2-iscsi-lio-server-3.1.18/src/include/iscsi-lio-server/widgets.rb 2016-06-07 14:09:45.000000000 +0200 +++ new/yast2-iscsi-lio-server-3.1.19/src/include/iscsi-lio-server/widgets.rb 2016-07-14 10:51:35.000000000 +0200 @@ -97,28 +97,39 @@ end # **************** Global Dialog ********************* + + # treat "NULL" as empty string, i.e. no authentication value is set + # (adapt YaST to 'lio-utils' behaviour, bnc#919474) + def adjustAuth(value) + (value == "NULL") ? "" : value + end + def initGlobalValues(auth) auth = deep_copy(auth) + + # incoming authentication user = "" pass = "" - # incoming authentication - if !Builtins.isempty(Ops.get_list(auth, "incoming", [])) - user = Ops.get_string(auth, ["incoming", 0], "") - pass = Ops.get_string(auth, ["incoming", 1], "") + auth_in = auth["incoming"] || [] + if !auth_in.empty? + user = adjustAuth(auth_in[0] || "") + pass = adjustAuth(auth_in[1] || "") end UI.ChangeWidget(Id(:user_in), :Value, user) UI.ChangeWidget(Id(:pass_in), :Value, pass) - SetAuthIn(!Builtins.isempty(Ops.get_list(auth, "incoming", []))) + SetAuthIn(!user.empty? && !pass.empty?) + # outgoing authentication user = "" pass = "" - if !Builtins.isempty(Ops.get_list(auth, "outgoing", [])) - user = Ops.get_string(auth, ["outgoing", 0], "") - pass = Ops.get_string(auth, ["outgoing", 1], "") + auth_out = auth["outgoing"] || [] + if !auth_out.empty? + user = adjustAuth(auth_out[0] || "") + pass = adjustAuth(auth_out[1] || "") end UI.ChangeWidget(Id(:user_out), :Value, user) UI.ChangeWidget(Id(:pass_out), :Value, pass) - SetAuthOut(!Builtins.isempty(Ops.get_list(auth, "outgoing", []))) + SetAuthOut(!user.empty? && !pass.empty?) nil end