Hello community, here is the log from the commit of package virt-viewer for openSUSE:Factory checked in at 2016-07-20 09:17:40 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Comparing /work/SRC/openSUSE:Factory/virt-viewer (Old) and /work/SRC/openSUSE:Factory/.virt-viewer.new (New) ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "virt-viewer" Changes: -------- --- /work/SRC/openSUSE:Factory/virt-viewer/virt-viewer.changes 2016-06-14 23:07:10.000000000 +0200 +++ /work/SRC/openSUSE:Factory/.virt-viewer.new/virt-viewer.changes 2016-07-20 09:17:44.000000000 +0200 @@ -2 +2 @@ -Wed Jun 8 15:51:14 MDT 2016 - [email protected] +Thu Jul 14 19:46:34 MDT 2016 - [email protected] @@ -4,2 +4,41 @@ -- bsc#982793 - virt-viewer installation create unusable launcher - virtview-desktop.patch +- bsc#988858 - SLES12-SP2-Beta4 - virt-viewer throws Gtk-WARNING + even with --quiet switch +- Update to virt-viewer version 4.0 + virt-viewer-4.0.tar.bz2 + 35e489d5-fix-display-of-guest-name-in-title-for-vnc.patch + a62827d2-close-when-seeing-domain-stop-event.patch + - Drop support for gtk2 builds + - Require spice-gtk >= 0.31 + - Require glib2 >= 2.38 + - Require gtk3 >= 3.10 + - Require libvirt-glib >= 0.1.8 + - Increase minimum window size fo 320×200 instead of 50×50 + - Remove use of GSLice + - Don’t show usbredir button if not connected yet + - Only compute monitor mapping in full screen + - Don’t ignore usb-filter in spiec vv-file + - Port to use GtkApplication API + - Don’t leave window open after connection failure + - Validate symbols from max glib/gdk versions + - Don’t use GtkStock + - Don’t use gtk_widget-modify_{fg,bg} APIs + - Drop use of built-in eventloop in favour of libvirt-glib + - Don’t open X display while parsing command line + - Fix window title + - Use GResource for building ui files into binary + - Fix crash with invalid spice monitor mapping + - Add dialog to show file transfer progress and allow cancelling + - Remove unused nsis installer support + - Include adwaita icon theme in msi builds + - Add more menu mnemonics + - Fix support for windows consoles to allow I/O redirection + - Add support for ovirt sso-token in vv-file + - Fix crash with zooming window while not connected + - Remove custom auto drawer widget with GtkRevealer + - Add appdata file for gnome software + - Misc other bug fixes + - Refresh translations +- Dropped + fix-crash-on-zoom-change.patch + windows-keycombo.patch + netware-keycombo.patch Old: ---- fix-crash-on-zoom-change.patch netware-keycombo.patch virt-viewer-3.1.tar.bz2 windows-keycombo.patch New: ---- 35e489d5-fix-display-of-guest-name-in-title-for-vnc.patch a62827d2-close-when-seeing-domain-stop-event.patch virt-viewer-4.0.tar.bz2 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Other differences: ------------------ ++++++ virt-viewer.spec ++++++ --- /var/tmp/diff_new_pack.uBNWhu/_old 2016-07-20 09:17:44.000000000 +0200 +++ /var/tmp/diff_new_pack.uBNWhu/_new 2016-07-20 09:17:44.000000000 +0200 @@ -26,16 +26,15 @@ Summary: Virtual Machine Viewer License: GPL-2.0+ Group: System/Monitoring -Version: 3.1 +Version: 4.0 Release: 0 Url: http://www.virt-manager.org -Source0: virt-viewer-3.1.tar.bz2 +Source0: virt-viewer-4.0.tar.bz2 +Patch1: 35e489d5-fix-display-of-guest-name-in-title-for-vnc.patch +Patch2: a62827d2-close-when-seeing-domain-stop-event.patch Patch50: netcat.patch -Patch51: windows-keycombo.patch -Patch52: netware-keycombo.patch -Patch53: virtview-desktop.patch -Patch54: reverse-3d5627d7-for-xen.patch -Patch55: fix-crash-on-zoom-change.patch +Patch51: virtview-desktop.patch +Patch52: reverse-3d5627d7-for-xen.patch ExclusiveArch: %ix86 x86_64 s390x BuildRoot: %{_tmppath}/%{name}-%{version}-build @@ -46,8 +45,9 @@ BuildRequires: glib2-devel >= 2.26 BuildRequires: gtk2-devel %endif -BuildRequires: libvirt-devel >= 0.9.7 BuildRequires: libxml2-devel +BuildRequires: pkgconfig(libvirt) >= 0.10.0 +BuildRequires: pkgconfig(libvirt-glib-1.0) >= 0.1.8 %if %suse_version > 1140 %if %suse_version >= 1315 BuildRequires: pkgconfig(gtk-vnc-2.0) @@ -77,12 +77,11 @@ %prep %setup -q +%patch1 -p1 +%patch2 -p1 %patch50 -p1 %patch51 -p1 %patch52 -p1 -%patch53 -p1 -%patch54 -p1 -%patch55 -p1 %build echo "suse_version = %suse_version" @@ -103,10 +102,9 @@ %files -f %{name}.lang %defattr(-,root,root,-) %doc COPYING AUTHORS ChangeLog +%dir %{_datadir}/appdata %{_bindir}/%{name} %{_bindir}/remote-viewer -%dir %{_datadir}/%{name} -%dir %{_datadir}/%{name}/ui %{_datadir}/icons/hicolor/*/apps/* %{_datadir}/icons/hicolor/24x24/devices/virt-viewer-usb.png %{_datadir}/icons/hicolor/24x24/devices/virt-viewer-usb.svg @@ -114,12 +112,6 @@ %{_mandir}/man1/remote-viewer.1* %{_datadir}/applications/remote-viewer.desktop %{_datadir}/mime/packages/virt-viewer-mime.xml -%{_datadir}/virt-viewer/ui/remote-viewer-connect.xml -%{_datadir}/virt-viewer/ui/virt-viewer-about.xml -%{_datadir}/virt-viewer/ui/virt-viewer-auth.xml -%{_datadir}/virt-viewer/ui/virt-viewer.xml -%{_datadir}/virt-viewer/ui/virt-viewer-guest-details.xml -%{_datadir}/virt-viewer/ui/virt-viewer-vm-connection.xml -%{_datadir}/virt-viewer/ui/virt-viewer-preferences.xml +%{_datadir}/appdata/remote-viewer.appdata.xml %changelog ++++++ 35e489d5-fix-display-of-guest-name-in-title-for-vnc.patch ++++++ Subject: virt-viewer: fix display of guest name in title for vnc From: Daniel P. Berrange [email protected] Tue Jul 12 10:46:06 2016 +0100 Date: Tue Jul 12 10:46:06 2016 +0100: Git: 35e489d5190f7acd822240e777c43a2432fbad7b The following commit broke the display of the guest name in the title for VNC displays: commit 61a1bc4dcbb056755fe96c5945f84c1312041059 Author: Pavel Grunt <[email protected]> Date: Wed Apr 15 13:50:35 2015 +0200 session-vnc: Set window for display to avoid gtk-vnc v0.3.8 crash The VNC display widget of gtk-vnc v0.3.8 needs a window at the moment The problem is that this causes the window to be associated with the display before the guest name is available. Thus when ensure_window_for_display() runs, the window is already configured and so it never invokes the logic to set the title. The fix is to unconditionally update the title in the ensure_window_for_display() method, even if the window already exists. Signed-off-by: Daniel P. Berrange <[email protected]> diff --git a/src/virt-viewer-app.c b/src/virt-viewer-app.c index f983db2..e8412ac 100644 --- a/src/virt-viewer-app.c +++ b/src/virt-viewer-app.c @@ -898,7 +898,6 @@ ensure_window_for_display(VirtViewerApp *self, VirtViewerDisplay *display) if (l && virt_viewer_window_get_display(VIRT_VIEWER_WINDOW(l->data)) == NULL) { win = VIRT_VIEWER_WINDOW(l->data); g_debug("Found a window without a display, reusing for display #%d", nth); - virt_viewer_app_set_window_subtitle(self, win, nth); if (self->priv->fullscreen && !self->priv->kiosk) app_window_try_fullscreen(self, win, nth); } else { @@ -907,6 +906,7 @@ ensure_window_for_display(VirtViewerApp *self, VirtViewerDisplay *display) virt_viewer_window_set_display(win, display); } + virt_viewer_app_set_window_subtitle(self, win, nth); return win; } ++++++ a62827d2-close-when-seeing-domain-stop-event.patch ++++++ Subject: virt-viewer: ensure we close when seeing domain stop event From: Daniel P. Berrange [email protected] Tue Jul 12 11:27:09 2016 +0100 Date: Tue Jul 12 13:54:15 2016 +0100: Git: a62827d28c6b69e90102e4c1c8043cbddad8929a Normally virt-viewer relies on the VNC/SPICE widget seeing an EOF on its underlying connection to detect when the session is closed. When tunnelling to a remote guest over SSH though, this EOF can be delayed for a very long time, leaving a dead session open. This can be seen with virt-viewer -c qemu+ssh://remotehost/system guestname when on the remote shell run virsh destroy guestname and notice that virt-viewer does not see the shutdown immediately. When we get a domain stopped event we know the session should be dead, so forceably close it, if not already closed. Signed-off-by: Daniel P. Berrange <[email protected]> diff --git a/src/virt-viewer.c b/src/virt-viewer.c index 173b0d3..3a3b64d 100644 --- a/src/virt-viewer.c +++ b/src/virt-viewer.c @@ -664,6 +664,7 @@ virt_viewer_domain_event(virConnectPtr conn G_GNUC_UNUSED, { VirtViewer *self = opaque; VirtViewerApp *app = VIRT_VIEWER_APP(self); + VirtViewerSession *session; GError *error = NULL; g_debug("Got domain event %d %d", event, detail); @@ -673,7 +674,9 @@ virt_viewer_domain_event(virConnectPtr conn G_GNUC_UNUSED, switch (event) { case VIR_DOMAIN_EVENT_STOPPED: - //virt_viewer_deactivate(self); + session = virt_viewer_app_get_session(app); + if (session != NULL) + virt_viewer_session_close(session); break; case VIR_DOMAIN_EVENT_STARTED: ++++++ netcat.patch ++++++ --- /var/tmp/diff_new_pack.uBNWhu/_old 2016-07-20 09:17:44.000000000 +0200 +++ /var/tmp/diff_new_pack.uBNWhu/_new 2016-07-20 09:17:44.000000000 +0200 @@ -1,8 +1,8 @@ -Index: virt-viewer-3.1/src/virt-viewer-app.c +Index: virt-viewer-4.0/src/virt-viewer-app.c =================================================================== ---- virt-viewer-3.1.orig/src/virt-viewer-app.c -+++ virt-viewer-3.1/src/virt-viewer-app.c -@@ -691,7 +691,7 @@ virt_viewer_app_open_tunnel_ssh(const ch +--- virt-viewer-4.0.orig/src/virt-viewer-app.c ++++ virt-viewer-4.0/src/virt-viewer-app.c +@@ -626,7 +626,7 @@ virt_viewer_app_open_tunnel_ssh(const ch else g_string_append_printf(cat, "UNIX-CONNECT:%s", unixsock); ++++++ reverse-3d5627d7-for-xen.patch ++++++ --- /var/tmp/diff_new_pack.uBNWhu/_old 2016-07-20 09:17:44.000000000 +0200 +++ /var/tmp/diff_new_pack.uBNWhu/_new 2016-07-20 09:17:44.000000000 +0200 @@ -8,11 +8,11 @@ Even when the server doesn't provide a display connection address, virt-viewer is able to connect to guest with libvirt attach. -Index: virt-viewer-3.1/src/virt-viewer.c +Index: virt-viewer-4.0/src/virt-viewer.c =================================================================== ---- virt-viewer-3.1.orig/src/virt-viewer.c -+++ virt-viewer-3.1/src/virt-viewer.c -@@ -428,18 +428,17 @@ virt_viewer_extract_connect_info(VirtVie +--- virt-viewer-4.0.orig/src/virt-viewer.c ++++ virt-viewer-4.0/src/virt-viewer.c +@@ -515,18 +515,17 @@ virt_viewer_extract_connect_info(VirtVie ghost = virt_viewer_extract_xpath_string(xmldesc, xpath); } else { xpath = g_strdup_printf("string(/domain/devices/graphics[@type='%s']/@socket)", type); ++++++ virt-viewer-3.1.tar.bz2 -> virt-viewer-4.0.tar.bz2 ++++++ ++++ 123748 lines of diff (skipped) ++++++ virtview-desktop.patch ++++++ --- /var/tmp/diff_new_pack.uBNWhu/_old 2016-07-20 09:17:45.000000000 +0200 +++ /var/tmp/diff_new_pack.uBNWhu/_new 2016-07-20 09:17:45.000000000 +0200 @@ -1,24 +1,27 @@ -Index: virt-viewer-3.1/data/remote-viewer.desktop.in +Index: virt-viewer-4.0/data/remote-viewer.desktop.in =================================================================== ---- virt-viewer-3.1.orig/data/remote-viewer.desktop.in -+++ virt-viewer-3.1/data/remote-viewer.desktop.in -@@ -1,10 +1,21 @@ +--- virt-viewer-4.0.orig/data/remote-viewer.desktop.in ++++ virt-viewer-4.0/data/remote-viewer.desktop.in +@@ -1,10 +1,22 @@ [Desktop Entry] _Name=Remote Viewer -_Comment=Access remote desktops +-Exec=remote-viewer %u +X-SuSE-translate=true -+Comment=Access remote desktops -+GenericName=Remote Desktop Client ++Comment=Virtual Machine Viewer for Xen and KVM ++GenericName=VM Viewer for Xen/KVM +Icon=yast-vm-management - Exec=remote-viewer %u ++Exec=/usr/bin/virt-viewer Type=Application Terminal=false - MimeType=x-scheme-handler/spice;application/x-virt-viewer; +-MimeType=x-scheme-handler/spice;application/x-virt-viewer; -StartupNotify=true -Categories=GNOME;GTK;Network;RemoteAccess; ++MimeType=x-scheme-handler/spice; +Encoding=UTF-8 -+Categories=GNOME;GTK;Network;RemoteAccess;X-SuSE-YaST; ++Categories=Qt;X-SuSE-YaST; +X-KDE-ModuleType=Library ++X-KDE-RootOnly=true +X-KDE-HasReadOnlyMode=false +X-SuSE-YaST-Call=/usr/bin/virt-manager +X-SuSE-YaST-Group=Virtualization
