Hello community, here is the log from the commit of package aria2 for openSUSE:Factory checked in at 2016-08-03 11:43:23 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Comparing /work/SRC/openSUSE:Factory/aria2 (Old) and /work/SRC/openSUSE:Factory/.aria2.new (New) ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "aria2" Changes: -------- --- /work/SRC/openSUSE:Factory/aria2/aria2.changes 2016-06-19 10:50:47.000000000 +0200 +++ /work/SRC/openSUSE:Factory/.aria2.new/aria2.changes 2016-08-03 11:43:23.000000000 +0200 @@ -1,0 +2,37 @@ +Wed Jul 27 22:04:15 UTC 2016 - jeng...@inai.de + +- Trim filler phrases from description. + Explicitly add BR:pkgconfig so pkgconfigdeps.sh can autocreate + pkgconfig() symbols. + +------------------------------------------------------------------- +Mon Jul 25 13:57:04 UTC 2016 - mplus...@suse.com + +- Update to version 1.25.0: + * Update third-party libraries for binary releases + * Send have message without too much delay + * Also send bitfield rather than have messages if bitfield + message is equal to or less than the sum of have messages + which otherwise would be sent. + * Fix bug that causes bogus EOF connection failure in BitTorrent + downloads + * Fix frequent interested/not interested message transmission + * Fix frequent choke/unchoke message transmission + * Try to use available URI if all pooled requests are sleeping + * Update expat in OSX build + * aria2mon: Add --secret option + * Set server status error on network failure in server + performance profile + * Disable AI_ADDRCONFIG if no IPv4/IPv6 address is configured for + any interface + * Russian manual: Update aria2c.rst + * Apply --retry-wait on 503 only + * Ensure that lowest speed check is done even when download speed + is 0 + * Document that -o is always relative to -d option + * Allow larger ut_metadata size + * mingw: Change FD_SETSIZE to 32768 + * Fix compile error on OS X +- Add aria2-no-return-in-nonvoid-function.patch + +------------------------------------------------------------------- Old: ---- aria2-1.24.0.tar.xz New: ---- aria2-1.25.0.tar.xz aria2-no-return-in-nonvoid-function.patch ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Other differences: ------------------ ++++++ aria2.spec ++++++ --- /var/tmp/diff_new_pack.PDB1KA/_old 2016-08-03 11:43:24.000000000 +0200 +++ /var/tmp/diff_new_pack.PDB1KA/_new 2016-08-03 11:43:24.000000000 +0200 @@ -18,7 +18,7 @@ %define somajor 0 Name: aria2 -Version: 1.24.0 +Version: 1.25.0 Release: 0 Summary: Parallelizing Multi-Protocol Utility for Downloading Files License: SUSE-GPL-2.0-with-openssl-exception @@ -26,9 +26,12 @@ Url: https://aria2.github.io Source0: https://github.com/aria2/aria2/releases/download/release-%{version}/aria2-%{version}.tar.xz Source1: %{name}.changes +# PATCH-FIX-UPSTREAM aria2-no-return-in-nonvoid-function.patch +Patch0: aria2-no-return-in-nonvoid-function.patch BuildRequires: bison BuildRequires: gcc-c++ BuildRequires: gmp-devel +BuildRequires: pkg-config BuildRequires: pkgconfig(cppunit) BuildRequires: pkgconfig(gnutls) BuildRequires: pkgconfig(libcares) @@ -45,13 +48,11 @@ %endif %description -aria2 is a utility for downloading files. It has completely new design -concept from its predecessor, Aria, and is written from scratch. aria2 has -a segmented downloading engine in its core. It can download one file from -multiple URLs or multiple connections from one URL. This results in very -high speed downloading, much faster than ordinary browsers. This engine in -was implemented in a single-thread model. The architecture is clean and easy -to extend. +aria2 is a utility for downloading files. It has a segmented +downloading engine in its core. It can download one file from +multiple URLs or multiple connections from one URL. This can be used +to speed up downloads with certain networks. The engine in was +implemented in a single-thread model. aria2 currently supports HTTP, FTP, and BitTorrent. @@ -62,35 +63,31 @@ Group: System/Libraries %description -n lib%{name}-%{somajor} -aria2 is a utility for downloading files. It has completely new design -concept from its predecessor, Aria, and is written from scratch. aria2 has -a segmented downloading engine in its core. It can download one file from -multiple URLs or multiple connections from one URL. This results in very -high speed downloading, much faster than ordinary browsers. This engine in -was implemented in a single-thread model. The architecture is clean and easy -to extend. +aria2 is a utility for downloading files. It has a segmented +downloading engine in its core. It can download one file from +multiple URLs or multiple connections from one URL. This can be used +to speed up downloads with certain networks. The engine in was +implemented in a single-thread model. -This package contains shared library +This package contains the shared library. %package devel -Summary: Devel files for %{name} +Summary: Development files for %{name} Group: Development/Libraries/C and C++ Requires: lib%{name}-%{somajor} = %{version} %description devel -aria2 is a utility for downloading files. It has completely new design -concept from its predecessor, Aria, and is written from scratch. aria2 has -a segmented downloading engine in its core. It can download one file from -multiple URLs or multiple connections from one URL. This results in very -high speed downloading, much faster than ordinary browsers. This engine in -was implemented in a single-thread model. The architecture is clean and -easy -to extend. +aria2 is a utility for downloading files. It has a segmented +downloading engine in its core. It can download one file from +multiple URLs or multiple connections from one URL. This can be used +to speed up downloads with certain networks. The engine in was +implemented in a single-thread model. -This package contains devel files for its shared library +This package contains development files for its shared library. %prep %setup -q +%patch0 -p1 # Do not use current date modified="$(sed -n '/^----/n;s/ - .*$//;p;q' "%{SOURCE1}")" DATE="\"$(date -d "${modified}" "+%%b %%e %%Y")\"" ++++++ aria2-1.24.0.tar.xz -> aria2-1.25.0.tar.xz ++++++ ++++ 71442 lines of diff (skipped) ++++++ aria2-no-return-in-nonvoid-function.patch ++++++ >From f5ceeebe8604c6b5d08de5744d245c6b0551a9b9 Mon Sep 17 00:00:00 2001 From: Nils Maier <maier...@web.de> Date: Tue, 19 Jul 2016 15:36:09 +0200 Subject: [PATCH] Fix some compiler warnings --- src/DHTGetPeersReplyMessage.cc | 9 ++++++--- src/DefaultPeerStorage.h | 2 +- src/FileEntry.cc | 3 ++- src/HttpResponseCommand.cc | 2 +- src/OptionHandlerImpl.cc | 2 +- src/UnknownLengthPieceStorage.h | 2 ++ test/MockPeerStorage.h | 2 +- test/MockPieceStorage.h | 2 ++ 8 files changed, 16 insertions(+), 8 deletions(-) diff --git a/src/DHTGetPeersReplyMessage.cc b/src/DHTGetPeersReplyMessage.cc index 2ae92f3..2e6c187 100644 --- a/src/DHTGetPeersReplyMessage.cc +++ b/src/DHTGetPeersReplyMessage.cc @@ -84,7 +84,6 @@ std::unique_ptr<Dict> DHTGetPeersReplyMessage::getResponse() if (!closestKNodes_.empty()) { std::array<unsigned char, DHTBucket::K * 38> buffer; const auto clen = bittorrent::getCompactLength(family_); - const auto unit = clen + DHT_ID_LENGTH; auto last = std::begin(buffer); size_t k = 0; for (auto i = std::begin(closestKNodes_); @@ -92,7 +91,9 @@ std::unique_ptr<Dict> DHTGetPeersReplyMessage::getResponse() std::array<unsigned char, COMPACT_LEN_IPV6> compact; auto compactlen = bittorrent::packcompact( compact.data(), (*i)->getIPAddress(), (*i)->getPort()); - if (compactlen == clen) { + auto cclen = + static_cast<std::make_unsigned<decltype(clen)>::type>((clen)); + if (clen >= 0 && compactlen == cclen) { last = std::copy_n((*i)->getID(), DHT_ID_LENGTH, last); last = std::copy_n(std::begin(compact), compactlen, last); ++k; @@ -132,7 +133,9 @@ std::unique_ptr<Dict> DHTGetPeersReplyMessage::getResponse() const auto clen = bittorrent::getCompactLength(family_); auto compactlen = bittorrent::packcompact( compact.data(), (*i)->getIPAddress(), (*i)->getPort()); - if (compactlen == clen) { + auto cclen = + static_cast<std::make_unsigned<decltype(clen)>::type>((clen)); + if (clen > 0 && compactlen == cclen) { valuesList->append(String::g(compact.data(), compactlen)); } } diff --git a/src/DefaultPeerStorage.h b/src/DefaultPeerStorage.h index 1daba84..4ba716a 100644 --- a/src/DefaultPeerStorage.h +++ b/src/DefaultPeerStorage.h @@ -95,7 +95,7 @@ class DefaultPeerStorage : public PeerStorage { addPeer(const std::vector<std::shared_ptr<Peer>>& peers) CXX11_OVERRIDE; std::shared_ptr<Peer> addAndCheckoutPeer(const std::shared_ptr<Peer>& peer, - cuid_t cuid); + cuid_t cuid) CXX11_OVERRIDE; const std::deque<std::shared_ptr<Peer>>& getUnusedPeers(); diff --git a/src/FileEntry.cc b/src/FileEntry.cc index 95b3f50..453c681 100644 --- a/src/FileEntry.cc +++ b/src/FileEntry.cc @@ -184,8 +184,9 @@ std::shared_ptr<Request> FileEntry::getRequestWithInFlightHosts( continue; } - return req; + break; } + return req; } std::shared_ptr<Request> FileEntry::getRequest( diff --git a/src/HttpResponseCommand.cc b/src/HttpResponseCommand.cc index dc1501e..7d94252 100644 --- a/src/HttpResponseCommand.cc +++ b/src/HttpResponseCommand.cc @@ -544,7 +544,7 @@ HttpResponseCommand::createHttpDownloadCommand( getRequestGroup()->getURISelector()->tuneDownloadCommand( getFileEntry()->getRemainingUris(), command.get()); - return std::move(command); + return command; } void HttpResponseCommand::poolConnection() diff --git a/src/OptionHandlerImpl.cc b/src/OptionHandlerImpl.cc index 3b66e3a..1241299 100644 --- a/src/OptionHandlerImpl.cc +++ b/src/OptionHandlerImpl.cc @@ -625,7 +625,7 @@ void OptimizeConcurrentDownloadsOptionHandler::parseArg( for (;;) { char* end; errno = 0; - auto dbl = strtod(sptr->c_str(), &end); + strtod(sptr->c_str(), &end); if (errno != 0 || sptr->c_str() + sptr->size() != end) { throw DL_ABORT_EX(fmt("Bad number '%s'", sptr->c_str())); } diff --git a/src/UnknownLengthPieceStorage.h b/src/UnknownLengthPieceStorage.h index 3263870..a8384ce 100644 --- a/src/UnknownLengthPieceStorage.h +++ b/src/UnknownLengthPieceStorage.h @@ -35,6 +35,7 @@ #ifndef D_UNKNOWN_LENGTH_PIECE_STORAGE_H #define D_UNKNOWN_LENGTH_PIECE_STORAGE_H +#include "FatalException.h" #include "PieceStorage.h" namespace aria2 { @@ -236,6 +237,7 @@ class UnknownLengthPieceStorage : public PieceStorage { getAdvertisedPieceIndexes(std::vector<size_t>& indexes, cuid_t myCuid, uint64_t lastHaveIndex) CXX11_OVERRIDE { + throw FATAL_EXCEPTION("Not Implemented!"); } virtual void removeAdvertisedPiece(const Timer& expiry) CXX11_OVERRIDE {} diff --git a/test/MockPeerStorage.h b/test/MockPeerStorage.h index 7aa0b0c..e5508d0 100644 --- a/test/MockPeerStorage.h +++ b/test/MockPeerStorage.h @@ -39,7 +39,7 @@ class MockPeerStorage : public PeerStorage { } virtual std::shared_ptr<Peer> - addAndCheckoutPeer(const std::shared_ptr<Peer>& peer, cuid_t cuid) + addAndCheckoutPeer(const std::shared_ptr<Peer>& peer, cuid_t cuid) CXX11_OVERRIDE { unusedPeers.push_back(peer); return nullptr; diff --git a/test/MockPieceStorage.h b/test/MockPieceStorage.h index 8929736..379f974 100644 --- a/test/MockPieceStorage.h +++ b/test/MockPieceStorage.h @@ -6,6 +6,7 @@ #include <algorithm> #include "BitfieldMan.h" +#include "FatalException.h" #include "Piece.h" #include "DiskAdaptor.h" @@ -250,6 +251,7 @@ class MockPieceStorage : public PieceStorage { getAdvertisedPieceIndexes(std::vector<size_t>& indexes, cuid_t myCuid, uint64_t lastHaveIndex) CXX11_OVERRIDE { + throw FATAL_EXCEPTION("Not Implemented!"); } virtual void removeAdvertisedPiece(const Timer& expiry) CXX11_OVERRIDE {}
