Hello community, here is the log from the commit of package yast2-kdump for openSUSE:Factory checked in at 2016-08-18 10:19:26 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Comparing /work/SRC/openSUSE:Factory/yast2-kdump (Old) and /work/SRC/openSUSE:Factory/.yast2-kdump.new (New) ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "yast2-kdump" Changes: -------- --- /work/SRC/openSUSE:Factory/yast2-kdump/yast2-kdump.changes 2016-07-28 23:42:23.000000000 +0200 +++ /work/SRC/openSUSE:Factory/.yast2-kdump.new/yast2-kdump.changes 2016-08-18 10:19:27.000000000 +0200 @@ -1,0 +2,6 @@ +Fri Aug 12 10:45:05 CEST 2016 - [email protected] + +- Reading kernel_param: Filtering out empty entries. (bnc#991140) +- 3.1.40 + +------------------------------------------------------------------- Old: ---- yast2-kdump-3.1.39.tar.bz2 New: ---- yast2-kdump-3.1.40.tar.bz2 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Other differences: ------------------ ++++++ yast2-kdump.spec ++++++ --- /var/tmp/diff_new_pack.k9yiLc/_old 2016-08-18 10:19:28.000000000 +0200 +++ /var/tmp/diff_new_pack.k9yiLc/_new 2016-08-18 10:19:28.000000000 +0200 @@ -17,7 +17,7 @@ Name: yast2-kdump -Version: 3.1.39 +Version: 3.1.40 Release: 0 Summary: Configuration of kdump License: GPL-2.0 ++++++ yast2-kdump-3.1.39.tar.bz2 -> yast2-kdump-3.1.40.tar.bz2 ++++++ diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/yast2-kdump-3.1.39/package/yast2-kdump.changes new/yast2-kdump-3.1.40/package/yast2-kdump.changes --- old/yast2-kdump-3.1.39/package/yast2-kdump.changes 2016-07-20 14:01:43.000000000 +0200 +++ new/yast2-kdump-3.1.40/package/yast2-kdump.changes 2016-08-12 13:02:01.000000000 +0200 @@ -1,4 +1,10 @@ ------------------------------------------------------------------- +Fri Aug 12 10:45:05 CEST 2016 - [email protected] + +- Reading kernel_param: Filtering out empty entries. (bnc#991140) +- 3.1.40 + +------------------------------------------------------------------- Wed Jul 20 13:48:18 CEST 2016 - [email protected] - Proposing kdump to be disabled by default on ARM64 (bsc#989321) diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/yast2-kdump-3.1.39/package/yast2-kdump.spec new/yast2-kdump-3.1.40/package/yast2-kdump.spec --- old/yast2-kdump-3.1.39/package/yast2-kdump.spec 2016-07-20 14:01:43.000000000 +0200 +++ new/yast2-kdump-3.1.40/package/yast2-kdump.spec 2016-08-12 13:02:01.000000000 +0200 @@ -17,7 +17,7 @@ Name: yast2-kdump -Version: 3.1.39 +Version: 3.1.40 Release: 0 Summary: Configuration of kdump License: GPL-2.0 diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/yast2-kdump-3.1.39/src/modules/Kdump.rb new/yast2-kdump-3.1.40/src/modules/Kdump.rb --- old/yast2-kdump-3.1.39/src/modules/Kdump.rb 2016-07-20 14:01:43.000000000 +0200 +++ new/yast2-kdump-3.1.40/src/modules/Kdump.rb 2016-08-12 13:02:01.000000000 +0200 @@ -288,7 +288,8 @@ @crashkernel_param_values = result else # Let's make sure it's an array - @crashkernel_param_values = Array(result) + # filtering nils and empty entries bnc#991140 + @crashkernel_param_values = Array(result).compact.reject(&:empty?) # Read the current value only if crashkernel parameter is set. # (bnc#887901) @allocated_memory = get_allocated_memory(@crashkernel_param_values) diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/yast2-kdump-3.1.39/test/kdump_test.rb new/yast2-kdump-3.1.40/test/kdump_test.rb --- old/yast2-kdump-3.1.39/test/kdump_test.rb 2016-07-20 14:01:43.000000000 +0200 +++ new/yast2-kdump-3.1.40/test/kdump_test.rb 2016-08-12 13:02:01.000000000 +0200 @@ -232,6 +232,26 @@ end end + context "when the param includes empty/nil entries" do + let(:kernel_param) { [nil, ""] } + + it "reports presence of the param" do + expect(Yast::Kdump.crashkernel_param).to eq true + end + + it "schedules the writing on the param" do + expect(Yast::Kdump.add_crashkernel_param).to eq true + end + + it "does not find several ranges" do + expect(Yast::Kdump.crashkernel_list_ranges).to eq false + end + + it "empty value will be returned" do + expect(Yast::Kdump.allocated_memory).to be_empty + end + end + context "when the param is a number" do let(:kernel_param) { "32M" }
