Hello community, here is the log from the commit of package chromium for openSUSE:Factory checked in at 2016-08-24 10:17:14 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Comparing /work/SRC/openSUSE:Factory/chromium (Old) and /work/SRC/openSUSE:Factory/.chromium.new (New) ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "chromium" Changes: -------- --- /work/SRC/openSUSE:Factory/chromium/chromium.changes 2016-07-18 21:23:44.000000000 +0200 +++ /work/SRC/openSUSE:Factory/.chromium.new/chromium.changes 2016-08-24 10:17:25.000000000 +0200 @@ -1,0 +2,75 @@ +Mon Aug 22 10:13:19 UTC 2016 - [email protected] + +- Change buildsystem to GN, which is the new upstream default + * Make Ninja only use 4 buildprocesses for building Chromium itself + + * Drop unnecessary patches + - chromium-gcc-fixes.patch + - adjust-ldflags-no-keep-memory.patch + - gcc50-fixes.diff + + * Add patches to ensure correct build + - chromium-last-commit-position-r0.patch + - chromium-snapshot-toolchain-r1.patch + + * Drop unnecessary sourcefiles + - courgette.tar.xz + - depot_tools.tar.xz + - gn-binaries.tar.xz + +------------------------------------------------------------------- +Fri Aug 12 08:20:57 UTC 2016 - [email protected] + +- Use an explicit number of ninja build processes (-j 4), to + further reduce the memory used. + +------------------------------------------------------------------- +Fri Aug 5 08:53:57 UTC 2016 - [email protected] + +- Update to Chromium 52.0.2743.116: + * Security fixes (boo#992305): + + CVE-2016-5141: Address bar spoofing (boo#992314) + + CVE-2016-5142: Use-after-free in Blink (boo#992313) + + CVE-2016-5139: Heap overflow in pdfium (boo#992311) + + CVE-2016-5140: Heap overflow in pdfium (boo#992310) + + CVE-2016-5145: Same origin bypass for images in Blink + (boo#992320) + + CVE-2016-5143: Parameter sanitization failure in DevTools + (boo#992319) + + CVE-2016-5144: Parameter sanitization failure in DevTools + (boo#992315) + + CVE-2016-5146: Various fixes from internal audits, fuzzing + and other initiatives (boo#992309) + +------------------------------------------------------------------- +Thu Jul 21 18:55:21 UTC 2016 - [email protected] + +- Temporarily disable fix_network_api_crash.patch. Upstream has + changed part of their code, so hopefully that resolved the issue + +------------------------------------------------------------------- +Thu Jul 21 07:38:12 UTC 2016 - [email protected] + +- Update to Chromium 52.0.2743.82 + * Security fixes (boo#989901): + + CVE-2016-1706: Sandbox escape in PPAPI + + CVE-2016-1707: URL spoofing on iOS + + CVE-2016-1708: Use-after-free in Extensions + + CVE-2016-1709: Heap-buffer-overflow in sfntly + + CVE-2016-1710: Same-origin bypass in Blink + + CVE-2016-1711: Same-origin bypass in Blink + + CVE-2016-5127: Use-after-free in Blink + + CVE-2016-5128: Same-origin bypass in V8 + + CVE-2016-5129: Memory corruption in V8 + + CVE-2016-5130: URL spoofing + + CVE-2016-5131: Use-after-free in libxml + + CVE-2016-5132: Limited same-origin bypass in Service Workers + + CVE-2016-5133: Origin confusion in proxy authentication + + CVE-2016-5134: URL leakage via PAC script + + CVE-2016-5135: Content-Security-Policy bypass + + CVE-2016-5136: Use after free in extensions + + CVE-2016-5137: History sniffing with HSTS and CSP + + CVE-2016-1705: Various fixes from internal audits, fuzzing + and other initiatives + +------------------------------------------------------------------- Old: ---- adjust-ldflags-no-keep-memory.patch chromium-51.0.2704.106.tar.xz chromium-gcc-fixes.patch courgette.tar.xz depot_tools.tar.xz gcc50-fixes.diff gn-binaries.tar.xz New: ---- chromium-52.0.2743.116.tar.xz chromium-last-commit-position-r0.patch chromium-snapshot-toolchain-r1.patch ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Other differences: ------------------ ++++++ chromium.spec ++++++ --- /var/tmp/diff_new_pack.kOyKfT/_old 2016-08-24 10:17:39.000000000 +0200 +++ /var/tmp/diff_new_pack.kOyKfT/_new 2016-08-24 10:17:39.000000000 +0200 @@ -16,9 +16,8 @@ # -%define chromium_no_dlopen 1 Name: chromium -Version: 51.0.2704.106 +Version: 52.0.2743.116 Release: 0 Summary: Google's opens source browser project License: BSD-3-Clause and LGPL-2.1+ @@ -34,41 +33,34 @@ Source102: chromium-browser.xml Source103: chromium.default Source104: chromium-icons.tar.bz2 -Source997: courgette.tar.xz -Source998: depot_tools.tar.xz -Source999: gn-binaries.tar.xz ## Start Patches # PATCH-FIX-OPENSUSE Make the 1-click-install ymp file always download [bnc#836059] Patch1: exclude_ymp.diff # PATCH-FIX-OPENSUSE enables reading of the master preference -Patch4: chromium-master-prefs-path.patch -# PATCH-FIX-OPENSUSE Fix some includes specifically for the GCC version used -Patch5: chromium-gcc-fixes.patch +Patch2: chromium-master-prefs-path.patch # PATCH-FIX-UPSTREAM Add more charset aliases -Patch6: chromium-more-codec-aliases.patch +Patch3: chromium-more-codec-aliases.patch # PATCH-FIX-OPENSUSE Compile the sandbox with -fPIE settings -Patch7: chromium-sandbox-pie.patch -# PATCH-FIX-OPENSUSE Adjust ldflags for better building -Patch8: adjust-ldflags-no-keep-memory.patch -# PATCH-FIX-OPENSUSE gcc50-fixes.diff - Fix the GCC version detection -Patch10: gcc50-fixes.diff +Patch4: chromium-sandbox-pie.patch # PATCH-FIX-OPENSUSE chromium-46.0.2490.71-fix-missing-i18n_process_css_test.patch - file was removed -Patch11: chromium-46.0.2490.71-fix-missing-i18n_process_css_test.patch +Patch5: chromium-46.0.2490.71-fix-missing-i18n_process_css_test.patch # PATCH-FIX-OPENSUSE fix_building_widevinecdm_with_chromium.patch - Enable WideVine plugin -Patch12: fix_building_widevinecdm_with_chromium.patch +Patch6: fix_building_widevinecdm_with_chromium.patch # PATCH-FIX-OPENSUSE fix_network_api_crash.patch - Fix crash in network API, e.g. when using chromecast extension -Patch14: fix_network_api_crash.patch +Patch7: fix_network_api_crash.patch # PATCH-FIX-OPENSUSE gcc60-fixes.diff - Fix crashes due to the GCC6 optimizations -Patch16: gcc60-fixes.diff +Patch8: gcc60-fixes.diff # archlinux arm enhancement patches Patch100: arm-webrtc-fix.patch Patch101: chromium-arm-r0.patch -BuildRequires: SDL-devel +# GN buildsystem related patches +Patch200: chromium-last-commit-position-r0.patch +Patch201: chromium-snapshot-toolchain-r1.patch + BuildRequires: alsa-devel BuildRequires: bison BuildRequires: cups-devel BuildRequires: desktop-file-utils -BuildRequires: dirac-devel >= 1.0.0 BuildRequires: fdupes BuildRequires: flac-devel BuildRequires: flex @@ -78,43 +70,33 @@ BuildRequires: gperf BuildRequires: hicolor-icon-theme BuildRequires: hunspell-devel -BuildRequires: imlib2-devel -BuildRequires: krb5 BuildRequires: krb5-devel BuildRequires: libbz2-devel -BuildRequires: libcap-devel -BuildRequires: libdc1394 -BuildRequires: libdc1394-devel -BuildRequires: libdrm-devel +BuildRequires: pkgconfig(libffi) +BuildRequires: binutils-gold +BuildRequires: dbus-1-devel +BuildRequires: libevent-devel +BuildRequires: harfbuzz-devel +BuildRequires: libwebp-devel +BuildRequires: snappy-devel +BuildRequires: zlib-devel +BuildRequires: yasm-devel BuildRequires: libelf-devel BuildRequires: libexpat-devel +BuildRequires: libpulse-devel +BuildRequires: update-desktop-files +BuildRequires: python-xml +Requires(pre): permissions BuildRequires: libgcrypt-devel BuildRequires: libgnome-keyring-devel -BuildRequires: libgsm -BuildRequires: libgsm-devel -BuildRequires: libjack-devel -BuildRequires: libjpeg-devel -BuildRequires: libogg-devel -BuildRequires: liboil-devel >= 0.3.15 -BuildRequires: libopenssl-devel -BuildRequires: libpulse-devel -BuildRequires: libtheora-devel >= 1.1 -BuildRequires: libvdpau-devel -BuildRequires: libvorbis-devel -BuildRequires: libvpx-devel -BuildRequires: ncurses-devel +BuildRequires: libcap-devel BuildRequires: ninja BuildRequires: pam-devel BuildRequires: pciutils-devel BuildRequires: pkg-config BuildRequires: python BuildRequires: python-devel -BuildRequires: python-xml -BuildRequires: schroedinger-devel -BuildRequires: slang-devel -BuildRequires: sqlite3-devel -BuildRequires: texinfo -BuildRequires: update-desktop-files +BuildRequires: pkgconfig(sqlite3) BuildRequires: util-linux BuildRequires: valgrind-devel BuildRequires: wdiff @@ -124,9 +106,7 @@ BuildRequires: pkgconfig(gconf-2.0) BuildRequires: pkgconfig(glib-2.0) BuildRequires: pkgconfig(gtk+-2.0) -BuildRequires: pkgconfig(libcrypto) -BuildRequires: pkgconfig(libexif) -BuildRequires: pkgconfig(libffi) +BuildRequires: pkgconfig(gtk+-3.0) BuildRequires: pkgconfig(libudev) BuildRequires: pkgconfig(libxslt) BuildRequires: pkgconfig(nspr) >= 4.9.5 @@ -143,6 +123,29 @@ BuildRequires: pkgconfig(xscrnsaver) BuildRequires: pkgconfig(xt) BuildRequires: pkgconfig(xtst) +BuildRequires: libdrm-devel +BuildRequires: pkgconfig(libexif) +BuildRequires: pkgconfig(libcrypto) +BuildRequires: libdc1394 +BuildRequires: libdc1394-devel +BuildRequires: libgsm +BuildRequires: libgsm-devel +BuildRequires: libogg-devel +BuildRequires: liboil-devel >= 0.3.15 +BuildRequires: libjack-devel +BuildRequires: imlib2-devel +BuildRequires: libtheora-devel >= 1.1 +BuildRequires: libvdpau-devel +BuildRequires: libvorbis-devel +BuildRequires: libvpx-devel +BuildRequires: ncurses-devel +BuildRequires: schroedinger-devel +BuildRequires: slang-devel +BuildRequires: texinfo +BuildRequires: libopenssl-devel +BuildRequires: SDL-devel +BuildRequires: dirac-devel >= 1.0.0 +#Requirements to build a fully functional ffmpeg Requires: alsa Requires: ffmpegsumo Requires: hicolor-icon-theme @@ -236,123 +239,76 @@ %endif %prep -%setup -q -a 999 -a 998 +%setup -q + +#GN Buildsystem fixes +%patch200 -p1 +%patch201 +#Standard patches %patch1 -%patch6 +%patch2 +%patch3 %patch4 -%patch5 +%patch5 -p1 +%patch6 -p1 %patch7 -%patch8 -%if 0%{?suse_version} > 1320 -%patch10 -%endif -%patch11 -p1 -%patch12 -p1 -%patch14 %if 0%{?suse_version} > 1320 -%patch16 -p0 +%patch8 %endif -#Upstream fixes - # archlinux arm enhancements %patch100 %patch101 -export PATH="$PATH":`pwd`/depot_tools - %build -PARSED_OPT_FLAGS=`echo \'%{optflags} -D_GNU_SOURCE\' | sed "s/ /',/g" | sed "s/',/', '/g"` -#' -sed -i "s|'-O<(release_optimize)'|$PARSED_OPT_FLAGS|g" build/common.gypi - -myconf+="-Dwerror= - -Dlinux_sandbox_chrome_path=%{_libdir}/chromium/chromium - -Denable_hotwording=0 - -Duse_system_ffmpeg=0 - -Dbuild_ffmpegsumo=1 - -Duse_system_libjpeg=1 - -Dproprietary_codecs=1 - -Dremove_webcore_debug_symbols=1 - -Dlogging_like_official_build=1 - -Dlinux_fpic=1 - -Dcomponent=shared_library - -Dtoolkit_uses_gtk=0 - -Denable_pepper_cdms=1 - -Denable_webrtc=1 - -Denable_widevine=1" +# Create the configuration for GN +myconf_gn+=" is_debug=false" +myconf_gn+=" enable_nacl=false" +myconf_gn+=" proprietary_codecs=true" +myconf_gn+=" is_component_ffmpeg=true" +myconf_gn+=" use_cups=true" +myconf_gn+=" use_gconf=true" +myconf_gn+=" use_gtk3=true" +myconf_gn+=" use_kerberos=true" +myconf_gn+=" use_pulseaudio=true" +myconf_gn+=" is_clang=false" +myconf_gn+=" use_sysroot=false" +myconf_gn+=" treat_warnings_as_errors=false" +myconf_gn+=" use_allocator=\"none\"" +myconf_gn+=" fieldtrial_testing_like_official_build=true" +# Define the Chrome branding in order to get libffmpeg on packman that supports all codecs %if 0%{?packman_bs} -myconf+=" -Dffmpeg_branding=Chrome" -%endif - -myconf+=" -Ddisable_nacl=1" - -%ifarch x86_64 -myconf+=" -Dtarget_arch=x64 - -Ddisable_sse2=0" -%else -myconf+=" -Dbinutils_dir=third_party/binutils/Linux_ia32/Release/bin - -Ddisable_fatal_linker_warnings=1 - -Ddisable_sse2=1" -%endif - -%ifarch %arm -myconf+=" -Dtarget_arch=arm - -Dsysroot= - -Ddisable_nacl=1" -%endif -%ifarch armv6hl armv7hl -myconf+=" -Darm_float_abi=hard" -%endif - -myconf+=" -Dclang=0 - -Duse_sysroot=0" - -%if 0%{?chromium_no_dlopen} -myconf+=" -Duse_pulseaudio=1 - -Dlinux_link_libpci=1 - -Dlinux_link_gnome_keyring=1 - -Dlinux_link_gsettings=1 - -Dlinux_link_libgps=1" - -%ifnarch %ix86 -#myconf+=" -Dlinux_link_kerberos=1" -%endif - +myconf_gn+=" ffmpeg_branding=\"Chrome\"" %endif -%if 0%{?suse_version} > 1310 -myconf+=" -Dpython_ver=2.7" -%ifarch x86_64 -myconf+=" -Dsystem_libdir=lib64" -%endif -%endif - -myconf+=" -Djavascript_engine=v8 " - -myconf+=" -Dlinux_use_gold_binary=0 - -Dlinux_use_gold_flags=0" - # Set up Google API keys, see http://www.chromium.org/developers/how-tos/api-keys # Note: these are for the openSUSE Chromium builds ONLY. For your own distribution, # please get your own set of keys. -myconf+=" -Dgoogle_api_key=AIzaSyD1hTe85_a14kr1Ks8T3Ce75rvbR1_Dx7Q - -Dgoogle_default_client_id=4139804441.apps.googleusercontent.com - -Dgoogle_default_client_secret=KDTRKEZk2jwT_7CDpcmMA--P" +google_api_key="AIzaSyD1hTe85_a14kr1Ks8T3Ce75rvbR1_Dx7Q" +google_default_client_id="4139804441.apps.googleusercontent.com" +google_default_client_secret="KDTRKEZk2jwT_7CDpcmMA--P" + +myconf_gn+=" google_api_key=\"${google_api_key}\"" +myconf_gn+=" google_default_client_id=\"${google_default_client_id}\"" +myconf_gn+=" google_default_client_secret=\"${google_default_client_secret}\"" -build/linux/unbundle/replace_gyp_files.py $myconf -export GYP_GENERATORS='ninja' +third_party/libaddressinput/chromium/tools/update-strings.py + +if [ ! -f chrome/test/data/webui/i18n_process_css_test.html ]; then + touch chrome/test/data/webui/i18n_process_css_test.html +fi + +tools/gn/bootstrap/bootstrap.py -v --gn-gen-args "${myconf_gn}" +out/Release/gn gen --args="${myconf_gn}" out/Release %if 0%{?packman_bs} - ./build/gyp_chromium build/all.gyp --no-parallel --depth . $myconf - ninja -C out/Release ffmpeg + ninja -C out/Release third_party/ffmpeg %else - ./build/gyp_chromium build/all.gyp --depth . $myconf - ninja -C out/Release chrome + ninja -j 4 -C out/Release chrome # Build the required SUID_SANDBOX helper ninja -C out/Release chrome_sandbox @@ -362,10 +318,10 @@ %endif %install -mkdir -p %{buildroot}%{_libdir}/chromium/lib +mkdir -p %{buildroot}%{_libdir}/chromium %if 0%{?packman_bs} pushd out/Release - cp -av lib/*.so %{buildroot}%{_libdir}/chromium/lib/ + cp -av libffmpeg.so %{buildroot}%{_libdir}/chromium/ popd %else %ifarch x86_64 @@ -394,7 +350,7 @@ cp -a chrome_sandbox %{buildroot}%{_libexecdir}/ ln -s -f %{_libexecdir}/chrome_sandbox %{buildroot}/%{_libdir}/chromium/chrome-sandbox - cp -a *.pak locales xdg-mime icudtl.dat %{buildroot}%{_libdir}/chromium/ + cp -a *.bin *.pak locales xdg-mime icudtl.dat %{buildroot}%{_libdir}/chromium/ cp -a chromedriver %{buildroot}%{_libdir}/chromium/ # Patch xdg-settings to use the chromium version of xdg-mime as that the system one is not KDE4 compatible @@ -404,12 +360,10 @@ cp -a chrome %{buildroot}%{_libdir}/chromium/chromium cp -a chrome.1 %{buildroot}%{_mandir}/man1/chrome.1 cp -a chrome.1 %{buildroot}%{_mandir}/man1/chromium.1 - cp -a *_blob.bin %{buildroot}%{_libdir}/chromium/ %fdupes %{buildroot}%{_mandir}/man1/ # chromium components - mkdir -p %{buildroot}%{_libdir}/chromium/lib/ - cp -av lib/*.so %{buildroot}%{_libdir}/chromium/lib/ + cp -av libffmpeg.so %{buildroot}%{_libdir}/chromium/ popd @@ -459,6 +413,7 @@ %desktop_database_post update-alternatives --install %{_bindir}/chromium chromium %{_libdir}/chromium/chromium-generic 10 %set_permissions %{_libexecdir}/chrome_sandbox +/sbin/ldconfig %{_libdir}/chromium %postun %icon_theme_cache_postun @@ -466,6 +421,7 @@ if [ $1 -eq 0 ]; then update-alternatives --remove chromium %{_libdir}/chromium/chromium-generic fi +/sbin/ldconfig %{_libdir}/chromium %post desktop-kde update-alternatives --install %{_bindir}/chromium chromium %{_libdir}/chromium/chromium-kde 15 @@ -487,11 +443,17 @@ # Files! %if 0%{?packman_bs} + +%post ffmpeg +/sbin/ldconfig %{_libdir}/chromium + +%postun ffmpeg +/sbin/ldconfig %{_libdir}/chromium + %files ffmpeg %defattr(-,root,root,-) %dir %{_libdir}/chromium -%dir %{_libdir}/chromium/lib -%{_libdir}/chromium/lib/libffmpeg.so +%{_libdir}/chromium/libffmpeg.so %else %files @@ -508,7 +470,7 @@ %{_datadir}/gnome-control-center/default-apps/chromium-browser.xml %{_datadir}/icons/hicolor/ %{_libexecdir}/chrome_sandbox -%exclude %{_libdir}/chromium/lib/*ffmpeg*.so +%exclude %{_libdir}/chromium/libffmpeg.so %exclude %{_libdir}/chromium/chromium-kde %exclude %{_libdir}/chromium/chromium-gnome %exclude %{_libdir}/chromium/chromedriver @@ -517,7 +479,7 @@ %files ffmpegsumo %defattr(-,root,root,-) -%{_libdir}/chromium/lib/*ffmpeg*.so +%{_libdir}/chromium/libffmpeg.so %files desktop-kde %defattr(-,root,root) ++++++ chromium-51.0.2704.106.tar.xz -> chromium-52.0.2743.116.tar.xz ++++++ /work/SRC/openSUSE:Factory/chromium/chromium-51.0.2704.106.tar.xz /work/SRC/openSUSE:Factory/.chromium.new/chromium-52.0.2743.116.tar.xz differ: char 26, line 1 ++++++ chromium-last-commit-position-r0.patch ++++++ --- a/tools/gn/gn_main.cc 2015-11-12 11:49:56.260549036 +0000 +++ b/tools/gn/gn_main.cc 2015-11-12 11:50:14.780931485 +0000 @@ -12,13 +12,7 @@ #include "tools/gn/standard_out.h" #include "tools/gn/switches.h" -// Only the GN-generated build makes this header for now. -// TODO(brettw) consider adding this if we need it in GYP. -#if defined(GN_BUILD) -#include "tools/gn/last_commit_position.h" -#else #define LAST_COMMIT_POSITION "UNKNOWN" -#endif namespace { --- a/tools/gn/BUILD.gn 2015-11-12 11:50:43.513524769 +0000 +++ b/tools/gn/BUILD.gn 2015-11-12 11:50:57.697817632 +0000 @@ -263,7 +263,6 @@ deps = [ ":gn_lib", - ":last_commit_position", "//base", "//build/config/sanitizers:deps", "//build/win:default_exe_manifest", ++++++ chromium-sandbox-pie.patch ++++++ --- /var/tmp/diff_new_pack.kOyKfT/_old 2016-08-24 10:17:39.000000000 +0200 +++ /var/tmp/diff_new_pack.kOyKfT/_new 2016-08-24 10:17:39.000000000 +0200 @@ -1,14 +1,22 @@ ---- sandbox/linux/sandbox_linux.gypi 2011-11-15 19:35:11.119851877 +0100 -+++ sandbox/linux/sandbox_linux.gypi 2012-01-25 23:24:53.914568688 +0100 -@@ -85,7 +85,10 @@ - ], - 'cflags': [ - # For ULLONG_MAX -- '-std=gnu99', -+ '-std=gnu99 -fPIE', -+ ], -+ 'ldflags': [ -+ '-pie', - ], - 'include_dirs': [ - '../..', +--- sandbox/linux/BUILD.gn 2016-08-03 06:31:07.000000000 +0200 ++++ sandbox/linux/BUILD.gn 2016-08-03 06:31:07.000000000 +0200 +@@ -297,12 +297,17 @@ + + cflags = [ + # For ULLONG_MAX +- "-std=gnu99", ++ "-std=gnu99", ++ "-fPIE", + + # These files have a suspicious comparison. + # TODO fix this and re-enable this warning. + "-Wno-sign-compare", + ] ++ ++ ldflags = [ ++ "-pie", ++ ] + + deps = [ + "//build/config/sanitizers:deps", + ++++++ chromium-snapshot-toolchain-r1.patch ++++++ --- v8/snapshot_toolchain.gni.orig 2016-01-07 15:47:46.772435180 +0000 +++ v8/snapshot_toolchain.gni 2016-01-07 15:48:06.144841801 +0000 @@ -28,19 +28,4 @@ # The snapshot needs to be compiled for the host, but compiled with # a toolchain that matches the bit-width of the target. -# TODO(GYP): For now we only support 32-bit little-endian target builds from an -# x64 Linux host. Eventually we need to support all of the host/target -# configurations v8 runs on. -if (host_cpu == "x64" && host_os == "linux") { - if (target_cpu == "arm" || target_cpu == "mipsel" || target_cpu == "x86") { - snapshot_toolchain = "//build/toolchain/linux:clang_x86" - } else if (target_cpu == "x64" || target_cpu == "arm64" || target_cpu == "mips64el") { - snapshot_toolchain = "//build/toolchain/linux:clang_x64" - } else { - assert(false, "Need environment for this arch: $target_cpu") - } -} else { - snapshot_toolchain = default_toolchain -} - - +snapshot_toolchain = default_toolchain ++++++ fix_network_api_crash.patch ++++++ --- /var/tmp/diff_new_pack.kOyKfT/_old 2016-08-24 10:17:39.000000000 +0200 +++ /var/tmp/diff_new_pack.kOyKfT/_new 2016-08-24 10:17:39.000000000 +0200 @@ -1,7 +1,9 @@ ---- extensions/browser/api/networking_private/networking_private_linux.cc_ 2015-12-26 20:26:42.386838036 +0100 -+++ extensions/browser/api/networking_private/networking_private_linux.cc 2015-12-27 02:15:56.848713761 +0100 -@@ -215,12 +215,14 @@ - scoped_ptr<base::DictionaryValue> network_properties( +Index: extensions/browser/api/networking_private/networking_private_linux.cc +=================================================================== +--- extensions/browser/api/networking_private/networking_private_linux.cc.orig 2016-05-05 03:01:50.000000000 +0200 ++++ extensions/browser/api/networking_private/networking_private_linux.cc 2016-05-10 16:16:42.431052917 +0200 +@@ -215,12 +215,14 @@ void NetworkingPrivateLinux::GetState( + std::unique_ptr<base::DictionaryValue> network_properties( new base::DictionaryValue); + std::string* erp = error.get(); @@ -17,7 +19,7 @@ base::Bind(&GetCachedNetworkPropertiesCallback, base::Passed(&error), base::Passed(&network_properties), success_callback, failure_callback)); -@@ -301,11 +303,12 @@ +@@ -301,11 +303,12 @@ void NetworkingPrivateLinux::GetNetworks // Runs GetAllWiFiAccessPoints on the dbus_thread and returns the // results back to OnAccessPointsFound where the callback is fired. @@ -31,7 +33,7 @@ base::Bind(&NetworkingPrivateLinux::OnAccessPointsFound, base::Unretained(this), base::Passed(&network_map), success_callback, failure_callback)); -@@ -321,11 +324,12 @@ +@@ -321,11 +324,12 @@ bool NetworkingPrivateLinux::GetNetworks // Runs GetAllWiFiAccessPoints on the dbus_thread and returns the // results back to SendNetworkListChangedEvent to fire the event. No // callbacks are used in this case. @@ -45,9 +47,9 @@ base::Bind(&NetworkingPrivateLinux::OnAccessPointsFoundViaScan, base::Unretained(this), base::Passed(&network_map))); -@@ -506,11 +510,12 @@ +@@ -506,11 +510,12 @@ void NetworkingPrivateLinux::StartConnec - scoped_ptr<std::string> error(new std::string); + std::unique_ptr<std::string> error(new std::string); + std::string* erp = error.get(); // Runs ConnectToNetwork on |dbus_thread|. @@ -59,9 +61,9 @@ base::Bind(&OnNetworkConnectOperationCompleted, base::Passed(&error), success_callback, failure_callback)); } -@@ -524,11 +529,12 @@ +@@ -524,11 +529,12 @@ void NetworkingPrivateLinux::StartDiscon - scoped_ptr<std::string> error(new std::string); + std::unique_ptr<std::string> error(new std::string); + std::string* erp = error.get(); // Runs DisconnectFromNetwork on |dbus_thread|.
