On Fri, Aug 18, 2006 at 03:06:51PM +0200, Christoph Thiel wrote: > On Fri, 18 Aug 2006, Andreas Hanke wrote: > > > > To achieve the same, while getting rid of SuSEconfig.automake, I'd > > > like to propose to move the above-named script to %postinstall / > > > %postuninstall of gnome-filesystem and automake. > > > > > > Comments, criticism, better ideas? > > > > Not a "better" idea, just an alternative one: Patch aclocal to read the > > /usr/share/aclocal/dirlist.d/* files directly. > > > > Is that possible? The advantage is that people can still easily add more > > directories without knowing any details about what %post scripts to use. > > > > Maybe such a patch could even be pushed upstream because it really makes > > sense generally (IMHO). > > It might make sense -- however, /usr/share/aclocal/dirlist.d/* is a > SUSE-only thingy, IIUC. Stock automake only uses > /usr/share/aclocal/dirlist, which is a symlink to /etc/aclocal_dirlist on > SUSE.
Then stock automake should be enhanced here because having such *.d config
directories is a _big_ help for packaging.
Feel free to forward the following patch upstream and reference to me for
further discussions.
> Do you have a patch to extend automake? ;)
That's an easy one:
--- ./aclocal.in~ 2006-08-18 20:14:43.000000000 +0200
+++ ./aclocal.in 2006-08-18 20:17:03.000000000 +0200
@@ -645,22 +645,25 @@
push (@dirlist, $acdir)
unless $acdir eq $default_acdir && ! -d $acdir;
- # Finally, adds any directory listed in the `dirlist' file.
- if (open (DEFAULT_DIRLIST, $default_dirlist))
+ # Finally, adds any directory listed in the `dirlist' files.
+ foreach my $dirlistfile (<${default_dirlist}{,.d/*}>)
{
- while (<DEFAULT_DIRLIST>)
+ if (open (DEFAULT_DIRLIST, $dirlistfile))
{
- # Ignore '#' lines.
- next if /^#/;
- # strip off newlines and end-of-line comments
- s/\s*\#.*$//;
- chomp ($contents=$_);
- if (-d $contents )
+ while (<DEFAULT_DIRLIST>)
{
- push (@dirlist, $contents);
+ # Ignore '#' lines.
+ next if /^#/;
+ # strip off newlines and end-of-line comments
+ s/\s*\#.*$//;
+ chomp ($contents=$_);
+ if (-d $contents )
+ {
+ push (@dirlist, $contents);
+ }
}
+ close (DEFAULT_DIRLIST);
}
- close (DEFAULT_DIRLIST);
}
return @dirlist;
Further comments or suggestions welcome.
Robert
--
Robert Schiele Tel.: +49-621-181-2214
Dipl.-Wirtsch.informatiker mailto:[EMAIL PROTECTED]
"Quidquid latine dictum sit, altum sonatur."
pgpr7IKSKMisX.pgp
Description: PGP signature
