Hi,
> How is a fix "temporary" ? As long as it isn't fixed upstream, a patch
> is necessary, doesn't matter whether it's for the build system or for
> real sources.
A "tempfix" might be a fix that works around a bug in another package and will
be dropped as soon as the other package is fixed, but cannot be sent upstream
because it's not upstream's problem. For example, a workaround for a
miscompilation.
> Some RPM macros are applied regardless of whether they're commented out
> or now. Are you 100% sure that #%patch will not be applied ?
> I've seen pretty weird stuff with that.
Only macros that expand to multiple lines are affected by this problem. %patch
expands to a single line, so just adding a # sign at the beginning of the line
is safe for %patch.
> I'd suggest changing %patch2 to #patch2 instead of #%patch2 (unless, of
> course, you're sure no RPM 4.x version will apply #%patch2)
The correct thing in such a case is to duplicate the % sign.
For example, %suse_update_desktop_file is a macro that expands to multiple
lines. This means that
#%suse_update_desktop_file
does not work. But
%%suse_update_desktop_file
works. Nothing we need to worry about when using %patch.
Andreas Hanke
--
Bis zu 70% Ihrer Onlinekosten sparen: GMX SmartSurfer!
Kostenlos downloaden: http://www.gmx.net/de/go/smartsurfer
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
