Re: [opensuse] Adding http repositories doesn't work

[Martin Oberzalek]

Am Dienstag, 23. Oktober 2007 02:24:12 schrieb Martin Oberzalek:
> Am Dienstag, 23. Oktober 2007 01:49:00 schrieb Carlos E. R.:
> > The Tuesday 2007-10-23 at 00:00 +0200, Martin Oberzalek wrote:
> > > the One click install feature would by nice to use, but it doesn't work
> > > for me. I can't add a http repository. FTP works well.
> > >
> > > The reopsitory is accessable. I can donwload the file with firefox and
> > > wget without any problem. Any suggestions?
> >
> > Server error.
> >
> > > 2007-10-22 23:51:40 <1> BIGAthlon(17002) [zypp]
> > > MediaHandler.cc(attach):653 Attached:
> > > http://download.opensuse.org/repositories/X11:/XGL/openSUSE_10.3/
> > > attached; localRoot "/var/adm/mount/AP_0x00000004" 2007-10-22 23:52:09
> > > <1> BIGAthlon(17002) [zypp] MediaCurl.cc(doGetDoesFileExist):931
> > > perform code: 52 [ server returned nothing (no headers, no data) ]
> >
> > Remember that http://download.opensuse.org/ is a redirector, and it may
> > happen that the actual server you get doesn't work that moment. Try
> > setting a static server instead.
>
> Don't think so, because it always fails and never worked. And I can access
> the file with the curl command line client too. I built a little
> testprogram that tries accessing the file vial curl: Works well.
>
> So I guess I'm triggering here a bug in libzypp :-(

So, I fixed the Bug now.

diff -r -u libzypp-3.26.3/zypp/media/MediaCurl.cc 
libzypp-3.26.3-kingleo/zypp/media/MediaCurl.cc
--- libzypp-3.26.3/zypp/media/MediaCurl.cc      2007-10-12 15:10:58.000000000 
+0200
+++ libzypp-3.26.3-kingleo/zypp/media/MediaCurl.cc      2007-10-24 
23:13:49.000000000 +0200
@@ -894,11 +894,12 @@
   // little data, that works with broken servers, and
   // works for ftp as well, because retrieving only headers
   // ftp will return always OK code ?
+#if 0
   ret = curl_easy_setopt( _curl, CURLOPT_RANGE, "0-1" );
   if ( ret != 0 ) {
       ZYPP_THROW(MediaCurlSetOptException(url, _curlError));
   }
-
+#endif
   FILE *file = ::fopen( "/dev/null", "w" );
   if ( !file ) {
       ::fclose(file);

Greetings, Martin.

diff -r -u libzypp-3.26.3/zypp/media/MediaCurl.cc libzypp-3.26.3-kingleo/zypp/media/MediaCurl.cc
--- libzypp-3.26.3/zypp/media/MediaCurl.cc	2007-10-12 15:10:58.000000000 +0200
+++ libzypp-3.26.3-kingleo/zypp/media/MediaCurl.cc	2007-10-24 23:13:49.000000000 +0200
@@ -894,11 +894,12 @@
   // little data, that works with broken servers, and
   // works for ftp as well, because retrieving only headers
   // ftp will return always OK code ?
+#if 0
   ret = curl_easy_setopt( _curl, CURLOPT_RANGE, "0-1" );
   if ( ret != 0 ) {
       ZYPP_THROW(MediaCurlSetOptException(url, _curlError));
   }
-
+#endif
   FILE *file = ::fopen( "/dev/null", "w" );
   if ( !file ) {
       ::fclose(file);