I'm also -1 on this.

You can make an action that wraps an object if you want (and you can do this in 1.3), but having an action is important IMHO.

Cheers,
Scott

Matt Ho wrote:
-1

I think one of the challenges when developing a good system is deciding
what its boundaries should be.  I think WebWork makes an amazing command
pattern framework and has the potential to be widely adopted because
it's easy to grok.

Here are my primary issues against this:

* The Action interface provides runtime checking and allows for a design
by contract paradigm.  Not only does this prevent the "execut" problem
that Patrick mentioned, but it also provides an excellent ground for new
developers trying to understand the system.

* It's a halfway solution.  The existing solution defines (a) a well
understood paradigm, the command pattern, along with (b) the method
signature.  The proposed solution does not require any particular
paradigm, but does require a partial method signature, void ...()   If
arbitrary method invocation is the way to go, I would suggest allowing
the entire method signature to be reworked.

* cost/benefit ratio is poor.  The amount of conceptual and
configuration complexity being added doesn't seem to justify the benefit
I get by being able to invoke arbitrary commands.  I think this gets to
my next point ...

* diffuses xwork's focus.  XWork is a generic command pattern framework,
and shaping up to be a great one at that.  If I wanted a generic aspect
framework for POJO, I'd wait for JBoss4.  If I needed one now, I'd use
BCEL or nanning.  I feel one of XWork's strengths is that it focuses on
doing one thing and doing that thing well.

Having said all that, I would be more than happy to volunteer to write
an interceptor that would allow execution of arbitrary methods.  That
way, anyone who wanted to execute arbitrary methods could and we
wouldn't need to modify the xwork core.

Cheers!

--
Matt Ho
Principal
Indigo Egg, Inc.
http://www.indigoegg.com/



-----Original Message-----
From: [EMAIL PROTECTED]
[mailto:[EMAIL PROTECTED]] On Behalf Of
Patrick Lightbody
Sent: Wednesday, February 19, 2003 2:38 PM
To: [EMAIL PROTECTED]
Subject: Re: [OS-webwork] Proposal: Removing the Action Interface

My only concern would be the fact that there is no more interface
could

result in people doing "public String execut()" or some other
mispelling.

Also, what if a method doesn't return a String? How will we handle
results

now? As of right now I'm like -1/2, but if the above situations can be
addressed, I'll switch to +1/2 I guess :)

-Pat

----- Original Message -----
From: "Jason Carreira" <[EMAIL PROTECTED]>
To: <[EMAIL PROTECTED]>
Sent: Wednesday, February 19, 2003 2:33 PM
Subject: [OS-webwork] Proposal: Removing the Action Interface



Based on the idea earlier of setting the method to execute for
commands

and making the default alias use the "execute()" method, thereby
making

the Action Interface unneeded, I'm proposing to remove the Action
Interface from Xwork 1.0 / Webwork 2.0 and allowing any object to be
used.

If no-one has any objections, I'll be doing this.

Jason

--
Jason Carreira
Technical Architect, Notiva Corp.
phone: 585.240.2793
 fax: 585.272.8118
email: [EMAIL PROTECTED]
---
Notiva - optimizing trade relationships (tm)



-------------------------------------------------------
This SF.net email is sponsored by: SlickEdit Inc. Develop an edge.
The most comprehensive and flexible code editor you can use.
Code faster. C/C++, C#, Java, HTML, XML, many more. FREE 30-Day
Trial.

www.slickedit.com/sourceforge
_______________________________________________
Opensymphony-webwork mailing list
[EMAIL PROTECTED]
https://lists.sourceforge.net/lists/listinfo/opensymphony-webwork


-------------------------------------------------------
This SF.net email is sponsored by: SlickEdit Inc. Develop an edge.
The most comprehensive and flexible code editor you can use.
Code faster. C/C++, C#, Java, HTML, XML, many more. FREE 30-Day Trial.
www.slickedit.com/sourceforge
_______________________________________________
Opensymphony-webwork mailing list
[EMAIL PROTECTED]
https://lists.sourceforge.net/lists/listinfo/opensymphony-webwork




-------------------------------------------------------
This SF.net email is sponsored by: SlickEdit Inc. Develop an edge.
The most comprehensive and flexible code editor you can use.
Code faster. C/C++, C#, Java, HTML, XML, many more. FREE 30-Day Trial.
www.slickedit.com/sourceforge
_______________________________________________
Opensymphony-webwork mailing list
[EMAIL PROTECTED]
https://lists.sourceforge.net/lists/listinfo/opensymphony-webwork

--

ATLASSIAN - http://www.atlassian.com
Expert J2EE Software, Services and Support
-------------------------------------------------------
Need a simple, powerful way to track and manage issues?
Try JIRA - http://www.atlassian.com/software/jira



-------------------------------------------------------
This SF.net email is sponsored by: SlickEdit Inc. Develop an edge.
The most comprehensive and flexible code editor you can use.
Code faster. C/C++, C#, Java, HTML, XML, many more. FREE 30-Day Trial.
www.slickedit.com/sourceforge
_______________________________________________
Opensymphony-webwork mailing list
[EMAIL PROTECTED]
https://lists.sourceforge.net/lists/listinfo/opensymphony-webwork

Reply via email to