Message:

  A new issue has been created in JIRA.

---------------------------------------------------------------------
View the issue:

  http://jira.opensymphony.com/secure/ViewIssue.jspa?key=XW-52


Here is an overview of the issue:
---------------------------------------------------------------------
        Key: XW-52
    Summary: buildValidators doesn't  look for validators for every super class
       Type: Bug

     Status: Assigned
   Priority: Major

    Project: XWork
 Components: 
             Validators
   Versions:
             1.0

   Assignee: Patrick Lightbody
   Reporter: Vincent Faidherbe

    Created: Tue, 10 Jun 2003 11:06 AM
    Updated: Tue, 10 Jun 2003 11:06 AM

Description:
ActionValidatorManager.buildValidators doesn't traverse up the class hierarchy looking 
for validators for every super class. It only get the validator for the superclass.

The current code is :
...
if (!actionClass.getSuperclass().equals(Object.class)) {
    validators.addAll(buildClassValidators(actionClass.getSuperclass(), checkFile));
}

validators.addAll(buildClassValidators(actionClass, checkFile));
validators.addAll(buildAliasValidators(actionClass, invocation, checkFile));
...

I think the code should look more like this :
...
Class actionClass = invocation.getAction().getClass();

// validators for the action class
validators.addAll(buildClassValidators(actionClass, checkFile));
validators.addAll(buildAliasValidators(actionClass, invocation, checkFile));

// looking for validators for every super class
actionClass = actionClass.getSuperclass();
while (!actionClass.equals(Object.class)) {
    validators.addAll(buildClassValidators(actionClass, checkFile));
    actionClass = actionClass.getSuperclass();
}
...







---------------------------------------------------------------------
JIRA INFORMATION:
This message is automatically generated by JIRA.

If you think it was sent incorrectly contact one of the administrators:
   http://jira.opensymphony.com/Administrators.jspa

If you want more information on JIRA, or have a bug to report see:
   http://www.atlassian.com/software/jira



-------------------------------------------------------
This SF.net email is sponsored by:  Etnus, makers of TotalView, The best
thread debugger on the planet. Designed with thread debugging features
you've never dreamed of, try TotalView 6 free at www.etnus.com.
_______________________________________________
Opensymphony-webwork mailing list
[EMAIL PROTECTED]
https://lists.sourceforge.net/lists/listinfo/opensymphony-webwork

Reply via email to