Hi Sean, You may want to give http://cvsgrab.sourceforge.net a try for getting through firewall.
cheers, /bernard ----- Original Message ----- From: "garrett.sean" <[EMAIL PROTECTED]> To: <[EMAIL PROTECTED]> Sent: Wednesday, June 11, 2003 8:34 PM Subject: RE: [OS-webwork] Re: shouldn't VelocityResult set charset in content-type? Hi I'm encountering the bug mentioned in http://sourceforge.net/mailarchive/message.php?msg_id=4501787 But this seems to have been checked into CVS after the ww-1.3.0 tar ball / zip available in the files section. My companies firewall prevents me accessing external CVS repositories. Is there a nightly build available that I can download with this fix in it ? Thanks --- Sean Garrett Web Developer Hirt & Carter Cape Town, South Africa -----Original Message----- From: Fernando Martins [mailto:[EMAIL PROTECTED] Sent: Wednesday, June 11, 2003 1:51 PM To: [EMAIL PROTECTED] Subject: [OS-webwork] Re: shouldn't VelocityResult set charset in content-type? Now that there is a velocity.properties configuration loading mechanism, could someone please add the below changes to CVS so that I don't have to change it everytime I update. And then, mark http://jira.opensymphony.com/secure/ViewIssue.jspa?key=WW-200 as resolved. Thanks Fernando Martins wrote: > > In line 76 of VelocityResult there is: > > response.setContentType("text/html"); > > this doesn't account for different charsets that should be in > content-type if encoding being used is other than ISO-8859-1. > > in org.apache.velocity.Template there is method getEncoding() which I > think should be used here to set the charset of content-type i.e.: > > response.setContentType("text/html; charset="+t.getEncoding()); > > This way, it will set content-type with the encoding velocity is > configured with (in velocity.properties encoding can be specified. How > to get velocity to read those properties is another story. In my case > I tried velocity-1.4-dev from CVS and it reads the properties file). > > You can argue that if I want diferent encoding in my pages I should > use > html: > > <meta http-equiv="Content-type" > content="text/html;charset=iso-8859-2"> > > That works in normal cases, but if I need to compress the pages with > Gzip > (Content-Encoding: gzip) browsers will just not pay attention to meta and > will set the encoding to what is in Content-Type. That's why I need it to > have the correct encoding in Content-Type. > > Am I missing something obvious here? > > Thanks > Fernando > > > > ------------------------------------------------------- > This SF.net email is sponsored by: eBay > Get office equipment for less on eBay! > http://adfarm.mediaplex.com/ad/ck/711-11697-6916-5 > _______________________________________________ > Opensymphony-webwork mailing list > [EMAIL PROTECTED] > https://lists.sourceforge.net/lists/listinfo/opensymphony-webwork -- Fernando Martins <[EMAIL PROTECTED]> FilmWeb.pl - http://www.filmweb.pl/ --------------------------------------------------------------------- FilmWeb.pl tel: +48 22 646 646 5 ul. Goszczynskiego 10, 02-616 Warsaw, Poland ------------------------------------------------------- This SF.net email is sponsored by: Etnus, makers of TotalView, The best thread debugger on the planet. Designed with thread debugging features you've never dreamed of, try TotalView 6 free at www.etnus.com. _______________________________________________ Opensymphony-webwork mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/opensymphony-webwork ------------------------------------------------------- This SF.net email is sponsored by: Etnus, makers of TotalView, The best thread debugger on the planet. Designed with thread debugging features you've never dreamed of, try TotalView 6 free at www.etnus.com. _______________________________________________ Opensymphony-webwork mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/opensymphony-webwork ------------------------------------------------------- This SF.net email is sponsored by: Etnus, makers of TotalView, The best thread debugger on the planet. Designed with thread debugging features you've never dreamed of, try TotalView 6 free at www.etnus.com. _______________________________________________ Opensymphony-webwork mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/opensymphony-webwork
