M
Jason Carreira wrote:
While we're bringing up controversial topics....
A while back Mike refactored ActionSupport to have a parent class, BaseActionSupport, that does most of the work, and put the old workflow stuff into ActionSupport:
public String execute() throws Exception { doValidation();
if (hasErrors()) { return INPUT; }
return doExecute(); }
I would like to undo this, pull the implementation stuff up into
ActionSupport, get rid of the workflow and BaseActionSupport, and create
a DefaultWorkflowInterceptor which will call validate() on the Action if
it implements an Interface, then check for errors like above and return
INPUT without forwarding to the rest of the interceptor stack if it has
errors, or forward to the rest of the interceptor stack if it does....
Probably you'd want to put this as the last interceptor in your stack,
so forwarding would just call the Action.
I know I've talked with Pat about this, and we both hated the default behavior that would return for you without calling your action, but at least this way it would be optional (apply the interceptor or not) and you'd be making a conscious decision, so you'd know what was happening.
Thoughts?
Jason
--
Jason Carreira
Technical Architect, Notiva Corp.
phone: 585.240.2793
fax: 585.272.8118
email: [EMAIL PROTECTED]
---
Notiva - optimizing trade relationships (tm)
------------------------------------------------------- This SF.Net email sponsored by: Free pre-built ASP.NET sites including Data Reports, E-commerce, Portals, and Forums are available now. Download today and enter to win an XBOX or Visual Studio .NET. http://aspnet.click-url.com/go/psa00100006ave/direct;at.asp_061203_01/01 _______________________________________________ Opensymphony-webwork mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/opensymphony-webwork
------------------------------------------------------- This SF.Net email sponsored by: Free pre-built ASP.NET sites including Data Reports, E-commerce, Portals, and Forums are available now. Download today and enter to win an XBOX or Visual Studio .NET. http://aspnet.click-url.com/go/psa00100006ave/direct;at.asp_061203_01/01 _______________________________________________ Opensymphony-webwork mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/opensymphony-webwork
