OK - but I don't see (at a glance) how this is done in an interceptor? It surely needs a base class, to call the 3 methods in the right order?
M On 3/7/03 7:26 AM, "Jason Carreira" ([EMAIL PROTECTED]) penned the words: > I think you misunderstood... I don't want to remove it, per se, I want > to pull it into an Interceptor. I don't want my ActionSupport to do > ANYTHING. It's just there to provide support methods like i18n and error > messages. Workflow, etc belongs in an Interceptor which can be applied > or not. That way I can apply it to my Actions even if they need to > extend something besides ActionSupport. > > Also, the doValidation, doExecute, etc are ugly... This way it would > still be execute() (or whatever :-))... > > We could also add a Validateable interface and an > ActionValidatorInterceptor which would call action.validate() if it > implemented Validateable, and you could put this in front of the > Workflow Interceptor. > > I'm for decoupled pieces you can put together to get the behavior you > want. > > Jason > >> -----Original Message----- >> From: Mike Cannon-Brookes [mailto:[EMAIL PROTECTED] >> Sent: Wednesday, July 02, 2003 5:10 PM >> To: [EMAIL PROTECTED] >> Subject: Re: [OS-webwork] Default workflow >> >> >> OK - I'll say again - it IS optional AND explicit :) >> >> (One way to make it more explicit is make execute() final in AS?) >> >> If you don't want 3 phase action support (for want of a >> better name) - use BaseActionSupport - which provides error >> messages and i18n. >> >> If you DO want it, use ActionSupport - which subclasses the >> above and provides a doValidation, doDefault, doExecute cycle. >> >> It _also_ provides backward compatibility (damn I sound like >> Hani here!) which is a good thing as there is no real need to >> break it unnecessarily? >> >> I maintain that 95% of web actions are neatest when done with >> 3-phase support - it's what we use most in almost all our >> apps! Are we just that different to the rest of the world? >> How do y'all do it? (Maybe that will help me come to terms >> with removing it) >> >> M >> >> On 3/7/03 6:07 AM, "Jason Carreira" >> ([EMAIL PROTECTED]) penned the >> words: >> >>> >>> >>>> -----Original Message----- >>>> From: Erik Hatcher [mailto:[EMAIL PROTECTED] >>>> Sent: Wednesday, July 02, 2003 3:53 PM >>>> To: [EMAIL PROTECTED] >>>> Subject: Re: [OS-webwork] Default workflow >>>> >>>>> Sounds great! I was going to suggest something similar with the >>>> ValidationInterceptor. It was confusing that it called >> execute() (to >>>> me, coming from a Struts experience) when validations >> failed... and >>>> then I found ActionSupport that took care of it. >>>> >>>> I'd prefer the validation automatically go back to INPUT, >> so if this >>>> isn't going to be available in a built-in interceptor I'd >> roll my own >>>> probably. >>>> >>>> This may be completely out of line with what you're talking about, >>>> just sharing my thoughts/confusion on ValidationInterceptor. >>>> >>>> Erik >>>> >>> >>> The idea is just to make it optional and explicit... There >> have been a >>> lot of people confused (repeatedly) about getting "input" returned >>> without it even hitting your action... Especially if you're >> not even >>> return "input" anywhere in your code and you didn't map a >> page for it! >>> I must say I've fallen victim to this myself, so making >> this explicit >>> should make you have to think about it. >>> >>> Jason >>> >>> >>> ------------------------------------------------------- >>> This SF.Net email sponsored by: Free pre-built ASP.NET >> sites including >>> Data Reports, E-commerce, Portals, and Forums are available now. >>> Download today and enter to win an XBOX or Visual Studio .NET. >>> >> http://aspnet.click-> > url.com/go/psa00100006ave/direct;at.asp_061203_01/ >>> 01 >>> _______________________________________________ >>> Opensymphony-webwork mailing list >>> [EMAIL PROTECTED] >>> https://lists.sourceforge.net/lists/listinfo/opensymphony-webwork >> >> >> >> ------------------------------------------------------- >> This SF.Net email sponsored by: Free pre-built ASP.NET sites >> including Data Reports, E-commerce, Portals, and Forums are >> available now. Download today and enter to win an XBOX or >> Visual Studio .NET. >> http://aspnet.click-url.com/go/psa00100006ave/direct;at.asp_06 > 1203_01/01 > _______________________________________________ > Opensymphony-webwork mailing list > [EMAIL PROTECTED] > https://lists.sourceforge.net/lists/listinfo/opensymphony-webwork > > > ------------------------------------------------------- > This SF.Net email sponsored by: Free pre-built ASP.NET sites including > Data Reports, E-commerce, Portals, and Forums are available now. > Download today and enter to win an XBOX or Visual Studio .NET. > http://aspnet.click-url.com/go/psa00100006ave/direct;at.asp_061203_01/01 > _______________________________________________ > Opensymphony-webwork mailing list > [EMAIL PROTECTED] > https://lists.sourceforge.net/lists/listinfo/opensymphony-webwork ------------------------------------------------------- This SF.Net email sponsored by: Free pre-built ASP.NET sites including Data Reports, E-commerce, Portals, and Forums are available now. Download today and enter to win an XBOX or Visual Studio .NET. http://aspnet.click-url.com/go/psa00100006ave/direct;at.asp_061203_01/01 _______________________________________________ Opensymphony-webwork mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/opensymphony-webwork
