On Saturday 01 March 2008 17:23, [EMAIL PROTECTED] wrote:
> Author: lmwangi
> Date: 2008-03-01 17:23:49 +0100 (Sat, 01 Mar 2008)
> New Revision: 694
>
> Modified:
>    trunk/openvas-libraries/libopenvas/proctitle.c
>    trunk/openvas-libraries/libopenvas/store.c
> Log:
> Flawfinder fixes on str family of functions
>
> Modified: trunk/openvas-libraries/libopenvas/proctitle.c
> ===================================================================
> --- trunk/openvas-libraries/libopenvas/proctitle.c    2008-02-29 22:43:58 UTC
> (rev 693) +++ trunk/openvas-libraries/libopenvas/proctitle.c  2008-03-01
> 16:23:49 UTC (rev 694) @@ -31,7 +31,7 @@
>       environ = (char **) emalloc((sizeof (char *) * (i + 1))+envpsize+1);
>       s = ((char *)environ)+((sizeof (char *) * (i + 1)));
>       for (i = 0; envp[i] != NULL; i++){
> -             strcpy(s,envp[i]);
> +             strncpy(s,envp[i],strlen(envp[i]));

shouldn't in general the length of the destination be the limiting factor?

-- 
Dr. Jan-Oliver Wagner                                   Intevation GmbH
Amtsgericht Osnabrück, HR B 18998             http://www.intevation.de/
Geschäftsführer: Frank Koormann, Bernhard Reiter, Dr. Jan-Oliver Wagner
_______________________________________________
Openvas-devel mailing list
[email protected]
http://lists.wald.intevation.org/mailman/listinfo/openvas-devel

Reply via email to