On Mittwoch, 30. April 2008, Tim Brown wrote:
> I've written a preliminary patch to add support for the script_oid function.
> It doesn't yet have any dependancy support nor does it have anyway to
> override the script_id function, but it is a start. Can someone test it as
> is and see if there are any obvious things I've missed given the limited
> scope of functionality so far. If anyone wants to build some .nasl test
> cases for it, that might be useful too. For now, OIDs are held as strings
> with a maximum length of 1024 bytes but it shouldn't be a problem to increase
> their size if this proves to a be a problem.
your patch looks OK to me.
Except for tree_cell* script_oid(lex_ctxt * lexic)
where it probaly should be plug_set_*o*id()
1024 sounds quite large. I do not expect it to
exceed 50 characters, probably even less are sufficient.
I'd say go ahead and commit the patches to openvas-libraries
and openvas-libnasl.
For openvas-libnasl you need to set the dependency correctly
for openvas-libraries >= 1.0.2 then. Hope the dependency
check works for the SVN versions (not tested yet).
Best
Jan
--
Dr. Jan-Oliver Wagner Intevation GmbH, Osnabrück
Amtsgericht Osnabrück, HR B 18998 http://www.intevation.de/
Geschäftsführer: Frank Koormann, Bernhard Reiter, Dr. Jan-Oliver Wagner
_______________________________________________
Openvas-devel mailing list
Openvas-devel@wald.intevation.org
http://lists.wald.intevation.org/mailman/listinfo/openvas-devel
