Hi,

I addressed the first of the three described issues:

On Freitag, 2. Mai 2008, Bernhard Herzog wrote:
> [EMAIL PROTECTED] writes:
> > Modified: trunk/openvas-libraries/libopenvas/comm.h
> > ===================================================================
> > --- trunk/openvas-libraries/libopenvas/comm.h       2008-04-30 17:28:13 UTC 
> > (rev 841)
> > +++ trunk/openvas-libraries/libopenvas/comm.h       2008-04-30 19:16:43 UTC 
> > (rev 842)
> > @@ -56,6 +56,7 @@
> >                        regarding the start and end of the whole scan
> >                        and of each server (msg TIME)
> >                      */
> > +  int plugins_oid:1;       /* the the OID of the plugins along with their 
> > version */
> >    int plugins_cve_id:1;    /* the the CVE ID of the plugins along with 
> > their version */
> >  
> >    int dns:1; /* send the host name and host ip */
> 
> I'm don't think it's a good idea to introduce this flag yet.  It
> describes the protocol between client and server and we haven't changed
> that yet.  Also, that flag is not used anywhere yet and it's a binary
> incompatible change in libopenvas.  Furthermore, there are some
> potentially nasty problems with openvas-server which has it's own copy
> of the ntp_caps struct in openvas-server/include/openvas-devel.h.
> There's an #ifdef in openvas-libraries/libopenvas/comm.h to make sure
> that libopenvas/comm.h's version of ntp_caps is not compiled when
> openvas-devel.h has been included.  So it seems that we need to make
> sure to keep both copies in sync.  It would, of course, be better to
> only have one definition of that struct.

I've cleaned up the situation now. See my recent commits to openvas-libraries
and openvas-server.

I raised dependency of openvas-server to openvas-libraries 1.0.2, so the next
upcoming release with the changed include files.

Bernhard: Do you think the nasty part is resolved this way?
 
Best

        Jan
-- 
Dr. Jan-Oliver Wagner                        Intevation GmbH, Osnabrück
Amtsgericht Osnabrück, HR B 18998             http://www.intevation.de/
Geschäftsführer: Frank Koormann, Bernhard Reiter, Dr. Jan-Oliver Wagner
_______________________________________________
Openvas-devel mailing list
[email protected]
http://lists.wald.intevation.org/mailman/listinfo/openvas-devel

Reply via email to