Hi,
Currently our existing test suite - see
http://www.securityspace.com/smysecure/index.html (table).
There's Fedora - 1778 scripts,
Mandrake - 1364 scripts
RedHat - 1177 scripts
etc. etc (any Local family reliant on rpms is
impacted by this function).
I realize these aren't in OpenVAS at this point in time,
and while OpenVAS should retain priority over any
proprietary scripts, my suggestion would be to avoid
making change to functioning, debugged code simply
for convenience sake.
In this case, several changes already were made (newlines
in gather-package-list.nasl) which introduced a bug (caused
isrpmvuln to break), and then a change was made in isrpmvuln
which introduced a bug by allowing overly permissive regex
pattern matching, causing false positives.
Again, if there's a compelling reason to change something,
fine, let's do it - OpenVAS takes priority. But arbitrary
structure changes to existing, debugged functions don't
in my mind fall in the category of compelling changes.
(And as witnessed, can have unintended consequences.)
Thomas
Carsten Koch-Mauthe wrote:
> Hi Thomas,
>
>> This checkin is breaking about 2500 of our scripts, due to
>> a change in calling notation for the "rpm" parameter.
>
> Which scripts are using this inc ?
> /openvas-plugins/scripts> grep -i "pkg-lib-rpm.inc" *
> returns zero results on my system.
> Do i miss something ?
>
_______________________________________________
Openvas-devel mailing list
Openvas-devel@wald.intevation.org
http://lists.wald.intevation.org/mailman/listinfo/openvas-devel
