Hi
sure; you are right, 1) first patch was diff'ed in wrong direction, my fault
2) could have done at least the first patch with svn diff.
felix
On Friday 17 October 2008 14:53:06 Bernhard Herzog wrote:
> Hi,
>
> Felix Wolfsteller <[EMAIL PROTECTED]> writes:
> > --- 0/comm.c 2008-10-17 09:24:59.725068737 +0200
> > +++ client_svn/nessus/comm.c 2008-10-17 11:27:37.501520328 +0200
> > @@ -129,11 +129,12 @@
> > * plugin in it.
> > */
> > static struct nessus_plugin *
> > -parse_plugin(char * buf)
> > +parse_plugin(buf)
> > + char *buf;
> > {
>
> At first I thought you proposed to introduce more K&R style function
> definitions and variables named "l". But it seems the you produced the
> patch in reverse order. If that's the case the patch looks OK.
>
> The easiest way to produce patches in the correct order is to simply modify
> the code in an SVN working copy and use the "svn diff" command. That would
> have the additional benefit of including the SVN revision in the diff.
>
>
> Bernhard
--
Felix Wolfsteller | ++49-541-335 08 3451 | http://www.intevation.de/
PGP Key: 39DE0100
Intevation GmbH, Neuer Graben 17, 49074 Osnabrück | AG Osnabrück, HR B 18998
Geschäftsführer: Frank Koormann, Bernhard Reiter, Dr. Jan-Oliver Wagner
_______________________________________________
Openvas-devel mailing list
Openvas-devel@wald.intevation.org
http://lists.wald.intevation.org/mailman/listinfo/openvas-devel
