Looks good to me. To be honest I was a bit confused about the style too because of the mixing in the existing code. So I will stick to the style guide in the future.
Thanks Christian Felix Wolfsteller wrote: > Updated attached patch, line 206 now reads: > efree (&ret); > -- felix > > On Tuesday 10 November 2009 09:40:59 Felix Wolfsteller wrote: >> Hi Christian, >> thanks for the patch. >> Looks good to me, except for style (refer to >> http://www.openvas.org/compendium/source-code-style-guide.html) and three >> memleaks, if i am not mistaken: >> (1) (translate_vhost) variable "temp" was not freed. >> (2) (target_file_to_list) "ret" lost. >> (3) (target_translate) "s_wo_white" lost. >> Also, in that file, usage of char* and gchar* is mixed, which should >> generally be avoided. I did not make any changes to that (neither did you, >> it was like that before). >> >> I was about to commit a modified version of your changes, but did not >> want/could not test. The patch is attached, please review. >> >> Feel free to join http://wald.intevation.org/projects/openvas/ and request >> commit rights. >> >> enjoy >> -- felix >> >> On Tuesday 10 November 2009 05:42:26 Christian Kuersteiner wrote: >>> Hello, >>> >>> I created a small patch for the OpenVAS Client to allow entering of >>> virtual hosts in the format ip[vhost1,vhost2]. It should work both in >>> gui and cli mode. >>> The next part will be to group the report accordingly. >>> >>> Please feel free to comment or commit it :-) >>> >>> BR, >>> >>> Christian > > > > ------------------------------------------------------------------------ > > _______________________________________________ > Openvas-devel mailing list > Openvas-devel@wald.intevation.org > http://lists.wald.intevation.org/mailman/listinfo/openvas-devel _______________________________________________ Openvas-devel mailing list Openvas-devel@wald.intevation.org http://lists.wald.intevation.org/mailman/listinfo/openvas-devel
