> + if(defined_func("script_mandatory_keys"))
> +   script_mandatory_keys("Tools/Present/nmap");
> +
>   exit(0);
>  }


I had looked at this originally and decided against it.

The way the toolcheck nasl runs, if the "Perform tool
check" preference is set to no, none of the Tools/*
keys will be set, having the effect of disabling
scripts relying on these tools.  I'm not convinced
that this is correct behaviour.

I believe (although I might be mistaken) that
toolcheck is an advisory report, by default enabled,
to let one know that there are additional tools
that one could install to improve scanner functionality.
I don't think it was intended as a setting to turn off
all supplementary tools.

In other words, if we want to rely on Tools/* keys,
we need to change the toolcheck nasl script to
check for tools, ALWAYS populate keys, and only report
based on the preference setting.    Then, and only
then, is it ok to make various scripts dependent on the
tools/* keys.

Thomas

_______________________________________________
Openvas-devel mailing list
Openvas-devel@wald.intevation.org
http://lists.wald.intevation.org/mailman/listinfo/openvas-devel

Reply via email to