Hi, I'm not sure I understand the actual rationale for removing the existing find_service.c plugin.
a) It's a non-trivial excercise, so there needs to be actual gains seen out of doing it (which I don't see). b) We already get dynamic update of plugin capability if we want it if we include the nmap database in the feed (which I agree _should_ be done (but beware of ensuring that the config files we distribute in the feed match the version of nmap that is out there and might be installed on the scanning system). c) find_service.c almost _never_ gets updated anyways, so we don't need to change it, only complement it (the capability which already exists with item b) above c) Reliability of the tool chain (in a minor way) moves out of our control into the nmap arena for a critical component of any scan (break service detection, the whole scan is broken). I can see situations easily developing where distro X has a version of nmap incompatible with the nmap db we distribute. I am a firm believer of "if it ain't broke, don't fix it". Given that find_service.c essentially is not updated and we have the ability to complement it with nmap, I do not see an upside to removing find_service.c and changing it to an external dependency using code that may not be in sync with the version of OpenVAS installed. Am I missing something here? Thomas Chandrashekhar B wrote: > Hello All, > > I have added a new CR to integrate NMAP based service detection as a > replacement for the current find_service method. > > #43 - NMAP based service detection http://www.openvas.org/openvas-cr-43.html > > Please review and let me know if there are any concerns, comments or > suggestions. > > Thanks, > Chandra. > > > _______________________________________________ > Openvas-devel mailing list > Openvas-devel@wald.intevation.org > http://lists.wald.intevation.org/mailman/listinfo/openvas-devel > _______________________________________________ Openvas-devel mailing list Openvas-devel@wald.intevation.org http://lists.wald.intevation.org/mailman/listinfo/openvas-devel
