On Wednesday June 30 2010 12:39:10 Michael Wiegand wrote: > Hi, > > over the last few days I've made a few minor changes to the CMakeLists.txt > files in openvas-libraries which in my opinion help us to use cmake better > and possibly in the way it is intended to be used. ;) > > However, before I change other modules using cmake as well, I'd like some > feedback from other developers to the following suggestions: > > - We seem to set CMAKE_VERBOSE_MAKEFILE to ON by default. This produces a > large amount of output when building; I've found that switching it to OFF > makes it much more easy to spot compiler warnings as it causes them to > really stand out among the otherwise more concise output. Any opinions > against making OFF the default setting for CMAKE_VERBOSE_MAKEFILE?
I'm fine if you turn it off by default as long as you let me turn it on again by passing "-DCMAKE_VERBOSE_MAKEFILE=ON". The reason I need it is that the rpmlint checks go over the build log and therefore need the verbose output. > - I've noticed that in a lot of CMakeLists.txt most or all of the flags > listed in CMAKE_C_FLAGS are repeated in CMAKE_C_FLAGS_DEBUG. The way I > understand cmake, CMAKE_C_FLAGS_DEBUG are used _in addition_ to > CMAKE_C_FLAGS if CMAKE_BUILD is set to "Debug", which makes repeating > flags in > CMAKE_C_FLAGS_DEBUG pretty redundant. Or did I miss something? > > - In a number of places, we use exec_program to execute external > executables like pkg-config and other *-config scripts. The cmake > documentation lists exec_program as deprecated and suggests > execute_process instead. > execute_process is indeed more flexible and allows for a more robust build > process, for example when a config script returns just a newline character. > Should we start replacing exec_program with execute_process? > > - Should we make more use of the CMAKE_BUILD_TYPE variable? Right now, it > is always set to "Debug", which is probably not what we want for release > builds. I'd favor a single top-level switch to control the build type and > set CMAKE_BUILD_TYPE accordingly in the sub-modules. Any opinions on that? > > Looking forward to your feedback, > > Michael _______________________________________________ Openvas-devel mailing list Openvas-devel@wald.intevation.org http://lists.wald.intevation.org/mailman/listinfo/openvas-devel
