Hello Hani, On Friday 02 November 2012 11:40:24 Hani Benhabiles wrote: > I am attaching a set of patches that add scap synchronization feature to > the Greenbone Security Assistant.
very nice! > ov-mgr-scap-sync.patch: Adds --describe and --feedversion support for > openvas-scapdata-sync script. this patch looks OK. I've just comitted a analog patch for the greenbone-scap-sync. So, please go ahead and commit this file. Don't forget to update the ChangeLog together. > ov-adm-scap-sync.patch: Adds the possibility to specify scap-script option > for openvasad (defaulting to openvas-scapdata-sync). sync_scap and > describe_scap commands were also added. The patch also includes an > interface change. Now, openvas_sync_feed() and > openvas_get_sync_script_identification() take a 3rd argument to specify > whether the wanted synchronization is for NVT or SCAP (other > synchronizations types would be easier to add in the future) to profit from > some code reusing. > All the necessary modifications for this change were applied and all > relevant documentation was updated. looks very good. I noticed that you used some <tab> in the code. For OpenVAS we have the rule to not use an <tab> in the code. > ov-gsa-scap-sync.patch: Adds get_scap and sync_scap commands, > synchronization menu, buttons, relevant help documentation etc,. to > Greenbone Security Assistant. Looks very good as well! > Reviews and feedback are welcome. Let me know if there are any issues or > possible improvements. I tried to run the sync via GSA, but so this in the openvasad.log: ad admin:WARNING:2012-11-03 19h42.31 CET:11988: greenbone-scapdata-sync is not a NVT synchronization script. I checked the code and found that this is send from openvas_get_sync_script_identification() which is using feed_type. AFAICS, feed_type will never be called with something else than NVT_FEED. What do I need to get this to work for the greenbone-scap-sync script? Best Jan -- Dr. Jan-Oliver Wagner | ++49-541-335084-0 | http://www.greenbone.net/ Greenbone Networks GmbH, Neuer Graben 17, 49074 Osnabrück | AG Osnabrück, HR B 202460 Geschäftsführer: Lukas Grunwald, Dr. Jan-Oliver Wagner _______________________________________________ Openvas-devel mailing list Openvas-devel@wald.intevation.org http://lists.wald.intevation.org/cgi-bin/mailman/listinfo/openvas-devel
