I should have used the DAEMON variable instead. Here is a new patch that
does this.
Simon
On 12-11-13 06:01 PM, Simon Deziel wrote:
> Hi all,
>
> I noticed the init script for greenbone-security-assistant had a broken
> "status" command so here's a patch that fixes it.
>
> Prior patching:
>
> root@vas01:~# bash -x /etc/init.d/greenbone-security-assistant status
> ...
> + '[' '!' -f /var/run/gsad.pid ']'
> ++ cat /var/run/gsad.pid
> + pid=14052
> + '[' -z 14052 ']'
> + '[' '!' -d /proc/14052 ']'
> ++ cut -d : -f 1
> ++ head -n 1
> ++ tr '\000' '\n'
> ++ cat /proc/14052/cmdline
> + cmd=/usr/sbin/gsad
> + '[' /usr/sbin/gsad '!=' gsad ']'
> + return 1
> + echo ' not running.'
> not running.
> + exit 1
>
> After:
>
> root@vas01:~# bash -x /etc/init.d/greenbone-security-assistant status
> ...
> + '[' '!' -f /var/run/gsad.pid ']'
> ++ cat /var/run/gsad.pid
> + pid=14052
> + '[' -z 14052 ']'
> + '[' '!' -d /proc/14052 ']'
> ++ cut -d : -f 1
> ++ head -n 1
> ++ tr '\000' '\n'
> ++ cat /proc/14052/cmdline
> + cmd=/usr/sbin/gsad
> + '[' /usr/sbin/gsad '!=' /usr/sbin/gsad ']'
> + return 0
> + echo running
> running
> + exit 0
>
> Regards,
> Simon
>
--- /etc/init.d/greenbone-security-assistant-orig 2012-11-13 17:50:07.184473506 -0500
+++ /etc/init.d/greenbone-security-assistant 2012-11-13 18:03:50.618229504 -0500
@@ -40,7 +40,6 @@
DAEMON=/usr/sbin/gsad
PIDFILE=/var/run/gsad.pid
-NAME=gsad
LABEL="Greenbone Security Assistant"
test -x $DAEMON || exit 0
@@ -59,7 +58,7 @@
[ ! -d /proc/$pid ] && return 1
cmd=`cat /proc/$pid/cmdline | tr "\000" "\n"|head -n 1 |cut -d : -f 1`
# No gsad?
- [ "$cmd" != "$NAME" ] && return 1
+ [ "$cmd" != "$DAEMON" ] && return 1
return 0
}
_______________________________________________
Openvas-devel mailing list
Openvas-devel@wald.intevation.org
https://lists.wald.intevation.org/cgi-bin/mailman/listinfo/openvas-devel
