I think exit(0) would be the way to do as a means to deprecate. I ran a check to detect duplicate script_id and script_name. It reported quiet a few. I have addressed some of them but, number of freebsd_* scripts have duplicate script_name.
We should put checks in order to verify duplicate ID's, script name etc. This will ensure that before plugins release, such errors are caught and addressed. We had been talking about this for quiet sometime, haven't found the time to put this into process. We'll take this up soon. Thanks, Chandra. -----Original Message----- From: [email protected] [mailto:[email protected]] On Behalf Of Thomas Reinke Sent: Friday, March 06, 2009 1:34 AM To: [email protected] Subject: Re: [Openvas-discuss] Duplicate plugin IDs I think there was a misunderstanding. I mean replace the ENTIRE script with the one line "exit(0)", not just the actual test logic. Remove everything, including the "if(description)" section, leaving only one line in the file. The server won't read anything (except exit). It thus can't pass anything on to make the user think the script is still active. There won't be any plugin ID conflicts, since there won't be a plugin ID in the deprecated script. You can't overwrite a different script (well, unless you are grabbing stuff from multiple sources and filenames themselves conflict, which is a completely different problem). And it won't require any code tweaks in the server. Thomas Shawn Duffy wrote: > Well, I think the problem there is twofold: > > 1) It'll still show up as loaded and a user may think they're checking > for something they're not actually checking for. > > 2) If it has a plugin ID that's in use by another plugin (of which there > appear to be 5 duplicate ID sets in the current distro) you may end up > loading an outdated plugin over top an active one and OpenVAS will try > to execute the outdated one rather than the real one. I'm assuming > that's the case since it appears to manage plugins via plugin ID. > > I was proposing putting some sort of tag in a plugin that indicates that > it should no longer be used. It would require some tweaking of the > OpenVAS server code but only a minor tweak. If the deprecated tag is > present, don't load the plugin and move on. It would also help in > easily searching through existing plugins for ones that are outdated. _______________________________________________ Openvas-discuss mailing list [email protected] http://lists.wald.intevation.org/mailman/listinfo/openvas-discuss _______________________________________________ Openvas-discuss mailing list [email protected] http://lists.wald.intevation.org/mailman/listinfo/openvas-discuss
