Attention is currently required from: plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/507?usp=email )
Change subject: Implement support for larger packet counter sizes ...................................................................... Patch Set 3: Code-Review-2 (7 comments) Patchset: PS3: DCO check is broken. Otherwise mostly documentation/comment nitpicks. File src/openvpn/crypto.h: http://gerrit.openvpn.net/c/openvpn/+/507/comment/425de6c1_e1212b4d : PS3, Line 292: * big ending number in the wire format. "endian"? File src/openvpn/crypto.c: http://gerrit.openvpn.net/c/openvpn/+/507/comment/aaac8918_9f1ed366 : PS3, Line 393: /* Combine IV from explicit part from packet and implicit part from context, End on ".", not "," http://gerrit.openvpn.net/c/openvpn/+/507/comment/fa740d6c_61efdac1 : PS3, Line 394: * the length of the implicit length is initialised when the implicit is That sentence is very unwieldy. Maybe: "implicit_iv and implicit_iv_len are initialised in init_key_contexts together with the keys". File src/openvpn/dco.h: http://gerrit.openvpn.net/c/openvpn/+/507/comment/fe17f58d_4c954e37 : PS3, Line 253: * Return if the dco implementation supports the new protocol features of "if" -> "whether" File src/openvpn/init.c: http://gerrit.openvpn.net/c/openvpn/+/507/comment/60255894_aea373fc : PS3, Line 3308: to.data_v3_features_supported = false; I think you mean "to.data_v3_features_supported = dco_supports_data_v3(c)" ? File src/openvpn/ssl_ncp.c: http://gerrit.openvpn.net/c/openvpn/+/507/comment/0600a4d8_bb1a41ed : PS2, Line 433: if (session->opt->data_v3_features_supported && (iv_proto_peer & IV_PROTO_DATA_V3)) > The thing here is that I didn't want to introduce two IV_PROTO flags and so > the 2nd patch for the tw […] Acknowledged -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/507?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I01e258e97351b5aa4b9e561f5b35ddc2318569e2 Gerrit-Change-Number: 507 Gerrit-PatchSet: 3 Gerrit-Owner: plaisthos <arne-open...@rfc2549.org> Gerrit-Reviewer: flichtenheld <fr...@lichtenheld.com> Gerrit-CC: openvpn-devel <openvpn-devel@lists.sourceforge.net> Gerrit-Attention: plaisthos <arne-open...@rfc2549.org> Gerrit-Comment-Date: Mon, 18 Mar 2024 15:54:38 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: plaisthos <arne-open...@rfc2549.org> Comment-In-Reply-To: flichtenheld <fr...@lichtenheld.com> Gerrit-MessageType: comment
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
