Attention is currently required from: plaisthos, ralf_lici. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/685?usp=email )
Change subject: Add support for HAProxy's PROXY protocol ...................................................................... Patch Set 1: Code-Review-1 (3 comments) Patchset: PS1: Only looked through it superficially. Aside from the comments it would be good if we could have some kind of unit-test for the parsing code. File src/openvpn/proxy_protocol.h: http://gerrit.openvpn.net/c/openvpn/+/685/comment/364aa307_26397b78 : PS1, Line 8: * Copyright (C) 2002-2024 OpenVPN Inc <sa...@openvpn.net> Wrong copyright File src/openvpn/proxy_protocol.c: http://gerrit.openvpn.net/c/openvpn/+/685/comment/f678bd92_399015cd : PS1, Line 8: * Copyright (C) 2002-2024 OpenVPN Inc <sa...@openvpn.net> Wrong copyright -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/685?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I9766c68feaba71279f26c3310eee4b5ca215e6ac Gerrit-Change-Number: 685 Gerrit-PatchSet: 1 Gerrit-Owner: ralf_lici <r...@mandelbit.com> Gerrit-Reviewer: flichtenheld <fr...@lichtenheld.com> Gerrit-Reviewer: plaisthos <arne-open...@rfc2549.org> Gerrit-CC: openvpn-devel <openvpn-devel@lists.sourceforge.net> Gerrit-Attention: plaisthos <arne-open...@rfc2549.org> Gerrit-Attention: ralf_lici <r...@mandelbit.com> Gerrit-Comment-Date: Fri, 26 Jul 2024 09:42:44 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
