Attention is currently required from: plaisthos, stipa.

flichtenheld has posted comments on this change. ( 
http://gerrit.openvpn.net/c/openvpn/+/725?usp=email )

Change subject: dco-win: support for data_v3 features
......................................................................


Patch Set 2: Code-Review-1

(3 comments)

File src/openvpn/dco_freebsd.c:

http://gerrit.openvpn.net/c/openvpn/+/725/comment/a79e147a_2242a84e :
PS2, Line 424: slot
Now that you changed the type of co_flags, change to %u here.


File src/openvpn/dco_linux.c:

http://gerrit.openvpn.net/c/openvpn/+/725/comment/e9388cee_92854160 :
PS2, Line 562: cipher
%u


File src/openvpn/dco_win.c:

http://gerrit.openvpn.net/c/openvpn/+/725/comment/bc8d5955_1befe0c2 :
PS2, Line 340: cipher
%u



--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/725?usp=email
To unsubscribe, or for help writing mail filters, visit 
http://gerrit.openvpn.net/settings

Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I2e0c50d33f8a57c023120cf348f95d34acbfcde5
Gerrit-Change-Number: 725
Gerrit-PatchSet: 2
Gerrit-Owner: stipa <lstipa...@gmail.com>
Gerrit-Reviewer: flichtenheld <fr...@lichtenheld.com>
Gerrit-Reviewer: plaisthos <arne-open...@rfc2549.org>
Gerrit-CC: openvpn-devel <openvpn-devel@lists.sourceforge.net>
Gerrit-Attention: plaisthos <arne-open...@rfc2549.org>
Gerrit-Attention: stipa <lstipa...@gmail.com>
Gerrit-Comment-Date: Thu, 15 Aug 2024 12:36:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
_______________________________________________
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Reply via email to