Attention is currently required from: cron2, flichtenheld, plaisthos. stipa has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/733?usp=email )
Change subject: dco-win: factor out getting dco version info own function ...................................................................... Patch Set 2: (4 comments) File src/openvpn/dco_win.c: http://gerrit.openvpn.net/c/openvpn/+/733/comment/8f07dbeb_507f5019 : PS1, Line 102: msg(D_DCO_DEBUG, "dco data_v3: %d", dco->supports_data_v3); > I think keeping the "supports" here (= not changing the text) would ease > understanding of the logs. Acknowledged http://gerrit.openvpn.net/c/openvpn/+/733/comment/3508d8c9_0dd6626f : PS1, Line 474: ZeroMemory(&version, sizeof(version)); > `CLEAR(version)` exists (if you change this line anyway). […] Agreed. Will use = {0} here and also CLEAN() within get_version() itself to make sure it zeroes fields and doesn't depend on the caller. http://gerrit.openvpn.net/c/openvpn/+/733/comment/d5b2be96_d092b75d : PS1, Line 481: return BSTR(&out); > technically this does something else if no DCO driver can be found - the old > code returns "N/A", the […] Good point, other platforms return "N/A", will bring it back. http://gerrit.openvpn.net/c/openvpn/+/733/comment/e42a0200_3120a0fe : PS1, Line 562: dco_get_version(&version); > see above wrt `CLEAR()` or `= {0}` Done -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/733?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I8e8ddd35bd3cc3334faf7f57118d1892512ae9f7 Gerrit-Change-Number: 733 Gerrit-PatchSet: 2 Gerrit-Owner: stipa <lstipa...@gmail.com> Gerrit-Reviewer: flichtenheld <fr...@lichtenheld.com> Gerrit-Reviewer: plaisthos <arne-open...@rfc2549.org> Gerrit-CC: cron2 <g...@greenie.muc.de> Gerrit-CC: openvpn-devel <openvpn-devel@lists.sourceforge.net> Gerrit-Attention: plaisthos <arne-open...@rfc2549.org> Gerrit-Attention: cron2 <g...@greenie.muc.de> Gerrit-Attention: flichtenheld <fr...@lichtenheld.com> Gerrit-Comment-Date: Tue, 10 Sep 2024 09:17:44 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: cron2 <g...@greenie.muc.de> Gerrit-MessageType: comment
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
