Attention is currently required from: cron2, plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/724?usp=email )
Change subject: configure: Handle libnl-genl and libcap-ng consistent with other libs ...................................................................... Patch Set 3: (3 comments) Patchset: PS3: > Feature-ACK, but it does not work for me. […] hmm, works for me. File configure.ac: http://gerrit.openvpn.net/c/openvpn/+/724/comment/a0cd9504_a65fc9b8 : PS3, Line 1495: AC_SUBST([OPTIONAL_LIBNL_GENL_LIBS]) > so what are these needed for? I see that the generated > `src/openvpn/Makefile` has both […] Yeah, I assume this is related to that LIBNL_GENL_CFLAGS is automatically generated by PKG_CHECK_MODULES. The OPTIONAL_ makes sure we have a consistent place to put the arguments that we completely control. But in this case I just made the code consistent. http://gerrit.openvpn.net/c/openvpn/+/724/comment/3aa88266_2f45c1c9 : PS3, Line 1545: TEST_CFLAGS="${TEST_CFLAGS} -I\$(top_srcdir)/include ${CMOCKA_CFLAGS}" > This is `TEST_*` only, but shouldn't we have these for `AM_CFLAGS` and > `openvpn_LDADD` as well? This is handled by the patch in Makefile.am -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/724?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I39a6f58b11b922f5dbd3e55a5bc8574eda8a83fe Gerrit-Change-Number: 724 Gerrit-PatchSet: 3 Gerrit-Owner: flichtenheld <fr...@lichtenheld.com> Gerrit-Reviewer: cron2 <g...@greenie.muc.de> Gerrit-Reviewer: plaisthos <arne-open...@rfc2549.org> Gerrit-CC: openvpn-devel <openvpn-devel@lists.sourceforge.net> Gerrit-Attention: plaisthos <arne-open...@rfc2549.org> Gerrit-Attention: cron2 <g...@greenie.muc.de> Gerrit-Comment-Date: Tue, 17 Sep 2024 13:28:02 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: cron2 <g...@greenie.muc.de> Gerrit-MessageType: comment
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
