Attention is currently required from: flichtenheld, plaisthos.

cron2 has posted comments on this change. ( 
http://gerrit.openvpn.net/c/openvpn/+/748?usp=email )

Change subject: Change dev null to be a driver type instead of a special mode 
of tun/tap
......................................................................


Patch Set 9: Code-Review-1

(2 comments)

Patchset:

PS9:
close :-)


File src/openvpn/dco.c:

http://gerrit.openvpn.net/c/openvpn/+/748/comment/ba0f33a0_74f63ab7 :
PS9, Line 312:             "offload");
the wrapping has lost the space ("data channeloffload") and I wouldn't actuall 
break the string here... this is more ugly than a 87 character long line (and I 
think our styleguide permits this)



--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/748?usp=email
To unsubscribe, or for help writing mail filters, visit 
http://gerrit.openvpn.net/settings

Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I5987ebb7c38ab176eed7efc004ea54f606a77a12
Gerrit-Change-Number: 748
Gerrit-PatchSet: 9
Gerrit-Owner: plaisthos <arne-open...@rfc2549.org>
Gerrit-Reviewer: cron2 <g...@greenie.muc.de>
Gerrit-Reviewer: flichtenheld <fr...@lichtenheld.com>
Gerrit-CC: openvpn-devel <openvpn-devel@lists.sourceforge.net>
Gerrit-Attention: plaisthos <arne-open...@rfc2549.org>
Gerrit-Attention: flichtenheld <fr...@lichtenheld.com>
Gerrit-Comment-Date: Thu, 19 Sep 2024 07:03:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
_______________________________________________
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Reply via email to