Attention is currently required from: flichtenheld, plaisthos, stipa. cron2 has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/879?usp=email )
Change subject: route.c: improve get_default_gateway() logic on Windows ...................................................................... Patch Set 2: (2 comments) File src/openvpn/route.c: http://gerrit.openvpn.net/c/openvpn/+/879/comment/a12cf014_08dcec58 : PS2, Line 2812: DWORD a_index = adapter_index_of_ip(adapters, rgi->gateway.addr, NULL, &rgi->gateway.netmask); This fails for `ON_LINK` targets, where `gateway.addr == 0.0.0.0`. The IPv6 code uses `BestRoute.InterfaceIndex`, because Windows nicely hands this to us anyway. http://gerrit.openvpn.net/c/openvpn/+/879/comment/879c7db7_bf0b726d : PS2, Line 2827: the IPv6 part sets the `RGI_ON_LINK` flag when the `BestRoute.Nexthop` points to an empty IPv6 address. Testing with v4 seems to be similar, so for an onlink-prefix (same IPv4 subnet as on the LAN interface, or just `127.0.0.1` to trigger `on-link I=1`) I get "ROUTE_GATEWAY 0.0.0.0" - but no ON_LINK for v4, yet. -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/879?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I6c7e1cef637fe9fb3f3bc6ff4fb2c65599cd86fb Gerrit-Change-Number: 879 Gerrit-PatchSet: 2 Gerrit-Owner: stipa <lstipa...@gmail.com> Gerrit-Reviewer: cron2 <g...@greenie.muc.de> Gerrit-Reviewer: flichtenheld <fr...@lichtenheld.com> Gerrit-Reviewer: plaisthos <arne-open...@rfc2549.org> Gerrit-CC: openvpn-devel <openvpn-devel@lists.sourceforge.net> Gerrit-Attention: plaisthos <arne-open...@rfc2549.org> Gerrit-Attention: flichtenheld <fr...@lichtenheld.com> Gerrit-Attention: stipa <lstipa...@gmail.com> Gerrit-Comment-Date: Fri, 31 Jan 2025 10:56:03 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
