Attention is currently required from: flichtenheld.
Hello flichtenheld,
I'd like you to do a code review.
Please visit
http://gerrit.openvpn.net/c/openvpn/+/891?usp=email
to review the following change.
Change subject: Reconnect when TCP is on use on network-change management
command
......................................................................
Reconnect when TCP is on use on network-change management command
On some newer Android handsets, changing to a different network
often does not trigger a TCP reset but continues using the old
connection (e.g. using mobile connection when WiFi becomes available)
Force a reconnect in these situation to have a more expected beheaviour.
Change-Id: Id4febcceecab33ee5189cd67b249a15d12b84799
Signed-off-by: Arne Schwabe <[email protected]>
---
M src/openvpn/init.c
1 file changed, 9 insertions(+), 0 deletions(-)
git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/91/891/1
diff --git a/src/openvpn/init.c b/src/openvpn/init.c
index a7f7db4..b5eeeb8 100644
--- a/src/openvpn/init.c
+++ b/src/openvpn/init.c
@@ -4390,6 +4390,15 @@
return -1;
}
+ /* On some newer Android handsets, changing to a different network
+ * often does not trigger a TCP reset but continue using the old
+ * connection (e.g. using mobile connection when WiFi becomes available */
+ struct link_socket_info *lsi = get_link_socket_info(c);
+ if (lsi && proto_is_tcp(lsi->proto) && !samenetwork)
+ {
+ return -2;
+ }
+
socketfd = c->c2.link_sockets[0]->sd;
if (!c->options.pull || c->c2.tls_multi->use_peer_id || samenetwork)
{
--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/891?usp=email
To unsubscribe, or for help writing mail filters, visit
http://gerrit.openvpn.net/settings
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: Id4febcceecab33ee5189cd67b249a15d12b84799
Gerrit-Change-Number: 891
Gerrit-PatchSet: 1
Gerrit-Owner: plaisthos <[email protected]>
Gerrit-Reviewer: flichtenheld <[email protected]>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-Attention: flichtenheld <[email protected]>
Gerrit-MessageType: newchange
_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
