Attention is currently required from: flichtenheld, its_Giaan, ordex, plaisthos.
cron2 has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/941?usp=email ) Change subject: dco_linux: Introduce new uAPIs ...................................................................... Patch Set 4: Code-Review-1 (5 comments) Patchset: PS4: Overall it looks relatively straightforward, with most of the changes just replacing one define with another - easy enough. Testing to come. There are a few changes that break the style of this module, and I see no strong reason why these are done, so -1 for now. File src/openvpn/dco_linux.c: http://gerrit.openvpn.net/c/openvpn/+/941/comment/006d280c_8ba3e1fe : PS4, Line 547: return -1; this change looks unneccessary? http://gerrit.openvpn.net/c/openvpn/+/941/comment/91377007_60a5d367 : PS4, Line 574: } same here... the code style with "one common free()/return at the end" is kept in other places (like dco_del_key()), so why change it here, and in a different style than in dco_swap_keys()? http://gerrit.openvpn.net/c/openvpn/+/941/comment/ed9e335b_8afd8a97 : PS4, Line 591: keyconf = nla_nest_start(nl_msg, OVPN_A_KEYCONF); why wrap differently, and not keep `struct nlattr * nla_nest_start()...`? Line too long? http://gerrit.openvpn.net/c/openvpn/+/941/comment/333dacb6_0b189629 : PS4, Line 860: case OVPN_CMD_KEY_SWAP_NTF: what is KEY_SWAP_NTF? That's a new thing :-) -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/941?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I009f4e7ad38636f1c0b78d267561194c2bb4c051 Gerrit-Change-Number: 941 Gerrit-PatchSet: 4 Gerrit-Owner: its_Giaan <gianma...@mandelbit.com> Gerrit-Reviewer: cron2 <g...@greenie.muc.de> Gerrit-Reviewer: flichtenheld <fr...@lichtenheld.com> Gerrit-Reviewer: ordex <anto...@mandelbit.com> Gerrit-Reviewer: plaisthos <arne-open...@rfc2549.org> Gerrit-CC: openvpn-devel <openvpn-devel@lists.sourceforge.net> Gerrit-Attention: plaisthos <arne-open...@rfc2549.org> Gerrit-Attention: its_Giaan <gianma...@mandelbit.com> Gerrit-Attention: flichtenheld <fr...@lichtenheld.com> Gerrit-Attention: ordex <anto...@mandelbit.com> Gerrit-Comment-Date: Fri, 02 May 2025 20:35:00 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
