Attention is currently required from: flichtenheld, ordex, plaisthos. cron2 has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/791?usp=email )
Change subject: Reformat the whole project with clang-format ...................................................................... Patch Set 23: Code-Review+2 (3 comments) Patchset: PS23: So, reviewed most of this, and especially tested this on all the testbeds (nothing fails). As agreed, move to "ColumnLimit: 0" afterwards with a cleanup patch, as the force-unwrapping by "100" creates ugliness and also "surprising submit fails" - we use common sense ;-) File src/openvpn/crypto.c: http://gerrit.openvpn.net/c/openvpn/+/791/comment/9105cd07_6cc952af : PS18, Line 391: epoch); not sure what happened here... http://gerrit.openvpn.net/c/openvpn/+/791/comment/ce26f764_3092ba12 : PS18, Line 1604: msg(M_FATAL, this is another one where the result is uglier than the start... maybe it needs manual breaking of the string so it can fit "properly" in 2 lines -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/791?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I2566ad493629e1f5fdfa6f6483b8973463404e3e Gerrit-Change-Number: 791 Gerrit-PatchSet: 23 Gerrit-Owner: flichtenheld <fr...@lichtenheld.com> Gerrit-Reviewer: cron2 <g...@greenie.muc.de> Gerrit-Reviewer: plaisthos <arne-open...@rfc2549.org> Gerrit-CC: openvpn-devel <openvpn-devel@lists.sourceforge.net> Gerrit-CC: ordex <anto...@mandelbit.com> Gerrit-Attention: plaisthos <arne-open...@rfc2549.org> Gerrit-Attention: flichtenheld <fr...@lichtenheld.com> Gerrit-Attention: ordex <anto...@mandelbit.com> Gerrit-Comment-Date: Mon, 04 Aug 2025 15:18:30 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
