This has been stared-at, and subjected to testing in the client and server
testbeds ("you never know").

Some of the changes are slightly non-obvious - one thing we discovered
is that clang-format tries really hard to align end-of-line comments,
but only if you do not exceed "ColumnLimit".  If you do, all these
comments get "1 space, only, no matter how much they had before".

So, without the limit, some #endif comments ended up going to column 130-ish,
which made the result non helpful - so you see comments disappear now,
because the #ifdef/endif clauses were so short that it was obvious.

Also, errlevel.h got re-aligned now...  which is nice, but makes this
look much larger.

Your patch has been applied to the master branch.

commit 21f7d6e1ad65b1f7db673bc98764dc7325858e0b
Author: Frank Lichtenheld
Date:   Tue Aug 5 15:27:01 2025 +0200

     clang-format: Switch to ColumnLimit 0

     Signed-off-by: Frank Lichtenheld <fr...@lichtenheld.com>
     Acked-by: Gert Doering <g...@greenie.muc.de>
     Message-Id: <20250805132706.27619-1-g...@greenie.muc.de>
     URL: 
https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg32523.html
     Signed-off-by: Gert Doering <g...@greenie.muc.de>


--
kind regards,

Gert Doering



_______________________________________________
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Reply via email to