Attention is currently required from: cron2, plaisthos. ordex has posted comments on this change by cron2. ( http://gerrit.openvpn.net/c/openvpn/+/1388?usp=email )
Change subject: extract_x509_field_ssl(): verify that X509_NAME is not NULL. ...................................................................... Patch Set 1: Code-Review-1 (1 comment) File src/openvpn/ssl_verify_openssl.c: http://gerrit.openvpn.net/c/openvpn/+/1388/comment/d4be6f27_e032b011?usp=email : PS1, Line 206: if (x509 == NULL) we normally assume parameters are valid and don't do NULL checks right at the beginning of the function body. therefore we should check the return value of `X509_get_subject_name()` before calling `extract_x509_field_ssl()` in `backend_x509_get_username()` -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1388?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I1e9c7eee06bf5f2e8aed8cd2523684539294ac8b Gerrit-Change-Number: 1388 Gerrit-PatchSet: 1 Gerrit-Owner: cron2 <[email protected]> Gerrit-Reviewer: ordex <[email protected]> Gerrit-Reviewer: plaisthos <[email protected]> Gerrit-CC: openvpn-devel <[email protected]> Gerrit-Attention: plaisthos <[email protected]> Gerrit-Attention: cron2 <[email protected]> Gerrit-Comment-Date: Thu, 27 Nov 2025 10:01:44 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes
_______________________________________________ Openvpn-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openvpn-devel
