Attention is currently required from: plaisthos, ralf_lici. cron2 has posted comments on this change by ralf_lici. ( http://gerrit.openvpn.net/c/openvpn/+/1403?usp=email )
Change subject: dco: process messages immediately after read ...................................................................... Patch Set 11: Code-Review-2 (1 comment) File src/openvpn/dco_linux.c: http://gerrit.openvpn.net/c/openvpn/+/1403/comment/19628400_49a99e55?usp=email : PS11, Line 1115: break; actually I think this one should stay as it was before (`return ovpn_handle_peer()`) plus a comment `/* return directly, there are no messages to pass to *process_incoming_dco() */` or such. Since we no longer clear dco->dco_message_type, every OVPN_CMD_PEER_GET will basically call `multi_process_incoming_dco()` with a repeat of the previous message - and if that peer-id is being re-used by a new connect, bad things will happen -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1403?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: Iefc251cb4483c0b9fb9d6a5207db4445cd884d52 Gerrit-Change-Number: 1403 Gerrit-PatchSet: 11 Gerrit-Owner: ralf_lici <[email protected]> Gerrit-Reviewer: cron2 <[email protected]> Gerrit-Reviewer: plaisthos <[email protected]> Gerrit-CC: openvpn-devel <[email protected]> Gerrit-Attention: plaisthos <[email protected]> Gerrit-Attention: ralf_lici <[email protected]> Gerrit-Comment-Date: Fri, 28 Nov 2025 10:37:34 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes
_______________________________________________ Openvpn-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openvpn-devel
