Attention is currently required from: flichtenheld, plaisthos. MaxF has posted comments on this change by MaxF. ( http://gerrit.openvpn.net/c/openvpn/+/1412?usp=email )
Change subject: Drop Mbed TLS 2.X compatibility ...................................................................... Patch Set 2: (3 comments) Patchset: PS1: > configure.ac needs more work. Presumably there should be a CMakeLists. […] CMake doesn't check the version. I think the approach is, if you have the wrong version, the build will just fail. It does a bunch of feature detection which I have now removed though. File configure.ac: http://gerrit.openvpn.net/c/openvpn/+/1412/comment/e31ce4eb_9de17423?usp=email : PS1, Line 998: [mbedtls >= 2.0.0 mbedx509 >= 2.0.0 mbedcrypto >= 2.0.0], > Needs to be updated as well Done http://gerrit.openvpn.net/c/openvpn/+/1412/comment/c2576736_b01015cf?usp=email : PS1, Line 1036: if test "x$ac_cv_func_mbedtls_ssl_conf_export_keys_ext_cb" != xyes; then > Now that we have the stricter version check, can we get rid of these > additional tests? Thanks for pointing that out! In version 3, we always have the export_keys_cb version, this let me remove even more code! -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1412?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: Ia4afabcb6006dc9304a4c09f824d9c7c2d4d64ad Gerrit-Change-Number: 1412 Gerrit-PatchSet: 2 Gerrit-Owner: MaxF <[email protected]> Gerrit-Reviewer: flichtenheld <[email protected]> Gerrit-Reviewer: plaisthos <[email protected]> Gerrit-CC: openvpn-devel <[email protected]> Gerrit-Attention: plaisthos <[email protected]> Gerrit-Attention: flichtenheld <[email protected]> Gerrit-Comment-Date: Fri, 28 Nov 2025 12:59:22 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: flichtenheld <[email protected]>
_______________________________________________ Openvpn-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openvpn-devel
