cron2 has uploaded a new patch set (#2) to the change originally created by selvanair. ( http://gerrit.openvpn.net/c/openvpn/+/1413?usp=email )
The following approvals got outdated and were removed: Code-Review+2 by stipa Change subject: Set UTF-8 as the codepage using manifest declaration ...................................................................... Set UTF-8 as the codepage using manifest declaration Works on Windows 10+. This ensures any UTF-8 string we pass to ANSI API will not get interpreted in some local code page in effect at runtime. Although we do not use any such API, OpenSSL dll we link to does (e.g., the store API used for reading certificate and key from files). OpenSSL may fix this in future versions, but this is an easy workaround that looks harmless and appropriate. Fixes failure to read certificates when filenames contain non-ascii characters reported by: Carsten Mietzsch <[email protected]> Ref: https://learn.microsoft.com/en-us/windows/apps/design/globalizing/use-utf8-code-page Github: OpenVPN/openvpn#920 Change-Id: Ic4e233c788b16a862c1fddcf314a3da661072fb5 Signed-off-by: Selva Nair <[email protected]> Acked-by: Lev Stipakov <[email protected]> Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1413 Message-Id: <[email protected]> URL: https://www.mail-archive.com/[email protected]/msg34805.html Signed-off-by: Gert Doering <[email protected]> --- M src/openvpn/openvpn.manifest 1 file changed, 5 insertions(+), 0 deletions(-) git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/13/1413/2 diff --git a/src/openvpn/openvpn.manifest b/src/openvpn/openvpn.manifest index fa5b3d7..f964152 100644 --- a/src/openvpn/openvpn.manifest +++ b/src/openvpn/openvpn.manifest @@ -14,6 +14,11 @@ <supportedOS Id="{e2011457-1546-43c5-a5fe-008deee3d3f0}"/> </application> </compatibility> + <application> + <windowsSettings> + <activeCodePage xmlns="http://schemas.microsoft.com/SMI/2019/WindowsSettings";>UTF-8</activeCodePage> + </windowsSettings> + </application> <trustInfo xmlns="urn:schemas-microsoft-com:asm.v3"> <security> <requestedPrivileges> -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1413?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: Ic4e233c788b16a862c1fddcf314a3da661072fb5 Gerrit-Change-Number: 1413 Gerrit-PatchSet: 2 Gerrit-Owner: selvanair <[email protected]> Gerrit-Reviewer: cron2 <[email protected]> Gerrit-Reviewer: plaisthos <[email protected]> Gerrit-Reviewer: stipa <[email protected]> Gerrit-CC: openvpn-devel <[email protected]>
_______________________________________________ Openvpn-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openvpn-devel
