Attention is currently required from: plaisthos.
Hello plaisthos,
I'd like you to do a code review.
Please visit
http://gerrit.openvpn.net/c/openvpn/+/1417?usp=email
to review the following change.
Change subject: CMake: For VS build, document what we're missing from /W3
......................................................................
CMake: For VS build, document what we're missing from /W3
Basically -Wconversion and -Wsign-compare, so as expected.
Change-Id: Iffc114939cb37129057e9c4864fae9e09c3c7fe4
Signed-off-by: Frank Lichtenheld <[email protected]>
---
M CMakeLists.txt
1 file changed, 4 insertions(+), 1 deletion(-)
git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/17/1417/1
diff --git a/CMakeLists.txt b/CMakeLists.txt
index b3142e4..906fa04 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -85,9 +85,12 @@
if (USE_WERROR)
add_compile_options(/WX)
endif ()
+ # C4018: signed/unsigned mismatch
+ # C4244: conversion from 'type1' to 'type2', possible loss of data
+ # C4267: conversion from 'size_t' to 'type', possible loss of data
add_compile_options(
/MP
- /W2
+ /W3 /wd4018 /wd4267 /wd4244
/sdl
/Qspectre
/guard:cf
--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1417?usp=email
To unsubscribe, or for help writing mail filters, visit
http://gerrit.openvpn.net/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: Iffc114939cb37129057e9c4864fae9e09c3c7fe4
Gerrit-Change-Number: 1417
Gerrit-PatchSet: 1
Gerrit-Owner: flichtenheld <[email protected]>
Gerrit-Reviewer: plaisthos <[email protected]>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-Attention: plaisthos <[email protected]>
_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
