cron2 has uploaded a new patch set (#4) to the change originally created by selvanair. ( http://gerrit.openvpn.net/c/openvpn/+/1415?usp=email )
The following approvals got outdated and were removed: Code-Review+2 by cron2 Change subject: pull-filter: improve documentation ...................................................................... pull-filter: improve documentation Pull-filter uses a simple string comparison and could be defeated by unusual formatting of pushed option strings. Document that this option is not meant to be used as a security measure. Reported by: <[email protected]> Change-Id: I2c8d40038e52fbdff1c56f93db1e6a2f9255c59a Signed-off-by: Selva Nair <[email protected]> Acked-by: Gert Doering <[email protected]> Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1415 Message-Id: <[email protected]> URL: https://www.mail-archive.com/[email protected]/msg34930.html Signed-off-by: Gert Doering <[email protected]> --- M doc/man-sections/client-options.rst 1 file changed, 5 insertions(+), 0 deletions(-) git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/15/1415/4 diff --git a/doc/man-sections/client-options.rst b/doc/man-sections/client-options.rst index ca4c8e9..b9ae7ce 100644 --- a/doc/man-sections/client-options.rst +++ b/doc/man-sections/client-options.rst @@ -345,6 +345,11 @@ next remote succeeds. To silently ignore an option pushed by the server, use :code:`ignore`. + *Warning:* ``pull-filter`` cannot be relied upon as a security measure to + protect against offending options pushed by a server. For example, the + filter could be defeated by pushing options with extra spaces between + tokens or other formatting variations. + --push-peer-info Push additional information about the client to server. The following data is always pushed to the server: -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1415?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I2c8d40038e52fbdff1c56f93db1e6a2f9255c59a Gerrit-Change-Number: 1415 Gerrit-PatchSet: 4 Gerrit-Owner: selvanair <[email protected]> Gerrit-Reviewer: cron2 <[email protected]> Gerrit-Reviewer: plaisthos <[email protected]> Gerrit-CC: openvpn-devel <[email protected]>
_______________________________________________ Openvpn-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openvpn-devel
