-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On 12/08/16 20:27, Selva Nair wrote: > > On Fri, Aug 12, 2016 at 6:30 AM, David Sommerseth > <open...@sf.lists.topphemmelig.net > <mailto:open...@sf.lists.topphemmelig.net>> wrote: > > On 12/08/16 03:14, Selva Nair wrote: >> >> >> On Thu, Aug 11, 2016 at 2:50 PM, David Sommerseth >> <open...@sf.lists.topphemmelig.net > <mailto:open...@sf.lists.topphemmelig.net> >> <mailto:open...@sf.lists.topphemmelig.net > <mailto:open...@sf.lists.topphemmelig.net>>> wrote: >> [...snip....] > > If the Makefile.am in src/openvpnsrv has a build-target for the > block_dns.c file which would just copy the source file to the > openvpnserv/ directory ... would that work? > > Rough (not really tested) example is attached. > > This is incomplete but could be made to work with some changes. > However, such a hackery is not needed in this particular case as > one could simply replace $(top_srcdir)/src/openvpn/block_dns.c > $(top_srcdir)/src/openvpn/block_dns.h in Makefile.am by > ../../src/openvpn/block_dns.c ../../src/openvpn/block_dns.h and use > the subdir-objects option without issues. > > But the problem is that, its not just these two files, we now have > subdir source references in places like > tests/unit_tests/plugins/auth-pam/Makefile.am as well. Replacing > $(top_srcdir) by something like "../../../../..." in deeply nested > directories would be error-prone and cumbersome. If/when more and > more tests get added this is going to get only worse.
Agreed. And the nesting will be a hassle with time anyhow - suddenly someone tries to move a directory to a different subdir level, and all hell breaks loose again. > I would say ignore the subdir-objects warning for now and we can > conditionally enable it when a version of automake that supports > it without breaking use of variables in foo_SOURCES becomes widely > available. In the mean time keep testing subdir-objects using a > patched automake may be all that we can do. I can live with that for now. But it would be good to have a solution before we get complaints from more bleeding edge distros (Fedora, Arch, Ubuntu, openSUSE etc) that 'automake doesn't work any more' due to our setup isn't modern enough. I'll send a patch to ML fixing the LT_INIT stuff, that should work just fine regardless of the subdir-objects option. - -- kind regards, David Sommerseth OpenVPN Technologies, Inc -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (GNU/Linux) iEYEARECAAYFAleuF5AACgkQDC186MBRfrplnACfVvzPmHWhVTBLU42pqkMhIPIv u7QAnjmO6pU83/SV9GCYZRnnzYLvV8eZ =eHDo -----END PGP SIGNATURE----- ------------------------------------------------------------------------------ What NetFlow Analyzer can do for you? Monitors network bandwidth and traffic patterns at an interface-level. Reveals which users, apps, and protocols are consuming the most bandwidth. Provides multi-vendor support for NetFlow, J-Flow, sFlow and other flows. Make informed decisions using capacity planning reports. http://sdm.link/zohodev2dev _______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
